jprdonnelly/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-05-06 12:01:06 -04:00
Code Issues Projects Releases Wiki Activity

Bugfix: Escape HTML entities (#2777)

Browse Source
This commit is contained in:
mcpiroman
2019-09-18 00:43:24 +02:00
committed by Carlos Zamora
parent 7edbbd1ccb
commit 95580b5f11
1 changed files with 19 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
src/buffer/out/textBuffer.cpp
View File

@@ -1148,9 +1148,25 @@ std::string TextBuffer::GenHTML(const TextAndColor& rows, const int fontHeightPo
const auto writeAccumulatedChars = [&](bool includeCurrent) {
if (col > startOffset)
{
// note: this should be escaped (for '<', '>', and '&'),
// however MS Word doesn't appear to support HTML entities
htmlBuilder << ConvertToA(CP_UTF8, std::wstring_view(rows.text.at(row)).substr(startOffset, col - startOffset + includeCurrent));
const auto unescapedText = ConvertToA(CP_UTF8, std::wstring_view(rows.text.at(row)).substr(startOffset, col - startOffset + includeCurrent));
for (const auto c : unescapedText)
{
switch (c)
{
case '<':
htmlBuilder << "&lt;";
break;
case '>':
htmlBuilder << "&gt;";
break;
case '&':
htmlBuilder << "&amp;";
break;
default:
htmlBuilder << c;
}
}
startOffset = col;
}
};