From 767e758db97a60fc5e65bd1d18a2802a310c3252 Mon Sep 17 00:00:00 2001 From: Max Voitko Date: Fri, 11 Dec 2020 05:40:13 +0200 Subject: [PATCH] Add point in time recovery option in backend configuration (#50) * Add point in time recovery option in backend coniguration * Fix condition --- modules/cloud-sql/main.tf | 7 ++++--- modules/cloud-sql/variables.tf | 6 ++++++ 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/modules/cloud-sql/main.tf b/modules/cloud-sql/main.tf index 0336c17..44834c6 100644 --- a/modules/cloud-sql/main.tf +++ b/modules/cloud-sql/main.tf @@ -73,9 +73,10 @@ resource "google_sql_database_instance" "master" { } backup_configuration { - binary_log_enabled = local.actual_binary_log_enabled - enabled = var.backup_enabled - start_time = var.backup_start_time + binary_log_enabled = local.actual_binary_log_enabled + enabled = var.backup_enabled + start_time = var.backup_start_time + point_in_time_recovery_enabled = local.is_postgres ? var.postgres_point_in_time_recovery_enabled : null } maintenance_window { diff --git a/modules/cloud-sql/variables.tf b/modules/cloud-sql/variables.tf index 5c0f15b..489a577 100644 --- a/modules/cloud-sql/variables.tf +++ b/modules/cloud-sql/variables.tf @@ -81,6 +81,12 @@ variable "backup_start_time" { default = "04:00" } +variable "postgres_point_in_time_recovery_enabled" { + description = "Will restart database if enabled after instance creation - only applicable to PostgreSQL" + type = bool + default = false +} + variable "mysql_binary_log_enabled" { description = "Set to false if you want to disable binary logs - only applicable to MySQL. Note, when using failover or read replicas, master and existing backups need to have binary_log_enabled=true set." type = bool