Merge pull request #32 from qlik-oss/tsm-color-picker-check

Update metric-semaphores.js
Merge pull request #33 from qlik-oss/snapshotFix
2019-04-05 13:46:58 +02:00 · 2019-03-20 10:28:52 +01:00 · 2019-03-19 10:38:29 +01:00 · 2019-03-12 09:04:43 +01:00
7 changed files with 40 additions and 6 deletions
--- a/assets/qlik-smart-pivot.png
+++ b/assets/qlik-smart-pivot.png
--- a/src/data-table/data-cell.jsx
+++ b/src/data-table/data-cell.jsx
@@ -108,7 +108,12 @@ DataCell.propTypes = {
  }).isRequired,
  qlik: PropTypes.shape({
    backendApi: PropTypes.shape({
-      selectValues: PropTypes.func.isRequired
+      selectValues: function (props, propName) {
+        if (props.isSnapshot || typeof props[propName] === 'function') {
+          return null;
+        }
+        return new Error('Missing implementation of qlik.backendApi.selectValues.');
+      }
    }).isRequired
  }).isRequired,
  styleBuilder: PropTypes.shape({
--- a/src/data-table/row-header.jsx
+++ b/src/data-table/row-header.jsx
@@ -46,7 +46,12 @@ RowHeader.propTypes = {
  }).isRequired,
  qlik: PropTypes.shape({
    backendApi: PropTypes.shape({
-      selectValues: PropTypes.func.isRequired
+      selectValues: function (props, propName) {
+        if (props.isSnapshot || typeof props[propName] === 'function') {
+          return null;
+        }
+        return new Error('Missing implementation of qlik.backendApi.selectValues.');
+      }
    }).isRequired
  }).isRequired,
  rowStyle: PropTypes.shape({}).isRequired,
--- a/src/dataset.js
+++ b/src/dataset.js
@@ -67,12 +67,20 @@ function getDimensionIndexes (dimensionsInformation, designDimensionIndex) {
 }

 export async function initializeCubes ({ component, layout }) {
-  const properties = await component.backendApi.getProperties();
-  const originCubeDefinition = properties.qHyperCubeDef;
  const app = qlik.currApp(component);
  const designDimensionIndex = findDesignDimension(layout.qHyperCube.qDataPages[0].qMatrix);
  const dimensionsInformation = layout.qHyperCube.qDimensionInfo;
  const dimensionIndexes = getDimensionIndexes(dimensionsInformation, designDimensionIndex);
+
+  let properties;
+  if (component.backendApi.isSnapshot) {
+    // Fetch properties of source
+    properties = (await app.getObjectProperties(layout.sourceObjectId)).properties;
+  } else {
+    properties = await component.backendApi.getProperties();
+  }
+
+  const originCubeDefinition = properties.qHyperCubeDef;
  const designCube = await buildDesignCube(originCubeDefinition, dimensionIndexes, app);
  const dataCube = await buildDataCube(originCubeDefinition, dimensionIndexes, app);

--- a/src/definition/metric-semaphores.js
+++ b/src/definition/metric-semaphores.js
@@ -39,6 +39,7 @@ const metricSemaphores = {
      label: 'Critic Color Fill',
      type: 'object',
      component: 'color-picker',
+      dualOutput: true,
      defaultValue: {
        index: 8,
        color: '#f93f17'
@@ -49,6 +50,7 @@ const metricSemaphores = {
      label: 'Critic Color Text',
      type: 'object',
      component: 'color-picker',
+      dualOutput: true,
      defaultValue: {
        index: 11,
        color: '#ffffff'
@@ -65,6 +67,7 @@ const metricSemaphores = {
      label: 'Medium Color Fill',
      type: 'object',
      component: 'color-picker',
+      dualOutput: true,
      defaultValue: {
        index: 9,
        color: '#ffcf02'
@@ -75,6 +78,7 @@ const metricSemaphores = {
      label: 'Medium Color Text',
      type: 'object',
      component: 'color-picker',
+      dualOutput: true,
      defaultValue: {
        index: 12,
        color: '#000000'
@@ -85,6 +89,7 @@ const metricSemaphores = {
      label: 'Success Color Fill',
      type: 'object',
      component: 'color-picker',
+      dualOutput: true,
      defaultValue: {
        index: 10,
        color: '#276e27'
@@ -95,6 +100,7 @@ const metricSemaphores = {
      label: 'Success Color Text',
      type: 'object',
      component: 'color-picker',
+      dualOutput: true,
      defaultValue: {
        index: 11,
        color: '#ffffff'
--- a/src/headers-table/column-header.jsx
+++ b/src/headers-table/column-header.jsx
@@ -57,7 +57,12 @@ ColumnHeader.propTypes = {
  }).isRequired,
  qlik: PropTypes.shape({
    backendApi: PropTypes.shape({
-      selectValues: PropTypes.func.isRequired
+      selectValues: function (props, propName) {
+        if (props.isSnapshot || typeof props[propName] === 'function') {
+          return null;
+        }
+        return new Error('Missing implementation of qlik.backendApi.selectValues.');
+      }
    }).isRequired
  }).isRequired,
  styling: PropTypes.shape({
--- a/src/headers-table/index.jsx
+++ b/src/headers-table/index.jsx
@@ -126,7 +126,12 @@ HeadersTable.propTypes = {
  general: PropTypes.shape({}).isRequired,
  qlik: PropTypes.shape({
    backendApi: PropTypes.shape({
-      selectValues: PropTypes.func.isRequired
+      selectValues: function (props, propName) {
+        if (props.isSnapshot || typeof props[propName] === 'function') {
+          return null;
+        }
+        return new Error('Missing implementation of qlik.backendApi.selectValues.');
+      }
    }).isRequired
  }).isRequired,
  styling: PropTypes.shape({
Author	SHA1	Message	Date
Tobias Åström	d3c39bea75	Merge pull request #32 from qlik-oss/tsm-color-picker-check Update metric-semaphores.js	2019-04-05 13:46:58 +02:00
Albert Backenhof	433a725f33	Merge pull request #33 from qlik-oss/snapshotFix New preview image and fixed snapshot	2019-03-20 10:28:52 +01:00
Albert Backenhof	769d5cfa3f	New preview image and fixed snapshot -SnapshotApi doesn't have a getProperties so fetching the source properties from qlik-app instead. -The snapshot still cannot be rendered in the "printing-snapshot" test page because of limitations on that page.	2019-03-19 10:38:29 +01:00
Tobias Åström	34527c3d6d	Update metric-semaphores.js We recently had a bug on the color picker when used in extensions (QLIK-94131) so I went through all extensions to check their status, this was the only one with a potential problem. The property notation should be as I changed it now (but after fixing the bug it will work anyway). However, there might be code elsewhere in the extension that mitigates the bug, so make sure this gets tested.	2019-03-12 09:04:43 +01:00