Pass string
This commit is contained in:
@@ -138,6 +138,18 @@ public class Databases {
|
||||
return new Database(connectionPool, dialect);
|
||||
}
|
||||
|
||||
public static Database createDatabase(final String username,
|
||||
final String password,
|
||||
final String jdbcConnectionString,
|
||||
final String driverClassName,
|
||||
final SQLDialect dialect,
|
||||
final String connectionProperties) {
|
||||
final BasicDataSource connectionPool =
|
||||
createBasicDataSource(username, password, jdbcConnectionString, driverClassName, connectionProperties);
|
||||
|
||||
return new Database(connectionPool, dialect);
|
||||
}
|
||||
|
||||
public static JdbcDatabase createJdbcDatabase(final String username,
|
||||
final String password,
|
||||
final String jdbcConnectionString,
|
||||
@@ -213,6 +225,22 @@ public class Databases {
|
||||
return connectionPool;
|
||||
}
|
||||
|
||||
public static BasicDataSource createBasicDataSource(final String username,
|
||||
final String password,
|
||||
final String jdbcConnectionString,
|
||||
final String driverClassName,
|
||||
final String connectionProperties) {
|
||||
final BasicDataSource connectionPool = new BasicDataSource();
|
||||
connectionPool.setDriverClassName(driverClassName);
|
||||
connectionPool.setUsername(username);
|
||||
connectionPool.setPassword(password);
|
||||
connectionPool.setInitialSize(0);
|
||||
connectionPool.setMaxTotal(5);
|
||||
connectionPool.setUrl(jdbcConnectionString);
|
||||
connectionPool.setConnectionProperties(connectionProperties);
|
||||
return connectionPool;
|
||||
}
|
||||
|
||||
public static BigQueryDatabase createBigQueryDatabase(final String projectId, final String jsonCreds) {
|
||||
return new BigQueryDatabase(projectId, jsonCreds);
|
||||
}
|
||||
|
||||
@@ -6,7 +6,6 @@ package io.airbyte.integrations.destination.redshift;
|
||||
|
||||
import com.fasterxml.jackson.databind.JsonNode;
|
||||
import com.fasterxml.jackson.databind.node.ObjectNode;
|
||||
import com.google.common.collect.ImmutableMap;
|
||||
import io.airbyte.commons.io.IOs;
|
||||
import io.airbyte.commons.json.Jsons;
|
||||
import io.airbyte.commons.string.Strings;
|
||||
@@ -142,8 +141,7 @@ public class RedshiftCopyDestinationAcceptanceTest extends DestinationAcceptance
|
||||
baseConfig.get("port").asText(),
|
||||
baseConfig.get("database").asText()),
|
||||
"com.amazon.redshift.jdbc.Driver", null,
|
||||
ImmutableMap.of("ssl", "true", "sslfactory", "com.amazon.redshift.ssl.NonValidatingFactory")
|
||||
);
|
||||
"ssl=true;sslfactory=com.amazon.redshift.ssl.NonValidatingFactory");
|
||||
}
|
||||
|
||||
@Override
|
||||
|
||||
Reference in New Issue
Block a user