chore: fix mssql build (#61017)
- the bulk connector plugin hardcodes integration tests set up today instead of inheriting the same properties from the general test set up. Remove this. - the Dest MSSQL uses a custom network to spin up test containers that is no longer required since we are no longer in Dagger. Remove this. This also simplifies things.
This commit is contained in:
@@ -16,7 +16,7 @@ data:
|
||||
type: GSM
|
||||
connectorType: destination
|
||||
definitionId: d4353156-9217-4cad-8dd7-c108fd4f74cf
|
||||
dockerImageTag: 2.2.10
|
||||
dockerImageTag: 2.2.11
|
||||
dockerRepository: airbyte/destination-mssql
|
||||
documentationUrl: https://docs.airbyte.com/integrations/destinations/mssql
|
||||
githubIssueLabel: destination-mssql
|
||||
|
||||
@@ -11,7 +11,6 @@ import io.airbyte.integrations.destination.mssql.v2.MSSQLContainerHelper.getPort
|
||||
import io.github.oshai.kotlinlogging.KotlinLogging
|
||||
import org.testcontainers.containers.MSSQLServerContainer
|
||||
import org.testcontainers.containers.MSSQLServerContainer.MS_SQL_SERVER_PORT
|
||||
import org.testcontainers.containers.Network
|
||||
|
||||
val logger = KotlinLogging.logger {}
|
||||
/**
|
||||
@@ -20,12 +19,9 @@ val logger = KotlinLogging.logger {}
|
||||
*/
|
||||
object MSSQLContainerHelper {
|
||||
|
||||
private val network = Network.newNetwork()
|
||||
|
||||
private val testContainer =
|
||||
MSSQLServerContainer("mcr.microsoft.com/mssql/server:2022-latest")
|
||||
.acceptLicense()
|
||||
.withNetwork(network)
|
||||
.withLogConsumer { e -> logger.debug { e.utf8String } }
|
||||
|
||||
fun start() {
|
||||
@@ -38,8 +34,6 @@ object MSSQLContainerHelper {
|
||||
|
||||
fun getHost(): String = testContainer.host
|
||||
|
||||
fun getNetwork(): Network = network
|
||||
|
||||
fun getPassword(): String = testContainer.password
|
||||
|
||||
fun getPort(): Int? = testContainer.getMappedPort(MS_SQL_SERVER_PORT)
|
||||
|
||||
@@ -205,11 +205,7 @@ class AirbyteBulkConnectorPlugin implements Plugin<Project> {
|
||||
environment "AIRBYTE_CONNECTOR_INTEGRATION_TEST_RUNNER", "docker"
|
||||
|
||||
jvmArgs = project.test.jvmArgs
|
||||
systemProperties = project.test.systemProperties + [
|
||||
'junit.jupiter.execution.parallel.enabled': 'true',
|
||||
'junit.jupiter.execution.parallel.config.strategy': 'fixed',
|
||||
'junit.jupiter.execution.parallel.config.fixed.parallelism': Math.max((Runtime.runtime.availableProcessors() / 2).toInteger(), 1).toString()
|
||||
]
|
||||
systemProperties = project.test.systemProperties
|
||||
maxParallelForks = project.test.maxParallelForks
|
||||
maxHeapSize = project.test.maxHeapSize
|
||||
|
||||
|
||||
@@ -158,6 +158,7 @@ See the [Getting Started: Configuration section](#configuration) of this guide f
|
||||
|
||||
| Version | Date | Pull Request | Subject |
|
||||
|:-----------|:-----------|:-----------------------------------------------------------|:----------------------------------------------------------------------------------------------------|
|
||||
| 2.2.11 | 2025-05-30 | [61017](https://github.com/airbytehq/airbyte/pull/61017) | Integration test fixes |
|
||||
| 2.2.10 | 2025-05-29 | [60897](https://github.com/airbytehq/airbyte/pull/60897) | Internal fixes |
|
||||
| 2.2.9 | 2025-05-19 | [60791](https://github.com/airbytehq/airbyte/pull/60791) | Fix bug in detecting schema change when stream has no columns |
|
||||
| 2.2.8 | 2025-05-08 | [59735](https://github.com/airbytehq/airbyte/pull/59735) | Cleanup: Remove unused code |
|
||||
|
||||
Reference in New Issue
Block a user