jprdonnelly/airbyte
1
0
Fork 0
mirror of synced 2025-12-19 18:14:56 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix(ci): treat skipped jobs as successful in Connector CI Checks Summary

Browse Source 
The evaluate-status step in connector-ci-checks-summary job only checked
for 'success' status but didn't account for 'skipped' jobs. This caused
the 'Connector CI Checks Summary' required check to fail when jobs were
legitimately skipped (e.g., when no connectors are modified or when
matrix jobs don't run).

This fix treats skipped jobs as successful, which is appropriate for
workflow-only PRs where no connectors are modified.

Fixes: airbytehq/airbyte-internal-issues#15521
Co-Authored-By: unknown <>
This commit is contained in:
Devin AI
2025-12-16 19:34:31 +00:00
parent 13bca943f4
commit d58c842cf3
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
.github/workflows/connector-ci-checks.yml vendored
View File

@@ -474,9 +474,11 @@ jobs:
- name: Evaluate Status
id: evaluate-status
run: |
if [[ "${{ needs.jvm-connectors-test.result }}" == "success" &&
"${{ needs.non-jvm-connectors-test.result }}" == "success" &&
"${{ needs.connectors-lint.result }}" == "success" ]]; then
# Treat skipped jobs as successful - this is appropriate when no connectors
# are modified or when the matrix is empty (e.g., workflow-only PRs)
if [[ ("${{ needs.jvm-connectors-test.result }}" == "success" || "${{ needs.jvm-connectors-test.result }}" == "skipped") &&
("${{ needs.non-jvm-connectors-test.result }}" == "success" || "${{ needs.non-jvm-connectors-test.result }}" == "skipped") &&
("${{ needs.connectors-lint.result }}" == "success" || "${{ needs.connectors-lint.result }}" == "skipped") ]]; then
echo "result=success" | tee -a $GITHUB_OUTPUT
else
echo "result=failure" | tee -a $GITHUB_OUTPUT