jprdonnelly/airbyte
1
0
Fork 0
mirror of synced 2026-01-07 09:05:45 -05:00
Code Issues Packages Projects Releases Wiki Activity

🐛 octavia-cli: handle array in types for generated comments (#11846)

Browse Source
This commit is contained in:
Augustin
2022-04-08 13:38:46 -07:00
committed by GitHub
parent ead3356677
commit e312aee613
2 changed files with 9 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
octavia-cli/octavia_cli/generate/renderers.py
View File

@@ -90,6 +90,8 @@ class FieldToRender:
return "REQUIRED" if self.required else "OPTIONAL"
def _get_type_comment(self) -> str:
if isinstance(self.type, list):
return ", ".join(self.type)
return self.type if self.type else None
def _get_secret_comment(self) -> str:

12
octavia-cli/unit_tests/test_generate/test_renderers.py
View File

@@ -80,12 +80,14 @@ class TestFieldToRender:
field_to_render.required = False
assert field_to_render._get_required_comment() == "OPTIONAL"
def test__get_type_comment(self):
@pytest.mark.parametrize(
"_type,expected_comment",
[("string", "string"), (["string", "null"], "string, null"), (None, None)],
)
def test__get_type_comment(self, _type, expected_comment):
field_to_render = renderers.FieldToRender("field_name", True, {"foo": "bar"})
field_to_render.type = "mytype"
assert field_to_render._get_type_comment() == "mytype"
field_to_render.type = None
assert field_to_render._get_type_comment() is None
field_to_render.type = _type
assert field_to_render._get_type_comment() == expected_comment
def test__get_secret_comment(self):
field_to_render = renderers.FieldToRender("field_name", True, {"foo": "bar"})