1
0
mirror of synced 2025-12-21 02:51:29 -05:00
Commit Graph

851 Commits

Author SHA1 Message Date
Tim Roes
e8bc3d7e03 Improve body of release PR (#16330) 2022-09-06 23:21:00 +02:00
Tim Chan
a4621f8c96 use refactored find a pat script that writes token to env (not base64 encoded) (#16321) 2022-09-06 09:30:32 -07:00
Liren Tu
59cba5082e Skip unit tests when run-tests is false (#16267) 2022-09-02 15:12:58 -07:00
Conor
ce2bcd4207 fix: run.delete() not available in pygithub (#16127) 2022-08-30 09:55:06 -05:00
Conor
6074ad5d83 feat: tools to identify and clean up unused workflows (#16019)
* feat: tools to identify and clean up unused workflows

* fix: shorten title

Co-authored-by: Topher Lubaway <asimplechris@gmail.com>

* fix: make slack token optional

* fix: review comments

* ci: remove todo's in workflow run for merge

Co-authored-by: Topher Lubaway <asimplechris@gmail.com>
2022-08-29 13:45:38 -05:00
Yevhen Sukhomud
c402264664 11815 New github action to test projects that depend on the project being changed (#15783)
* 11815 New github action to test projects that depend on the project being changed
2022-08-25 10:00:19 +07:00
Lake Mossman
377a1499cf Move 'updateNew' logic into 'update', and remove 'updateNew' (#15863)
* save

* clean up more usages and remove withRefreshedCatalog

* make webapp use correct endpoint

* add back intercept

* fix acceptance test

* fix log

* remove 'new' from test name
2022-08-23 11:36:48 -07:00
Evan Tahler
9a531bc524 Add airbyte/cron docker image to publish script (#15860)
* Add `airbyte/cron` docker image to publish script

* add publish comment
2022-08-22 15:10:17 -07:00
Evan Tahler
4774949ab0 Remove -alpha tags from Airbyte release versions (#15766)
* Remove alpha tags in autobump files

* remove more alpha tags
2022-08-22 11:06:49 -07:00
Marcos Marx
6d116871db run format (#15566) 2022-08-11 15:08:16 -03:00
Marcos Marx
820e26720e CI Credentials Validation: correct condition for non-string type and add tests (#15562)
* correct condition and tests

* add eof
2022-08-11 14:42:32 -03:00
Anne
e9afa9bef3 Error Prone PMD rules (#15010)
* Implement ErrorProne PMD rules:
AssignmentInOperand
AvoidAccessibilityAlteration
AvoidBranchingStatementAsLastInLoop
AvoidCatchingNPE
AvoidCatchingThrowable
AvoidDuplicateLiterals rule
2022-08-09 15:30:48 -07:00
Davin Chia
fd0b7699a4 Add JUnit Test Reports to build outputs. (#15271)
It's difficult today to parse all the logs from tests. Engineers waste time scrolling through the log outputs and looking for the relevant stack trace.

This PR adds an action to generate a JUnit report so devs can understand test results at a glance. This generates 3 reports for each of the main build jobs when the build completes. We leave the frontend build out since this is aggregated by cypress.

See https://github.com/airbytehq/airbyte/pull/15271/checks?check_run_id=7683783016 for an example of how this works.

Use the https://github.com/dorny/test-reporter action and configure this to look at the Jacoco test report output for top level and second level builds. Note that most of the parameters into the action don't work.

Comment out the trap commands to output logs. Though this can be useful for debugging, there is little practical use in the day-to-day, and results in extremely noisy logs.
2022-08-08 17:04:36 -07:00
Davin Chia
f9026b0dfc Remove unnecessary test logging. (#15384)
This logging makes it tough to figure out what is happening in the tests.
2022-08-05 17:20:36 -07:00
Serhii Chvaliuk
c5a98f3ecf GitHub Actions - workflow Connector Integration Tests - add retry (#14452)
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
2022-08-01 17:37:20 +03:00
Serhii Chvaliuk
8b3c6861d1 pin flake8==4.0.1 (#15155)
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
2022-08-01 15:12:49 +03:00
Yevhen Sukhomud
436de264cb 13539 Fix integration tests source-clickhouse Mac OS (#14701)
* 13539 Fix integration tests source-clickhouse Mac OS

* 13539 Updated clickhouse jdbc driver

* 13539 Updated destination-clickhouse-strict-encrypt

* 13539 Updated SSL configuration and tests for clickhouse-destination

* 13539 Updated SSL for source-clickhouse-strict-encrypt

* 13539 Resolved host by ip

* 13539 Fixed code formatting

* 13539 Bump up source-clickhouse-strict-encrypt version

* auto-bump connector version [ci skip]

* auto-bump connector version [ci skip]

Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
2022-07-26 13:08:44 +07:00
Davin Chia
cd5d8c2cbd Make sure Airbyte release process uses JDK 19. (#14993)
Follow up to #14971 . Make sure to update this for the OSS publishing process as well.

Also update all the dockerfiles.

Connectors are not touched.
2022-07-25 08:53:41 -07:00
Anne
555efd5360 Best Practices PMD rules (#14904)
* Implement BestPractices PMD rules:
- LiteralsFirstInComparisons
- PreserveStackTrace
- SystemPrintln rule
- switch statement should have default
- Use isEmpty rule
- UseVarargs rule
2022-07-22 11:00:36 -07:00
Anne
76f9fbaa54 Apply more Best Practices PMD rules (#14772)
* implement PMD rules: 
* AbstractClassWithoutAbstractMethod
* ArrayIsStoredDirectly
* AvoidPrintStackTrace, AvoidReassigningLoopVariables, AvoidReassigningParameters, AvoidUsingHardCodedIP and CheckResultSet
* DoubleBraceInitialization
* MissingOverride
* ForLoopCanBeForeach
*JUnitTest rules
2022-07-20 14:28:47 -07:00
Peter Hu
b4d2348fcf sleep 1 second every connector lookup (#14808)
* sleep 1 second every connector lookup

to prevent running into docker hub API rate limits

* comment on why we sleep

Co-authored-by: Davin Chia <davinchia@gmail.com>
2022-07-18 12:12:20 -07:00
Evan Tahler
b0f559dfca Google Sheets Destination flushes on every state message and flush when buffer gets too large (#14751)
* Google Sheets Destination flushes on every state message

* add PR number to readme

* suggestions

* reverted clean change

* added memory allocation check for records_buffer(stream)

* Update airbyte-integrations/connectors/destination-google-sheets/destination_google_sheets/writer.py

Co-authored-by: Sherif A. Nada <snadalive@gmail.com>

* auto-bump connector version

Co-authored-by: Oleksandr Bazarnov <oleksandr.bazarnov@globallogic.com>
Co-authored-by: Sherif A. Nada <snadalive@gmail.com>
Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
2022-07-15 16:15:39 -07:00
Lake Mossman
6005a9a20e CDC partial reset acceptance test (#14551)
* set per stream feature flag to true for testing

* add a second table to cdc acceptance tests

* add partial reset test

* format

* add partial reset cdc tests

* test incremental after partial reset

* remove dev image from acceptance test

* fix flag and add comment

* Revert "set per stream feature flag to true for testing"

This reverts commit 164d7da05990268b09e315eb88ff297d3a9f52f4.

* set USE_STREAM_CAPABLE_STATE flag to true in acceptance test script

* call new update endpoint

* use methods in test harness instead

* remove comment

* format

* fix state check in basic acceptance test

* use test info for test name logging
2022-07-15 16:03:15 -07:00
Anne
e698710118 Apply Best Practices PMD rules (#14753)
* Apply Unused* Best Practices PMD rules
2022-07-15 15:01:04 -07:00
dougpm
bfc2646f1a cdk: Add a schema_generator tool (#13518) 2022-07-13 19:00:38 +02:00
Anne
767992e591 Remove withRefreshedCatalog param from updateConnection endpoint (#14477)
* New webBackendConnectionUpdate endpoint with withRefreshedCatalog param removed
2022-07-12 14:00:33 -07:00
Lake Mossman
e1c2ca234e remove CONTAINER_ORCHESTRATOR env var from acceptance tests as it is unnecessary (#14541) 2022-07-08 11:38:55 -07:00
Lake Mossman
d2ea57499d Run container orchestrator acceptance tests (#13699)
* Add CONTAINER_ORCHESTRATOR=true flag to kube acceptance tests

* Add CONTAINER_ORCHESTRATOR=true flag to GKE acceptance tests too

* fix downtime test

* fix the other orchestrator tests

* move container orchestrator acceptance tests to their own class
2022-07-08 09:27:01 -07:00
Jonathan Pearlin
8fda5879ae Use Debezium Postgres image for CDC tests (#14318)
* Use Debezium Postgres image for CDC tests

* Formatting
2022-07-05 12:47:23 -04:00
Topher Lubaway
2a28509463 Fixes broken links so we can deploy again (#14075)
also adds better error message for when this happens to others
2022-06-23 09:02:01 -05:00
Augustin
e8146e5ec2 Normalization: Upgrade MySQL to dbt 1.0.0 (#11470) 2022-06-15 15:05:49 -07:00
LiRen Tu
973f0b1165 Make connector adaptable based on deployment mode (#13522)
* Add deployment mode to env shared with jobs

* Add adaptive runners

* Migrate postgres source to use adaptive runner

* Add an array of specs in docker image spec definition

* Add copyright

* Parse docker image spec with specs list

* Update spec yaml files

* Pass in DEPLOYMENT_MODE to docker compose file

* Revert "Parse docker image spec with specs list"

This reverts commit 8fe41dd3b7.

* Revert changes in docker image spec

* Read cloud specific spec files based on deployment mode

* Revert "Update spec yaml files"

This reverts commit 059f326432.

* Publish cloud spec file if necessary

* Fix upload script

* Move test files

* Update docker compose file

* Format code

* Add comment about spec filename

* Add unit tests

* Remove redundant jdbc acceptance test

When running `PostgresStrictEncryptJdbcSourceAcceptanceTest`, the `discover` method tests always fail because there are unexpected columns in the catalog:
- `wakeup_at`
- `last_visited_at`
- `last_comment_at`

These columns only exist in `PostgresJdbcSourceAcceptanceTest`. And this failure cannot be reproduced locally.

The hypothesis is that when the JDBC unit tests are run on CI, they are run in parallel, and the same testcontainer is used for both tests. That's why the strict encrypt test can discover columns from the oridinary unit test.

Given that the JDBC strict encrypt test is basically redundant, it is removed.
2022-06-15 08:23:54 -07:00
Topher Lubaway
5e1f968751 Adds zombie removal tool (#13718)
* Adds zombie removal tool

* Corrects endpoint adds comments

* Adds API links

* Changes search logic, fixes escape character

* Corrects help text
2022-06-13 13:28:32 -05:00
Evan Tahler
6c8cae2e7b Use buildx docker-container driver for publishing normalization containers (#13693)
* explicitly use buildx for connector publish

* ... and use it

* use docker-container driver

* use `driver docker-container` only for normalization

* Update tools/integrations/manage.sh

Co-authored-by: Edward Gao <edward.gao@airbyte.io>

Co-authored-by: Edward Gao <edward.gao@airbyte.io>
2022-06-10 12:24:47 -07:00
Lake Mossman
80b86d322a Update Releasing a new version section of readme (#13671) 2022-06-10 11:20:16 -07:00
Denis Davydov
20bd923c63 fix source-acceptance-test build (#13485) 2022-06-10 10:11:49 +03:00
lmossman
2610ffcefc rename automated release creation action to be less similar to the existing Release OSS Airbyte action 2022-06-08 09:23:00 -07:00
Lake Mossman
527e391c16 add Release Airbyte action and update version bump PR description (#13584) 2022-06-08 09:09:28 -07:00
Sherif Nada
b763bdf4ab Revert "add github workflows for publishing ERDs"
This reverts commit c7a23c680b.
2022-06-08 03:32:56 -07:00
Sherif Nada
c7a23c680b add github workflows for publishing ERDs 2022-06-07 22:42:13 -07:00
Davin Chia
40cb78e5c7 Fix the acceptance tests. (#13501)
We've seen errors like:
- https://github.com/airbytehq/airbyte/runs/6758654948?check_suite_focus=true#step:11:52833 - from trying to list bootloader logs. This is no longer possible since we remove the bootloader pod.
- https://github.com/airbytehq/airbyte/runs/6746572522?check_suite_focus=true#step:11:52164 - errors while tearing down the test.

I will do a follow up PR to refactor tests to hopefully speed things up:
- split Kube from normal tests.
- explore not recreating the db on each time.

In the mean time, this should stabilise the tests and get us back to green build.
2022-06-07 02:38:19 +08:00
Lake Mossman
da22f0320a remove scheduler/app from publish_docker.sh (#13507) 2022-06-06 11:34:08 -07:00
Lake Mossman
73034c64da Sweep old scheduler code (#13400)
* sweep all scheduler application code and new-scheduler conditional logic

* remove airbyte-scheduler from deployments and docs

* format

* remove 'v2' from github actions

* add back scheduler in delete deployment command

* remove scheduler parameters from helm chart values

* add back job cleaner + test and add comment

* remove now-unused env vars from code and docs

* format

* remove feature flags from web backend connection handler as it is no longer needed

* remove feature flags from config api as it is now longer needed

* remove feature flags input from config api test

* format + shorter url

* remove scheduler parameters from helm chart readme
2022-06-06 10:49:17 -07:00
Davin Chia
adc590e385 Update publishing scripts after renaming dirs. (#13486)
* Update dockerfile to match.

* Update publishing script to match.
2022-06-06 18:11:02 +08:00
Davin Chia
eb99f47746 Fat Jar: Rename Dir Part 2 (#13478)
## What
Part 2 of https://github.com/airbytehq/airbyte/pull/13122.

Follow up to #13476 .

Explanation for what is happening:

Identically named subprojects have the following issues:

* publishing as is leads to classpath confusion when the jars with the same names are placed in the Java distribution. This leads to NoClassDefFound errors on runtime.
* deconflicting the jar names without changing directory names leads to dependency errors as the OSS jar pom files are generated using project dependencies (suggesting a dependency a sibling subproject in the same repo) that use subprojects group and name as a reference. This means the generated jars look for Jars that do not exists (as their names have been changed) and cannot compile.
* the workaround to changing a subproject's name involves resetting the subproject's name in the settings.gradle and depending on the new name in each build.gradle. This increases configuration burden and decreases the ease of reading, since one will have to check the settings.gradle to know what the right subproject name is. See https://github.com/gradle/gradle/issues/847 for more info.
* given that Gradle itself doesn't have support for identically named subprojects (see the linked issue), the simplest solution is to not allow duplicated directories. I've only renamed conflicting directories here to keep things simple. I will create a follow up issues to enforce non-identical subproject names in our builds.

* Rename airbyte-config:models to airbyte-config:config-models.
* Rename airbyte-config:persistence to airbyte-config:config-persistence.
2022-06-06 02:21:54 +08:00
Brian Leonard
3125d92c82 handle null mask value (#13382)
* Don’t show mask items locally

* Handle null mask value
2022-06-01 10:36:05 -07:00
Brian Leonard
9b525b5959 Mask certain keys from GitHub output (#13242)
* Mask certain keys from GitHub output

* add more mask keys

* Read the cwd

* also handle json strings as values

* Test value

* Log at beginning of line

* Testing logs

* Use real mask values

* Handle multiple lines
2022-05-31 15:25:13 -07:00
Evan Tahler
d1ff8dd8b4 [Github Actions] Rename docker secrets and parameterize docker user (#13297)
* Rename docker secrets and parameterize docker user

* Apply suggestions from code review

Co-authored-by: Pedro S. Lopez <pedroslopez@me.com>

Co-authored-by: Pedro S. Lopez <pedroslopez@me.com>
2022-05-27 18:48:26 -07:00
noahkawasaki-airbyte
0fd866c590 Toggle off and on set -x when DOCKER_TOKEN is used (#13293)
* Toggle off and on set -x when DOCKER_TOKEN is used
2022-05-27 14:39:59 -07:00
Evan Tahler
e3cb566f79 Bump faker version to test M1 Connector builds (#13235)
* Bump faker version to test M1 Connector builds

* add PR link to changelog

* Remove birhtday, it  doesn't obey seed

* bump readme

* more birthday to remove

* remove image specificity in publish-command

* Set AMI for testing.

* test with including buildx emulators

* auto-bump connector version

* add TODO comment

Co-authored-by: Davin Chia <davinchia@gmail.com>
Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
2022-05-27 10:36:05 -07:00