1
0
mirror of synced 2026-01-20 12:07:14 -05:00
Files
airbyte/airbyte-webapp/src/views/Connector
Vladimir fa388503d8 🪟 🔧 Refactored <ServiceForm /> (#17597)
* remove styled components from FormRoot

* refactored WarningMessage component

* refactored TestingConnectionSpinner component

* fixes after merge

* replace styled-components with css modules in ConnectorServiceTypeControl components

* extend ModalBody to support style overwrite

* refactor RequestConnectorModal using new headlessUi Modal component

* - refactor FrequentlyUsedDestinations component
- update tests
- updates storybook

* - refactor StartWithDestination component
- update tests
- updates storybook

* renamed FrequentlyUsedDestinationsCard component

* move ConnectorForm to RequestConnectorModal

* remove spinner from FrequentlyUsedDestinations component

* - refactor ConnectorServiceTypeControl component
- move utility functions outside of component
- move analytics tracking functions to separate component hook

* - refactor ServiceForm component
- update tests - remove test with checking serviceType

* memoize selectProps in ConnectorServiceTypeControl

* simplify getting the namespace type

* show FormRoot conditionally - if selectedConnectorDefinitionSpecification is provided

* - refactor ConnectorCard component

* refactor DestinationForm component

* remove styled components from FormRoot

* refactored WarningMessage component

* refactored TestingConnectionSpinner component

* fixes after merge

* replace styled-components with css modules in ConnectorServiceTypeControl components

* extend ModalBody to support style overwrite

* refactor RequestConnectorModal using new headlessUi Modal component

* - refactor FrequentlyUsedDestinations component
- update tests
- updates storybook

* - refactor StartWithDestination component
- update tests
- updates storybook

* renamed FrequentlyUsedDestinationsCard component

* move ConnectorForm to RequestConnectorModal

* remove spinner from FrequentlyUsedDestinations component

* - refactor ConnectorServiceTypeControl component
- move utility functions outside of component
- move analytics tracking functions to separate component hook

* - refactor ServiceForm component
- update tests - remove test with checking serviceType

* memoize selectProps in ConnectorServiceTypeControl

* simplify getting the namespace type

* show FormRoot conditionally - if selectedConnectorDefinitionSpecification is provided

* - refactor ConnectorCard component

* refactor DestinationForm component

* fixes after rebase

* fixed optional onDestinationSelect callbacks

* add analyticsTrackFunctions to FrequentlyUsedDestinations component

* update tests

* fix fullWidth Card issue

* fix async/await issue

* refactor analytics - Source/Destination connector selected

* fix onboarding page - octavia's line

* wrap analytics track functions with useCallback

* move analytics track functions to separate useAnalyticsTrackFunctions file

* rename filename to match the contained component name

* extend SectionContainer - do not add margin-bottom if container doesn't have any childs

* disable ConnectorServiceTypeControl is form is submitting

* fix onbording create source/destination steps

* hide form via css if selectedConnector is not present

* remove comments

* fix e2e tests

* fix test

* bring back the old design (don't split form on separate cards)

* Update airbyte-webapp/src/pages/DestinationPage/pages/CreateDestinationPage/components/DestinationForm.tsx

Co-authored-by: Edmundo Ruiz Ghanem <168664+edmundito@users.noreply.github.com>

* rename "additionalDropdownComponent" to "additionalSelectorComponent"

* rename "formType" arg to "connectorType" in analytics track functions

* fix components import

* updated test snapshot

* update RequestConnectorModal: move Formik inside the ModalBody

* fix PR comments: rename utilityFunctions.tsx to utils.tsx

* move StartWithDestination component to DestinationForm

* remove hiding empty form functionality since we don't split it on multiple cards

* update comment regarding the serviceType prop

Co-authored-by: Edmundo Ruiz Ghanem <168664+edmundito@users.noreply.github.com>
2022-10-17 15:21:13 +03:00
..
2022-10-17 15:21:13 +03:00
2022-10-17 15:21:13 +03:00