jprdonnelly/congress-legislators
1
0
Fork 0
mirror of https://github.com/unitedstates/congress-legislators.git synced 2025-12-19 18:05:51 -05:00
Code Issues Packages Projects Releases Wiki Activity

in tests/validate.py check that the 'bio' mapping has all of the fields present

Browse Source
This commit is contained in:
Joshua Tauberer
2018-12-16 17:15:41 -05:00
parent 9101feaae3
commit f11cb2c27d
1 changed files with 9 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
test/validate.py
View File

@@ -98,7 +98,7 @@ def check_legislators_file(fn, seen_ids, current=None, current_mocs=None):
if "bio" not in legislator:
error(repr(legislator) + " is missing 'bio'.")
else:
check_bio(legislator["bio"])
check_bio(legislator["bio"], current)
# Check the terms.
if "terms" not in legislator:
@@ -188,12 +188,18 @@ def check_name(name, is_other_names=False):
if isinstance(name.get("first"), str) and len(name["first"]) == 2 and name["first"].endswith(".") and not name.get("middle"):
error(rtyaml.dump(name) + " is missing a middle name to go with its first initial.")
def check_bio(bio):
def check_bio(bio, is_current_legislator):
for key, value in bio.items():
if key not in (bio_keys | old_allowed_other_bio_keys):
error("%s is not a valid key in bio." % key)
elif not isinstance(value, str):
error(rtyaml.dump({ key: value }) + " has an invalid data type.")
if is_current_legislator:
# These keys are required only for current legislators.
# We don't always have the information for historical members of Congress or presidents.
for key in bio_keys:
if key not in bio:
error("Missing bio->{}.".format(key))
def check_term(term, prev_term, current=None, current_mocs=None):
# Check type.
@@ -315,7 +321,7 @@ def check_executive_file(fn):
if "bio" not in person:
error(repr(person) + " is missing 'bio'.")
else:
check_bio(person["bio"])
check_bio(person["bio"], False)
# Check the terms.
if "terms" not in person: