Make sure all image asset lookups are case insensitive (#43107)
Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>
This commit is contained in:
Peter Bengtsson
|
Before Width: | Height: | Size: 45 KiB After Width: | Height: | Size: 45 KiB |
|
Before Width: | Height: | Size: 19 KiB After Width: | Height: | Size: 19 KiB |
|
Before Width: | Height: | Size: 37 KiB After Width: | Height: | Size: 37 KiB |
|
Before Width: | Height: | Size: 46 KiB After Width: | Height: | Size: 46 KiB |
|
Before Width: | Height: | Size: 47 KiB After Width: | Height: | Size: 47 KiB |
|
Before Width: | Height: | Size: 100 KiB After Width: | Height: | Size: 100 KiB |
|
Before Width: | Height: | Size: 40 KiB After Width: | Height: | Size: 40 KiB |
@@ -124,7 +124,7 @@ You can download the {% data variables.product.prodname_advanced_security %} lic
|
||||
{%- elsif ghes > 3.8 %}
|
||||
1. Under "{% data variables.product.prodname_GH_advanced_security %}," click {% octicon "download" aria-hidden="true" %} **CSV report** in the header of the "Committers" table.
|
||||
|
||||
|
||||
|
||||
|
||||
{%- else %}
|
||||
1. Under "{% data variables.product.prodname_GH_advanced_security %}," {% octicon "download" aria-label="The download icon" %} in the header of the "Committers" table.
|
||||
|
||||
@@ -50,7 +50,7 @@ You can configure notification settings for yourself or your organization from t
|
||||
|
||||
{% ifversion update-notification-settings-22 %}
|
||||
{% endif %}{% ifversion ghes > 3.7 or ghae > 3.7 %}
|
||||
{% endif %}
|
||||
{% endif %}
|
||||
|
||||
{% note %}
|
||||
|
||||
|
||||
@@ -235,6 +235,6 @@ You can view all open alerts, and you can reopen alerts that have been previousl
|
||||
When a member of your organization {% ifversion not fpt %}or enterprise {% endif %}performs an action related to {% data variables.product.prodname_dependabot_alerts %}, you can review the actions in the audit log. For more information about accessing the log, see "[AUTOTITLE](/organizations/keeping-your-organization-secure/managing-security-settings-for-your-organization/reviewing-the-audit-log-for-your-organization#accessing-the-audit-log){% ifversion not fpt %}" and "[AUTOTITLE](/admin/monitoring-activity-in-your-enterprise/reviewing-audit-logs-for-your-enterprise/accessing-the-audit-log-for-your-enterprise)."{% else %}."{% endif %}
|
||||
{% ifversion dependabot-alerts-audit-log %}
|
||||
|
||||
{% endif %}
|
||||
{% endif %}
|
||||
|
||||
Events in your audit log for {% data variables.product.prodname_dependabot_alerts %} include details such as who performed the action, what the action was, and when the action was performed. {% ifversion dependabot-alerts-audit-log %}The event also includes a link to the alert itself. When a member of your organization dismisses an alert, the event displays the dismissal reason and comment.{% endif %} For information on the {% data variables.product.prodname_dependabot_alerts %} actions, see the `repository_vulnerability_alert` category in "[AUTOTITLE](/organizations/keeping-your-organization-secure/managing-security-settings-for-your-organization/audit-log-events-for-your-organization#repository_vulnerability_alert){% ifversion not fpt %}" and "[AUTOTITLE](/admin/monitoring-activity-in-your-enterprise/reviewing-audit-logs-for-your-enterprise/audit-log-events-for-your-enterprise#repository_vulnerability_alert)."{% else %}."{% endif %}
|
||||
|
||||
@@ -49,7 +49,7 @@ You will need to create a new personal account and then use this account to crea
|
||||
{% ifversion ghec %}
|
||||
1. Click **Configure SSO** and authorize the token for use with SAML single sign-on (SSO), so that it can access repositories that are owned by organizations with SSO enabled. For more information, see "[AUTOTITLE](/authentication/authenticating-with-saml-single-sign-on/authorizing-a-personal-access-token-for-use-with-saml-single-sign-on)."
|
||||
|
||||
|
||||
|
||||
|
||||
{% endif %}
|
||||
1. Copy the token string. You will assign this to a {% data variables.product.prodname_codespaces %} repository secret.
|
||||
|
||||
@@ -337,7 +337,7 @@ Below are translations of this document into other languages. In the event of an
|
||||
|
||||
### French
|
||||
|
||||
Cliquez ici pour obtenir la version française: [Déclaration de confidentialité de GitHub (PDF)](/assets/images/help/site-policy/github-privacy-statement(07.22.20)(FR).pdf)
|
||||
Cliquez ici pour obtenir la version française: [Déclaration de confidentialité de GitHub (PDF)](/assets/images/help/site-policy/github-privacy-statement(07.22.20)(fr).pdf)
|
||||
|
||||
### Other translations
|
||||
|
||||
|
||||
@@ -6,8 +6,8 @@
|
||||
|
||||
To see the costs for {% data variables.product.prodname_github_codespaces %} compute usage and storage, filter the report to show only rows that mention "Codespaces" in the `Product` column.
|
||||
|
||||
|
||||
|
||||
|
||||
To see only the costs for creating, updating and storing prebuilds, filter the report to show only rows that mention "Create Codespaces Prebuilds" in the `Actions Workflow` column.
|
||||
|
||||
|
||||
|
||||
|
||||
@@ -12,6 +12,19 @@ const regex = /\/cb-\d+\//
|
||||
|
||||
export default function assetPreprocessing(req, res, next) {
|
||||
if (req.path.startsWith('/assets/')) {
|
||||
// We didn't use to have a rule about all image assets must be
|
||||
// lower case. So we've exposed things like:
|
||||
// <img src="/assets/images/Foobar.png"> which means they could
|
||||
// get a 404 if the file is actually named `foobar.png`.
|
||||
if (req.url !== req.url.toLowerCase()) {
|
||||
// The reason for doing a redirect instead rewriting the
|
||||
// `req.url` attribute is that we don't want encourage this.
|
||||
// By forcing this to be a redirect, it means we only serve
|
||||
// 1 single file. All other requests will be redirects.
|
||||
// Otherwise someone might trigger too much bypassing of the CDN.
|
||||
return res.redirect(req.url.toLowerCase())
|
||||
}
|
||||
|
||||
// We're only confident enough to set the *manual* surrogate key if the
|
||||
// asset contains the cache-busting piece.
|
||||
if (regex.test(req.url)) {
|
||||
|
||||
@@ -57,4 +57,24 @@ describe('static assets', () => {
|
||||
expect(res.headers['content-type']).toContain('text/plain')
|
||||
checkCachingHeaders(res, true, 60)
|
||||
})
|
||||
it("should redirect if the URLisn't all lowercase", async () => {
|
||||
// Directory
|
||||
{
|
||||
const res = await get('/assets/images/SITE/logo.png')
|
||||
expect(res.statusCode).toBe(302)
|
||||
expect(res.headers.location).toBe('/assets/images/site/logo.png')
|
||||
}
|
||||
// File name
|
||||
{
|
||||
const res = await get('/assets/images/site/LoGo.png')
|
||||
expect(res.statusCode).toBe(302)
|
||||
expect(res.headers.location).toBe('/assets/images/site/logo.png')
|
||||
}
|
||||
// File extension
|
||||
{
|
||||
const res = await get('/assets/images/site/logo.PNG')
|
||||
expect(res.statusCode).toBe(302)
|
||||
expect(res.headers.location).toBe('/assets/images/site/logo.png')
|
||||
}
|
||||
})
|
||||
})
|
||||
|
||||
Reference in New Issue
Block a user