1
0
mirror of synced 2025-12-19 18:10:59 -05:00

Remove trailing mentions of GHAE in code (#49429)

This commit is contained in:
Peter Bengtsson
2024-02-28 12:41:51 -05:00
committed by GitHub
parent 15da689496
commit 46e8acf008
4 changed files with 3 additions and 13 deletions

View File

@@ -14,9 +14,6 @@ delete featureVersions.properties.versions.properties.feature
// Call it invalid if any properties other than version properties are found.
featureVersions.additionalProperties = false
// TODO - UNCOMMENT THE FOLLOWING LINE WHEN GHAE IS UPDATED WITH SEMVER VERSIONING
// featureVersions.properties.versions.additionalProperties = false
// avoid ajv strict warning
featureVersions.type = 'object'

View File

@@ -33,12 +33,6 @@ export type ReleaseNotePatch = {
sections: Record<string, Array<ReleaseNoteSection>>
}
export type GHAEReleaseNotesContextT = {
releaseNotes: Array<ReleaseNotePatch>
releases: Array<{ version: string; patches: Array<ReleaseNotePatch> }>
currentVersion: CurrentVersion
}
export type GHESReleaseNotesContextT = {
latestPatch: string
latestRelease: string

View File

@@ -8,7 +8,6 @@ export default async function ghesReleaseNotesContext(req, res, next) {
const [requestedPlan, requestedRelease] = req.context.currentVersion.split('@')
if (requestedPlan !== 'enterprise-server') return next()
// (This applies to ghae release notes too)
// We deliberately force the language to be English for now.
// The underlying reason is that the content (in data/release-notes/**/*.yml)
// is Markdown that does NOT use variables controlled by English-only

View File

@@ -107,7 +107,7 @@ async function main(owner, repo, baseSHA, headSHA) {
try {
// the try/catch is needed because getApplicableVersions() returns either [] or throws an error when it can't parse the versions frontmatter
// try/catch can be removed if docs-engineering#1821 is resolved
// i.e. for feature based versioning, like ghae: 'issue-6337'
// i.e. for feature based versioning, like ghec: 'issue-6337'
const fileVersions = getApplicableVersions(data.versions)
for (const plan in allVersionShortnames) {
@@ -120,7 +120,7 @@ async function main(owner, repo, baseSHA, headSHA) {
)
if (versions.length === 1) {
// for fpt, ghec, and ghae
// for fpt and ghec
if (versions.toString() === nonEnterpriseDefaultVersion) {
// omit version from fpt url
@@ -128,7 +128,7 @@ async function main(owner, repo, baseSHA, headSHA) {
previewCell += `[${plan}](${APP_URL}/${fileUrl})<br>`
prodCell += `[${plan}](${PROD_URL}/${fileUrl})<br>`
} else {
// for non-versioned releases (ghae, ghec) use full url
// for non-versioned releases (ghec) use full url
previewCell += `[${plan}](${APP_URL}/${versions}/${fileUrl})<br>`
prodCell += `[${plan}](${PROD_URL}/${versions}/${fileUrl})<br>`