Merge branch 'main' into fix-oidc-indentation-issues

.github/actions-scripts/enterprise-server-issue-templates/release-issue.md

@@ -32,20 +32,213 @@ If you aren't comfortable going through the steps alone, sync up with a docs eng
   ```
 - [ ] Create a placeholder release notes file called `data/release-notes/<PRODUCT>/<RELEASE NUMBER>/PLACEHOLDER.yml`. For example `data/release-notes/enterprise-server/3-1/PLACEHOLDER.yml`. Add the following placeholder content to the file:
 
-  ```
-  date: '2021-05-04'
-  release_candidate: true
-  deprecated: false
-  intro: PLACEHOLDER
-  sections:
-    bugs:
-      - PLACEHOLDER
-    known_issues:
-      - PLACEHOLDER
-  ```
-
   **Note:** All of the content in this file will be updated when the release notes are created in the megabranch including the filename `PLACEHOLDER.yml`. You can update the date or leave it as-is and wait to update it when the release notes are finalized.
 
+  <details><summary>Click to view placeholder...</summary>
+
+  ```yaml
+  date: '2099-12-31'
+  release_candidate: true
+  deprecated: false
+  intro: |
+    {% note %}
+
+    **Note:** If {% data variables.location.product_location %} is running a release candidate build, you can’t upgrade with a hotpatch. We recommend that you only run release candidates in a test environment.
+
+    {% endnote %}
+
+    For upgrade instructions, see "[Upgrading {% data variables.product.prodname_ghe_server %}](/admin/enterprise-management/updating-the-virtual-machine-and-physical-resources/upgrading-github-enterprise-server)."
+  sections:
+    # Remove section heading if the section contains no notes.
+
+    features:
+      # Remove a sub-section heading if the heading contains no notes. If sections
+      # that regularly recur are missing, add placeholders to this template.
+
+      - heading: Instance administration
+        notes:
+          # LINK TO RELEASE ISSUE
+          - |
+            ...
+
+      - heading: Instance services
+        notes:
+          # LINK TO RELEASE ISSUE
+          - |
+            ...
+
+      - heading: Identity and access management
+        notes:
+          # LINK TO RELEASE ISSUE
+          - |
+            ...
+
+      - heading: Authentication
+        notes:
+          # LINK TO RELEASE ISSUE
+          - |
+            ...
+
+      - heading: Migrations
+        notes:
+          # LINK TO RELEASE ISSUE
+          - |
+            ...
+
+      - heading: Policies
+        notes:
+          # LINK TO RELEASE ISSUE
+          - |
+            ...
+
+      - heading: Audit logs
+        notes:
+          # LINK TO RELEASE ISSUE
+          - |
+            ...
+
+      - heading: GitHub Connect
+        notes:
+          # LINK TO RELEASE ISSUE
+          - |
+            ...
+
+      - heading: GitHub Advanced Security
+        notes:
+          # LINK TO RELEASE ISSUE
+          - |
+            ...
+
+      - heading: Dependabot
+        notes:
+          # LINK TO RELEASE ISSUE
+          - |
+            ...
+
+      - heading: Code security
+        notes:
+          # LINK TO RELEASE ISSUE
+          - |
+            ...
+
+      - heading: GitHub Actions
+        notes:
+          # LINK TO RELEASE ISSUE
+          - |
+            ...
+
+      - heading: GitHub Packages
+        notes:
+          # LINK TO RELEASE ISSUE
+          - |
+            ...
+
+      - heading: GitHub Pages
+        notes:
+          # LINK TO RELEASE ISSUE
+          - |
+            ...
+
+      - heading: Community experience
+        notes:
+          # LINK TO RELEASE ISSUE
+          - |
+            ...
+
+      - heading: Organizations
+        notes:
+          # LINK TO RELEASE ISSUE
+          - |
+            ...
+
+      - heading: Repositories
+        notes:
+          # LINK TO RELEASE ISSUE
+          - |
+            ...
+
+      - heading: Issues
+        notes:
+          # LINK TO RELEASE ISSUE
+          - |
+            ...
+
+      - heading: Projects
+        notes:
+          # LINK TO RELEASE ISSUE
+          - |
+            ...
+
+      - heading: GitHub Discussions
+        notes:
+          # LINK TO RELEASE ISSUE
+          - |
+            ...
+
+      - heading: Commits
+        notes:
+          # LINK TO RELEASE ISSUE
+          - |
+            ...
+
+      - heading: Pull requests
+        notes:
+          # LINK TO RELEASE ISSUE
+          - |
+            ...
+
+      - heading: Releases
+        notes:
+          # LINK TO RELEASE ISSUE
+          - |
+            ...
+
+      - heading: Gist
+        notes:
+          # LINK TO RELEASES ISSUE
+          - |
+            ...
+
+      - heading: Markdown
+        notes:
+          # LINK TO RELEASE ISSUE
+          - |
+            ...
+
+      - heading: Accessibility
+        notes:
+          # LINK TO RELEASE ISSUE
+          - |
+            ...
+
+      - heading: GitHub Mobile
+        notes:
+          # LINK TO RELEASE ISSUE
+          - |
+            ...
+
+      - heading: Integrations and extensions
+        notes:
+          # LINK TO RELEASE ISSUE
+          - |
+            ...
+
+    changes:
+      # LINK TO RELEASE ISSUE
+      - |
+        ...
+
+    known_issues:
+      # INCLUDE NOTES FOR RELEASE FROM "GHES Release Note Tracking" PROJECT'S "Known Issues" TAB
+      - |
+        ...
+
+    deprecations:
+      # LINK TO RELEASE ISSUE
+      - |
+        ...
+  ```
+  </details>
 - [ ] If this is a release candidate release, add a Release Candidate banner:
 
   ```

.github/workflows/azure-preview-env-deploy.yml

@@ -71,7 +71,7 @@ jobs:
 
     steps:
       - name: 'Az CLI login'
-        uses: azure/login@1f63701bf3e6892515f1b7ce2d2bf1708b46beaf
+        uses: azure/login@92a5484dfaf04ca78a94597f4f19fea633851fa2 # pin @v1.4.6
         with:
           creds: ${{ secrets.NONPROD_AZURE_CREDENTIALS }}
 

.github/workflows/azure-preview-env-destroy.yml

@@ -35,7 +35,7 @@ jobs:
 
     steps:
       - name: 'Az CLI login'
-        uses: azure/login@1f63701bf3e6892515f1b7ce2d2bf1708b46beaf
+        uses: azure/login@92a5484dfaf04ca78a94597f4f19fea633851fa2 # pin @v1.4.6
         with:
           creds: ${{ secrets.NONPROD_AZURE_CREDENTIALS }}
 

.github/workflows/azure-prod-build-deploy.yml

@@ -34,7 +34,7 @@ jobs:
 
     steps:
       - name: 'Az CLI login'
-        uses: azure/login@1f63701bf3e6892515f1b7ce2d2bf1708b46beaf
+        uses: azure/login@92a5484dfaf04ca78a94597f4f19fea633851fa2 # pin @v1.4.6
         with:
           creds: ${{ secrets.PROD_AZURE_CREDENTIALS }}
 

.github/workflows/azure-staging-build-deploy.yml

@@ -45,7 +45,7 @@ jobs:
 
     steps:
       - name: 'Az CLI login'
-        uses: azure/login@1f63701bf3e6892515f1b7ce2d2bf1708b46beaf
+        uses: azure/login@92a5484dfaf04ca78a94597f4f19fea633851fa2 # pin @v1.4.6
         with:
           creds: ${{ secrets.PROD_AZURE_CREDENTIALS }}
 

.github/workflows/check-broken-links-github-github.yml

@@ -57,6 +57,7 @@ jobs:
         env:
           NODE_ENV: production
           PORT: 4000
+          ENABLED_LANGUAGES: en
         run: |
 
           node server.js &
@@ -65,22 +66,18 @@ jobs:
 
       - name: Run broken github/github link check
         run: |
-          script/check-github-github-links.js > broken_github_github_links.md
+          script/check-github-github-links.js broken_github_github_links.md
 
-      # check-github-github-links.js returns 0 if no links are broken, and 1 if any links
-      # are broken. When an Actions step's exit code is 1, the action run's job status
-      # is failure and the run ends. The following steps create an issue for the
-      # broken link report only if any links are broken, so `if: ${{ failure() }}`
-      # ensures the steps run despite the previous step's failure of the job.
-      #
-      # https://docs.github.com/actions/reference/context-and-expression-syntax-for-github-actions#job-status-check-functions
-
-      - if: ${{ failure() && env.FREEZE != 'true' }}
-        name: Get title for issue
+      - name: Get title for issue
+        # If the file 'broken_github_github_links.md' got created,
+        # the hash of it will not be an empty string. That means if found
+        # broken links, we want to create an issue.
+        if: ${{ hashFiles('broken_github_github_links.md') != '' && env.FREEZE != 'true' }}
         id: check
         run: echo "title=$(head -1 broken_github_github_links.md)" >> $GITHUB_OUTPUT
-      - if: ${{ failure() && env.FREEZE != 'true'}}
-        name: Create issue from file
+
+      - name: Create issue from file
+        if: ${{ hashFiles('broken_github_github_links.md') != '' && env.FREEZE != 'true' }}
         id: github-github-broken-link-report
         uses: peter-evans/create-issue-from-file@433e51abf769039ee20ba1293a088ca19d573b7f
         with:
@@ -89,3 +86,12 @@ jobs:
           content-filepath: ./broken_github_github_links.md
           repository: ${{ env.REPORT_REPOSITORY }}
           labels: ${{ env.REPORT_LABEL }}
+
+      - name: Send Slack notification if workflow fails
+        uses: someimportantcompany/github-actions-slack-message@1d367080235edfa53df415bd8e0bbab480f29bad
+        if: ${{ failure() && env.FREEZE != 'true' }}
+        with:
+          channel: ${{ secrets.DOCS_ALERTS_SLACK_CHANNEL_ID }}
+          bot-token: ${{ secrets.SLACK_DOCS_BOT_TOKEN }}
+          color: failure
+          text: The last "Check Broken Docs Links in github/github" run for ${{github.repository}} failed. See https://github.com/${{github.repository}}/actions/workflows/check-broken-links-github-github.yml

.github/workflows/main-preview-docker-cache.yml

@@ -30,7 +30,7 @@ jobs:
 
     steps:
       - name: 'Az CLI login'
-        uses: azure/login@1f63701bf3e6892515f1b7ce2d2bf1708b46beaf
+        uses: azure/login@92a5484dfaf04ca78a94597f4f19fea633851fa2 # pin @v1.4.6
         with:
           creds: ${{ secrets.NONPROD_AZURE_CREDENTIALS }}
 

.github/workflows/notify-about-deployment.yml

@@ -62,5 +62,6 @@ jobs:
 
             The SHA of https://docs.github.com/_build matches the merge commit in this PR.
 
-            If you don't see updates when expected, try opening the page(s) in a private browser window as the content may be cached. The content should be visible within a few hours even on non-private browser windows if this happens.
+            If you don't see updates when expected, try adding a random query string to the URL like `?bla=1234` and see if that helps.
+            If that shows the expected content, it would indicate that the CDN is "overly caching" the page still. It will eventually update, but it can take a while.
           edit-mode: replace

.github/workflows/orphaned-assets-check.yml

@@ -61,7 +61,7 @@ jobs:
 
           gh pr create \
             --title "Delete orphaned assets ($date)" \
-            --body "Found with the find-orphaned-assets.js script" \
+            --body "Found with the find-orphaned-assets.js script.\n\nFor more info see https://github.com/github/docs-engineering/blob/main/docs/orphaned-assets.md" \
             --repo github/docs-internal \
             --label docs-content-fr
 

.github/workflows/sync-openapi.yml

@@ -112,4 +112,4 @@ jobs:
           channel: ${{ secrets.DOCS_ALERTS_SLACK_CHANNEL_ID }}
           bot-token: ${{ secrets.SLACK_DOCS_BOT_TOKEN }}
           color: failure
-          text: The last Sync OpenAPI schema run for ${{github.repository}} failed. See https://github.com/${{github.repository}}/actions/workflows/openapi-decorate.yml
+          text: The last Sync OpenAPI schema run for ${{github.repository}} failed. See https://github.com/${{github.repository}}/actions/workflows/sync-openapi.yml

.github/workflows/test.yml

@@ -43,9 +43,9 @@ jobs:
             // repos.
             return [
               { name: 'content', path: 'tests/content', },
-              { name: 'graphql', path: 'tests/graphql', },
-              { name: 'events', path: 'src/events/tests', },
               { name: 'automated-pipelines', path: 'src/automated-pipelines/tests', },
+              { name: 'events', path: 'src/events/tests', },
+              { name: 'graphql', path: 'src/graphql/tests', },
               { name: 'rest', path: 'src/rest/tests', },
               { name: 'webhooks', path: 'src/webhooks/tests', },
               { name: 'linting', path: 'tests/linting', },
@@ -54,6 +54,7 @@ jobs:
               { name: 'rendering', path: 'tests/rendering', },
               { name: 'rendering-fixtures', path: 'tests/rendering-fixtures', },
               { name: 'search', path: 'src/search/tests', },
+              { name: 'pageinfo', path: 'src/pageinfo/tests', },
               context.payload.repository.full_name === 'github/docs-internal' &&
                 { name: 'translations', path: 'tests/translations', },
               { name: 'unit', path: 'tests/unit', },
@@ -177,5 +178,5 @@ jobs:
           # tests run only in English. The exception is the
           # `tests/translations/` suite which needs all languages to be set up.
           ENABLED_LANGUAGES: ${{ matrix.name == 'translations' && 'all' || '' }}
-          ROOT: ${{ matrix.name == 'rendering-fixtures' && 'tests/fixtures' || ''}}
+          ROOT: ${{ (matrix.name == 'rendering-fixtures' || matrix.name == 'pageinfo') && 'tests/fixtures' || ''}}
         run: npm test -- ${{ matrix.path }}/

.github/workflows/translation-health-report.yml

@@ -94,7 +94,7 @@ jobs:
         run: cat $GITHUB_WORKSPACE/translation-health-report.json
 
       - name: Log in to Azure
-        uses: azure/login@1f63701bf3e6892515f1b7ce2d2bf1708b46beaf
+        uses: azure/login@92a5484dfaf04ca78a94597f4f19fea633851fa2 # pin @v1.4.6
         with:
           creds: ${{ secrets.PROD_AZURE_CREDENTIALS }}