1
0
mirror of synced 2026-01-05 12:07:35 -05:00
Commit Graph

488 Commits

Author SHA1 Message Date
Mike Surowiec
9386571aa4 fix: use named export for all-versions (#20478)
* fix: use named export for all-versions

* run prettier
2021-07-22 19:29:00 +00:00
Grace Park
44f451eb09 Removing webpack build step (#20405)
* removing webpack build step

* keep copywebpackplugin and add fonts to assets/fonts

* update marketing font path

* update font path

* update font

* remove builtAssets

* remove copying front end code with dist

* move Inter fonts to /assets/fonts/inter

* move copy-webpack-plugin back to deps

Co-authored-by: Mike Surowiec <mikesurowiec@users.noreply.github.com>
2021-07-22 09:11:30 -07:00
James M. Greene
df301cb5da Remove all code related to Redis page caching (#20457)
Towards simplification for https://github.com/github/docs-engineering/issues/678
2021-07-21 20:44:00 +00:00
Mike Surowiec
df38087aed Update 404/500 pages to no longer use liquid templates (#20450)
* Update 404/500 page rendering to no longer use liquid templates

* updating tests

* remove unused path

Co-authored-by: Grace Park <gracepark@github.com>
2021-07-21 12:22:30 -07:00
Laura Coursen
88dd272f29 Rename GitHub product (#20347) 2021-07-21 12:22:30 +01:00
Mike Surowiec
6bc50f7e30 fix: filter hidden pages from the currentProductTree (SidebarProduct) (#20404)
* fix some async test things

* allow eslint to parse top-level awaits

* fix: filter out hidden pages closer to SidebarProduct usage
2021-07-20 12:32:35 -04:00
Sarah Edwards
b671aaf89f Add browser tests for tool selector (#19124)
Co-authored-by: James M. Greene <JamesMGreene@github.com>
2021-07-20 15:48:18 +00:00
Sarah Schneider
cc2d10d1b3 Rewrite Liquid deprecation script (#20225) 2021-07-19 22:36:15 +00:00
Grace Park
27aa5d92ea Remove FEATURE_NEXTJS Flag Part 1 (#20176)
* cleanup FEATURE_NEXTJS

* fixing some server tests

* updating article a for server tests

* update h2 to h4 map topic tests

* data off on TOCs

* updating dropdown article versions links

* Update so markdown renders in intros

* updating typo and all server tests are now passing

* remove nextjs feature flag

* head.js tests pass

* updating article-version-picker

* remove nextjs feature flag browser test

* update header.js tests

* fix page-titles.js test

* fix deprecated-enterprise versions

* adding early access

* testing

* getting childTocItem

* fixing table of contents to show child toc items

* updated to 2 because the sidebar article also has the same link

* remove comment

* updating pick

* Update TocLandingContext.tsx

* update package.json and change className to h4 for h2

* updating with mikes feedback

* remove a.active test

* React clean up: Delete unnecessary layouts/includes Part 2 (#20143)

* Delete unnecessary layouts

* setting back tests failing :(

* update layouts

* delete unnecessary includes

* remove github-ae-release-notes and updating layouts

* remove a.active test
2021-07-16 14:54:25 -07:00
Kevin Heis
8a56437c93 Pretty format (#20352)
* Update prettier flow to include JS

* Run prettier

* ...run prettier
2021-07-14 14:35:01 -07:00
Kevin Heis
42e785b0a8 Migrate CommonJS to ESM (#20301)
* First run of script

* Get the app running --- ish

* Get NextJS working

* Remove `node:`

* Get more tests passing in unit directory

* Update FailBot test to use nock

* Update test.yml

* Update Dockerfile

* tests/content fixes

* Update page.js

* Update build-changelog.js

* updating tests/routing

* Update orphan-tests.js

* updating tests/rendering

* Update .eslintrc.js

* Update .eslintrc.js

* Install jest/globals

* "linting" tests

* staging update to server.mjs

* Change '.github/allowed-actions.js' to a ESM export

* Lint

* Fixes for the main package.json

* Move Jest to be last in the npm test command so we can pass args

* Just use 'npm run lint' in the npm test command

* update algolia label script

* update openapi script

* update require on openapi

* Update enterprise-algolia-label.js

* forgot JSON.parse

* Update lunr-search-index.js

* Always explicitly include process.cwd() for JSON file reads pathed from project root

* update graphql/update-files.js script

* Update other npm scripts using jest to pass ESM NODE_OPTIONS

* Update check-for-enterprise-issues-by-label.js for ESM

* Update create-enterprise-issue.js for ESM

* Import jest global for browser tests

* Convert 'script/deploy' to ESM

Co-authored-by: Grace Park <gracepark@github.com>
Co-authored-by: James M. Greene <jamesmgreene@github.com>
2021-07-14 13:49:18 -07:00
James M. Greene
2dbae93c53 Try to prevent late/duplicate response errors (#20077)
* Ensure all Express 'next' calls include 'return's

* Add headersSent checks during archived versions flow

* Return a 404 earlier if archived resource fetch fails

* Short-circuit responses for archived stuff

* Be more careful about responding to and short-circuiting after search requests

* Fix tests
2021-06-28 19:31:54 +00:00
Mike Surowiec
9471394406 Disable client-side link transitions (#20141)
* add prop to disable client-side transition

* fix: disableClientTransition by default until we can figure out caching issue

* skip the next/link test
2021-06-24 14:35:23 -07:00
Rachael Sewell
6d248082b5 sidebar style updates (#19929) 2021-06-24 11:15:24 -07:00
Rachael Sewell
52cf583bdd add short titles to frontmatter (#20131) 2021-06-24 11:02:53 -07:00
Sarah Schneider
cffafaf748 Merge branch 'main' into revert-20087-revert-20069-fix-homepage-versions-dropdown 2021-06-24 12:40:17 -04:00
Kevin Heis
d3403e8653 Address goofy exports (#20113)
* Address a goofy export

* Fix more exports

* Change two exports
2021-06-24 14:59:06 +00:00
Sarah Schneider
d3b794f5b7 remove out of date test 2021-06-24 10:26:22 -04:00
Sarah Schneider
7de66fe4ef Merge branch 'main' of github.com:github/docs-internal into script-to-use-short-versions 2021-06-24 10:14:50 -04:00
Matt Pollard
46cca06438 Merge branch 'main' into revert-20087-revert-20069-fix-homepage-versions-dropdown 2021-06-24 08:57:17 +02:00
Matt Pollard
4e99bceff3 Change title for admin product from "GitHub Enterprise" back to "Enterprise administrators" (#20089) 2021-06-24 06:15:42 +00:00
Sarah Schneider
3b78be7ff0 Merge branch 'main' into revert-20087-revert-20069-fix-homepage-versions-dropdown 2021-06-23 18:55:17 -04:00
Kevin Heis
a92d820888 Remove remaining JSON requires (#20110)
* Remove remaining JSON requires

* Lint

* Update feature-flags.js
2021-06-23 14:57:50 -07:00
Sarah Schneider
7e3e75616c Merge branch 'main' of github.com:github/docs-internal into feature-versioning 2021-06-23 15:59:37 -04:00
Sarah Schneider
d454e4032e Merge branch 'main' of github.com:github/docs-internal into feature-versioning 2021-06-23 15:16:52 -04:00
Sarah Schneider
a8709c42ee lint 2021-06-23 15:16:16 -04:00
Sarah Schneider
2427f92893 write tests to ensure that ghes versioning in a feature gets combined with ghes versioning frontmatter, and does NOT overwrite it 2021-06-23 15:03:12 -04:00
Sarah Schneider
5e10cea9ac Merge branch 'main' of github.com:github/docs-internal into script-to-use-short-versions 2021-06-23 14:45:10 -04:00
Grace Park
06ebe03c9b one more update on createApp change 2021-06-23 11:25:29 -07:00
Grace Park
bb86a86459 Merge branch 'dynamic-esm' of https://github.com/github/docs-internal into dynamic-esm 2021-06-23 11:21:28 -07:00
Grace Park
fcf1fdd682 adding james feedback to add single app instance 2021-06-23 11:21:20 -07:00
Grace Park
00ed3e945a Update tests/unit/versions.js
Co-authored-by: James M. Greene <JamesMGreene@github.com>
2021-06-23 11:20:35 -07:00
Grace Park
cb69acf071 Update tests/unit/products.js
Co-authored-by: James M. Greene <JamesMGreene@github.com>
2021-06-23 11:20:26 -07:00
Grace Park
cbed05ad17 usefaketimers on server test 2021-06-23 11:13:06 -07:00
Grace Park
cbdd722cac Merge branch 'main' into dynamic-esm 2021-06-23 10:46:25 -07:00
Grace Park
6c0b43a4bb updating libapp in one script and tests 2021-06-23 10:46:10 -07:00
Grace Park
24bf653228 Update tests/unit/versions.js
Co-authored-by: James M. Greene <JamesMGreene@github.com>
2021-06-23 10:21:04 -07:00
Grace Park
dce2a7b629 Update tests/unit/products.js
Co-authored-by: James M. Greene <JamesMGreene@github.com>
2021-06-23 10:20:43 -07:00
Sarah Schneider
af018389ce add tests to ensure that the homepages have the expected links 2021-06-23 13:09:04 -04:00
Sarah Schneider
15e33f05e7 Revert "Revert "Fix homepage versions dropdown" (#20087)"
This reverts commit f9f0b2ce86.
2021-06-23 10:12:36 -04:00
Matt Pollard
f9f0b2ce86 Revert "Fix homepage versions dropdown" (#20087) 2021-06-23 09:11:51 +02:00
James M. Greene
7ee7a1aaaa Merge branch 'main' into feature-versioning 2021-06-22 15:28:34 -05:00
Grace Park
bcb11e607e Merge branch 'main' into dynamic-esm 2021-06-22 12:55:26 -07:00
Sarah Schneider
d0f130734e update tests 2021-06-22 15:16:31 -04:00
Grace Park
26f70c5563 updating tests for usefaketimers 2021-06-22 11:53:47 -07:00
Grace Park
23f586bb93 merge and fix conflicts 2021-06-22 11:41:10 -07:00
Grace Park
d3d1902414 Merge pull request #20017 from github/upgrade-esm
Enforce and Move to Top Level require
2021-06-22 11:27:48 -07:00
Sarah Schneider
489031c805 add a note about linting test 2021-06-22 13:44:22 -04:00
Mike Surowiec
a24d01f78a Fix NextJS 500s (#20048)
* feat: allow server to contextualize request when on a /_next/data path

* add client side routing test, run lint

* enable nextjs client side routing
2021-06-22 17:30:40 +00:00
Sarah Schneider
0c35c0233b Merge branch 'main' of github.com:github/docs-internal into script-to-use-short-versions 2021-06-22 12:50:47 -04:00