1
0
mirror of synced 2026-01-08 21:02:10 -05:00
Commit Graph

187 Commits

Author SHA1 Message Date
Jason Etcovitch
0ec47e0246 Only read the frontmatter from files in warm-server (#17222)
* Add read-frontmatter.js

* Use it

* Page static read/init are async now

* Fix some blockers

* I'm confused

* Fix some more bugs

* Use frontmatter schema, ensure end fence exists

* Fix a bug

* Still read full contents for index.md files

* Remove comment

* Only get ToC items for index pages

* Readd frontmatter error and verdadero handling

* Fix some borked tests

* Simplify the code

* Add a comment

* Remove redundant variable

* Re-simplify the Page construction

* End chunk _after_ endline

* Just use Page.init
2021-01-14 10:46:59 -05:00
Vanessa Yuen
641ed02e81 Actions Guides sublanding page (#16740)
Co-authored-by: Emily Gould <4822039+emilyistoofunky@users.noreply.github.com>
Co-authored-by: Cynthia Rich <crichID@github.com>
2021-01-11 18:30:57 +01:00
Barry McGee
adc9954094 Update tests with new expected semantic headings 2021-01-08 00:08:48 +00:00
Barry McGee
ffdd3b3d97 Update tests with new expected semantic headings 2021-01-08 00:08:47 +00:00
Abby Vollmer
f5a2c56de6 Project Visby site-policy updates (change date + hide from GitHub Docs) (#17139)
and support site policy hidden articles
2021-01-07 22:44:34 +00:00
James M. Greene
068c472084 Cache rendered pages in Redis (#17106)
* Explicitly set the Redis database number used for rate limiting

* Switch to using ioredis as the Redis client for rate limiting

* Install ioredis-mock as a primary dependency

* Create a Redis BasicAccessor class and tests

* Switch rendered page caching to use Redis for storage

* Add support for additional Redis SET options like TTLs

* Remove currently unused methods

* Rename redis-accessors/basic to redis-accessor and remove extra fluff

* Change default behavior for cache setting to throw if an error occurs

Add option allowSetFailures to facilitate graceful failures

* Allow SET failures to fail gracefully for the rendered page cache

* Remove as-yet unneeded serialization options from RedisAccessor

* Move Redis client construction into RedisAccessor constructor, just pass in databaseNumber as option

* Remove rendered-page-cache in favor of direct RedisAccessor use

* Add tests for RedisAccessor constructor param validations

* Eliminate one roundtrip to Redis for the cached HTML existence check

Are we fast yet?

* Set a rendered page cache TTL of 24 hours
2021-01-06 15:30:51 -06:00
Kevin Heis
3582de03da Parentheticals -> parentheses (#17130) 2021-01-05 17:04:01 +00:00
Kevin Heis
4ffc2a5e2b Fix a bunch of typos in tests dir (#17132)
Co-authored-by: Chiedo John <2156688+chiedo@users.noreply.github.com>
2021-01-05 11:25:14 -05:00
Kevin Heis
d7eb248a10 Fix a bunch of random typos (#17129)
Co-authored-by: Chiedo John <2156688+chiedo@users.noreply.github.com>
2021-01-05 16:07:27 +00:00
Sarah Schneider
1e76ef7ff2 replace pageWithSwitcher article with one that does not have a default platform set 2020-12-18 18:38:23 -05:00
Chiedo John
4654635962 Merge branch 'main' into default-platform 2020-12-18 10:45:26 -05:00
Kevin Heis
c62f49aa0e Block indexing not crawling (#17044)
* Block indexing instead of crawling

* Lint

* Update deprecated-enterprise-versions.js

* Combine loops
2020-12-17 11:57:18 -08:00
Sarah Schneider
185737342e the new map topic handling now needs context.currentPath 2020-12-17 12:02:28 -05:00
Sarah Schneider
969c8d5110 Merge branch 'main' into revert-16952-revert-16947-optimize-sitetree 2020-12-17 11:10:00 -05:00
Sarah Schneider
78895184a7 updates for clarity 2020-12-17 10:19:44 -05:00
Kevin Heis
59f375ab1d Merge branch 'main' into default-platform 2020-12-16 14:36:46 -08:00
Sarah Schneider
ef9b03a867 Merge branch 'main' of github.com:github/docs-internal into check-links-improvement-redux 2020-12-16 16:32:41 -05:00
Chiedo John
9ab71614fc Merge branch 'main' into revert-16952-revert-16947-optimize-sitetree 2020-12-16 15:03:20 -05:00
James M. Greene
9d73f5adef Remove accidentally committed console logging from test (#16813)
Co-authored-by: Chiedo John <2156688+chiedo@users.noreply.github.com>
2020-12-15 17:40:01 -05:00
Kevin Heis
3dae194793 Merge branch 'main' into revert-16952-revert-16947-optimize-sitetree 2020-12-15 11:01:37 -08:00
Kevin Heis
122da9610c Move redirect calculation from loadPages to loadRedirects (#16918)
* Move redirect calculation from loadPages to loadRedirects

* Make buildredirects a method for tests

* Update redirects.js

Co-authored-by: Chiedo John <2156688+chiedo@users.noreply.github.com>
2020-12-15 18:40:50 +00:00
Sarah Schneider
3dfd7a01af add test for unequal versions between category pages and child pages 2020-12-15 11:53:44 -05:00
Sarah Schneider
dca55a0257 Revert "Revert "sitetree optimizations"" 2020-12-14 20:25:01 -05:00
Sarah Schneider
b38eec9964 Revert "sitetree optimizations" 2020-12-14 16:53:04 -05:00
Sarah Schneider
624245dabe Merge branch 'main' of github.com:github/docs-internal into check-links-improvement-redux 2020-12-14 15:52:46 -05:00
Sarah Schneider
c412bd992a Merge branch 'main' into optimize-sitetree 2020-12-14 15:42:03 -05:00
Sarah Schneider
bc01b6c9f5 Merge branch 'main' into update-dates-script 2020-12-14 15:21:45 -05:00
Sarah Schneider
f5b050dc5e updates now that siteTree paths include language codes 2020-12-14 14:39:45 -05:00
Jason Etcovitch
d891618fcc Import Enterprise release notes for 2.20, 2.21 and 2.22.5 (#16909)
* Add 2.20

* Add 2.21

* Add 2.22.5

* Lint

* Properly format dates

* Update the tests
2020-12-14 15:16:29 +00:00
Jason Etcovitch
92d5722103 Add 2.22 release notes (#16586)
* Add 2.22.0

* Add 2.22.1

* Add 2.22.2

* Add 2.22.3

* Add 2.22.4

* Lint YAML files

* intro shouldn't be required

* Align all notes

* Full height sidebar

* Make the sidebar full height properly

* Get the real layout going

* Include full name

* Move details > summary around

* Fix sticky sidebar

* Tweak bottom of page

* Add more label colors

* Change heading title

* Don't be <details>, change sticky header

* Include other releases' info

* Show prev/next links

* Change sidenav to show all releases

* Fix ordering of chevron

* Fix link underlines

* Collapsing minor versions

* Moar padding

* Setup schema for sub-sections

* Update a YAML file to match schema

* Redo rendering/sorting logic

* Update layout

* Convert remaining notes

* Improve schema

* Use proper min properties

* Custom bullet points

* Show details control for version picker

* Improve layout on small screens

* One more tiny fix

* Order by semver

* Use proper version in details

* Fix extra arrows showing up

* Change label colors

* Pass the reference check

* Add gradients

* Gradient all the things
2020-12-11 13:43:11 -05:00
Simran Spiller
d565a13d8d Fix unit test error 2020-12-11 02:01:14 +01:00
Simran Spiller
4afc7d4035 Merge remote-tracking branch 'upstream/main' into default-platform 2020-12-11 01:13:32 +01:00
Simran Spiller
b08584e5be Improve and extend browser tests 2020-12-11 01:05:22 +01:00
Sarah Schneider
d4140663c2 Merge branch 'main' into update-dates-script 2020-12-10 13:58:02 -05:00
Sarah Schneider
82ad16c963 Merge branch 'main' into early-access-tweaks 2020-12-09 21:42:55 -05:00
Sarah Schneider
5b82f5e03e Merge branch 'main' into skip-early-access-tests 2020-12-09 21:32:50 -05:00
Sarah Schneider
cfc4f6754d Merge branch 'main' into early-access-tweaks 2020-12-09 21:13:50 -05:00
Sarah Schneider
e0c929c13f add exclusion 2020-12-09 21:13:11 -05:00
Sarah Schneider
bc6c0cc6be Merge branch 'main' of github.com:github/docs-internal into yank-outdated-redirect-code 2020-12-09 20:47:40 -05:00
James M. Greene
e6518ff9c3 Fix unresolved data lookups on GitHub Glossary page (#16815)
* Support [...] in data tag path

* Use forloop.index0 to get data tag path

* Commit whitespace change to not keep getting it

* Recursively render glossary terms as well

* Add tests to verify Liquid data tag can handle bracketed access

* Remove superfluous 'set' for context in tests

* Avoid the mystery guest anti-pattern... move the test data closer to the test

* Escape the `-` character in the data regex

Co-authored-by: Jason Etcovitch <jasonetco@github.com>
Co-authored-by: Chiedo John <2156688+chiedo@users.noreply.github.com>
2020-12-09 18:58:00 -06:00
Kevin Heis
e7406b7336 Merge branch 'main' into default-platform 2020-12-09 15:06:30 -08:00
Sarah Schneider
10152fa15a lint 2020-12-09 15:12:39 -05:00
Sarah Schneider
c48c02598b Merge branch 'main' of github.com:github/docs-internal into check-links-improvement-redux 2020-12-09 15:12:18 -05:00
Rachael Sewell
6a3d326fcf add one-off cases for hooks and pre-receive-hooks (#16784)
* add one-off cases for hooks and pre-receive-hooks

* add forum redirect

* update redirect test

* update 2.19-2.22 fixutres

* revert 2.18/2.19 changes

* remove dotcom test

* update dotcom test
2020-12-09 19:50:46 +00:00
Sarah Schneider
9a9b74379a Merge branch 'main' into check-links-improvement-redux 2020-12-09 14:49:17 -05:00
Kevin Heis
1b424dfdc4 Bring in data-directory, let's go async file reads (#16782)
* Bring in data-directory, let's go async file reads

* Lint fixes

* Update glossary.js
2020-12-09 11:20:24 -08:00
Sarah Schneider
cf11e27fc8 Merge branch 'main' into check-links-improvement-redux 2020-12-09 13:13:20 -05:00
Kevin Heis
62889986b6 Revert "Revert "Speed up warmServer by loading pages (and files) asyn… (#16837)
* Revert "Revert "Speed up warmServer by loading pages (and files) asynchronously (#16752)" (#16835)"

This reverts commit a14517115f.

* Move async to regular dependencies

* Update package-lock.json
2020-12-09 17:40:58 +00:00
Jason Etcovitch
a14517115f Revert "Speed up warmServer by loading pages (and files) asynchronously (#16752)" (#16835)
This reverts commit 1d5e216404.
2020-12-09 17:12:07 +00:00
Kevin Heis
1d5e216404 Speed up warmServer by loading pages (and files) asynchronously (#16752)
* Async `new Page`

* Update pages.js

* Update pages.js

* Update pages.js

* Update pages.js

* Update pages.js

* Using mapLimit

* Update pages.js

* Test updates

* Update pages.js

* Move exists to page class

* Test fixes

* Slightly faster localized paths process
2020-12-09 16:57:18 +00:00