1
0
mirror of synced 2026-01-05 21:04:17 -05:00
Commit Graph

19880 Commits

Author SHA1 Message Date
Marcelo Jacobus
cf2603ac01 fix: retry translation batch PR creation if we hit a 502 (#23633)
* Fix error on Pull Request creation

Fix https://github.com/github/docs-engineering/issues/1293. This
solution does not really handle the error, it just prevents the script
from stopping, since sometimes we get a timeout error from the load
balancer even though the request was successfully handled by rails.

* Add a nudge to the localization folks when a batch is created

Ever since the translation batches are created and merged automatically
it is difficult to see when they started or finished correctly. Also,
sometimes, docubot automatically closes some pull requests, and at the
time of this writing I don't know the reason.

This change intends to make batches not go unnoticed. We can revert it
later if this becomes too noisy and the process is stable.

* fix: remove ping to docs-localization team from batch PR body

Discussion: https://github.com/github/docs-internal/pull/23633/files#r771896816

* refactor: move report-reset-files into its own step

* refactor: move git push into its own step

* spike: move PR creation into its own script

* feat: annotate createTranslationBatchPullRequest fn

* enhancement: embed nwo#pr format in logger

* fix: import fs directly

* fix: import @actions/github directly

* docs: update annotations in fn block

* build: update step name to be self-documenting

* Retry on 502

* Rename method to reflect its behaviour

* Update codeowners

* Fix comment

* Update .github/actions-scripts/create-translation-batch-pr.js

Co-authored-by: Peter Bengtsson <peterbe@github.com>

* Update .github/actions-scripts/create-translation-batch-pr.js

Co-authored-by: Peter Bengtsson <peterbe@github.com>

* Update .github/actions-scripts/create-translation-batch-pr.js

Co-authored-by: Peter Bengtsson <peterbe@github.com>

* Appease linter and fix script

* Move options to main

* Rename var

* Refactor options

* Check for response

* First try to find and then to create the PR

* Update .github/actions-scripts/create-translation-batch-pr.js

Co-authored-by: Peter Bengtsson <peterbe@github.com>

* Update .github/actions-scripts/create-translation-batch-pr.js

Co-authored-by: Peter Bengtsson <peterbe@github.com>

* Update .github/actions-scripts/create-translation-batch-pr.js

Co-authored-by: Francis <15894826+francisfuzz@users.noreply.github.com>

* Remove unreachable conditional

* Lint

* fix: remove duplicate annotation

Co-authored-by: docubot <67483024+docubot@users.noreply.github.com>
Co-authored-by: Francis <15894826+francisfuzz@users.noreply.github.com>
Co-authored-by: Peter Bengtsson <peterbe@github.com>
2022-01-11 23:06:18 +00:00
Peter Bengtsson
8e25d1e40d remove all uses of include tool-switcher (part 1) (#24220)
* remove all uses of `include tool-switcher`

* two more files
2022-01-11 21:31:12 +00:00
Octomerger Bot
6e1bf63489 Merge pull request #24221 from github/repo-sync
repo sync
2022-01-11 15:27:16 -06:00
Octomerger Bot
07eebd1119 Merge branch 'main' into repo-sync 2022-01-11 15:23:22 -06:00
James M. Greene
23186b969c Fix CodeQL security alerts (#24198)
* Attempt to eliminate polynomial regular expression used on uncontrolled data

Closes https://github.com/github/docs-internal/security/code-scanning/112?query=ref%3Arefs%2Fheads%2Fmain
Closes https://github.com/github/docs-internal/security/code-scanning/107?query=ref%3Arefs%2Fheads%2Fmain

* Attempt to eliminate incomplete multi-character sanitization

Closes https://github.com/github/docs-internal/security/code-scanning/113?query=ref%3Arefs%2Fheads%2Fmain

* Keep closer to original pattern for now

Co-authored-by: Peter Bengtsson <peterbe@github.com>

Co-authored-by: Peter Bengtsson <peterbe@github.com>
2022-01-11 21:11:09 +00:00
Peter Bengtsson
667cc62e04 Merge pull request #13945 from github/peterbe-patch-1
Add --logHeapUsage to jest
2022-01-11 16:06:45 -05:00
James M. Greene
fc25c1a7be Simplify and correct 'npm test' usage in Workflows (#24219) 2022-01-11 21:05:39 +00:00
Octomerger Bot
3ffaa5c8d1 Merge pull request #13918 from github/repo-sync
repo sync
2022-01-11 14:57:47 -06:00
Grace Park
d5097397c8 underline links on toc pages (#24217) 2022-01-11 20:48:35 +00:00
James M. Greene
867285480e Revert back to using Next.js v11 (#24199)
Primarily a revert of #24082

Co-authored-by: Peter Bengtsson <peterbe@github.com>
2022-01-11 20:37:24 +00:00
Octomerger Bot
8da2f8e033 Merge pull request #24216 from github/repo-sync
repo sync
2022-01-11 14:26:41 -06:00
Octomerger Bot
8595461f49 Merge branch 'main' into repo-sync 2022-01-11 14:23:39 -06:00
Grace Park
f5c615cbd0 Guides List markup and Link Icon in Permalink Headings (#24211)
* list markup for article cards and learning paths

* adding link icon to section permalinks
2022-01-11 11:38:57 -08:00
Grace Park
d2494c3e2d Keyboard focus on Guides Pages (#24209)
* accessibility: make label autofocus on dropdown when clicked

* update to div element

* fix keyboard focus on X more guides and load more guides

* tabIndex is optional
2022-01-11 19:26:12 +00:00
Ethan Palm
cd186a1a71 Merge pull request #13925 from aarontwf/patch-2
Update release webhook short description API link
2022-01-11 11:26:08 -08:00
Ethan Palm
29dea899eb Merge branch 'main' into patch-2 2022-01-11 11:18:24 -08:00
GitHub Actions
627629e5d0 update search indexes 2022-01-11 18:34:15 +00:00
Grace Park
69543377cb Accessibility: Guides Pages, types/topics dropdown (#24185)
* accessibility: make label autofocus on dropdown when clicked

* update to div element
2022-01-11 17:53:55 +00:00
Octomerger Bot
79544ae716 Merge pull request #24208 from github/repo-sync
repo sync
2022-01-11 11:45:46 -06:00
docubot
f190206540 Merge branch 'main' into repo-sync 2022-01-11 09:42:18 -08:00
Peter Bengtsson
fd32d3a4e2 fix local dev with Safari (#24205)
* fix local dev with Safari

* refactoring

* refactoring
2022-01-11 17:41:20 +00:00
Winnie Li
bee7f5b9c7 Delete remove payment method page in billing docs (#23195)
* deleted remove payment method page

this feature is no longer supported

* remove deleted article from index

* remove links to deleted article

* removed mention of deleting payment method

* remove mention of deleting payment method

* Merge `main`

* Revert "Merge `main`"

This reverts commit 59c4c3c27981a4b17e10cabe6fd0eb46f46d9dfe.

* prune translations

Co-authored-by: Matt Pollard <mattpollard@users.noreply.github.com>
Co-authored-by: Ethan P <56270045+ethanpalm@users.noreply.github.com>
2022-01-11 17:21:25 +00:00
Sarita Iyer
2622d99c06 Merge pull request #24204 from github/openapi-update-a854b0b5dd20c365f4b2f16fcafe663165c482236c3db2c9aa5947842ed6c9c8
Update OpenAPI  Descriptions
2022-01-11 12:17:09 -05:00
Sarita Iyer
9ba779f97c Merge branch 'main' into openapi-update-a854b0b5dd20c365f4b2f16fcafe663165c482236c3db2c9aa5947842ed6c9c8 2022-01-11 12:07:28 -05:00
Jamie Cansdale
d2d0805f81 Add suggestion for nuspec files in troubleshooting (#12316)
Co-authored-by: hubwriter <hubwriter@github.com>
2022-01-11 17:06:21 +00:00
Octomerger Bot
7fd6ed166b Merge pull request #24207 from github/repo-sync
repo sync
2022-01-11 11:03:31 -06:00
Octomerger Bot
c55dbe95ff Merge branch 'main' into repo-sync 2022-01-11 10:59:48 -06:00
Laura Coursen
39a7acec1f Merge pull request #13942 from sj/patch-2
Clarify that Go is not an interpreted language in CodeQL documentation
2022-01-11 10:52:03 -06:00
Octomerger Bot
0a08974534 Merge pull request #24201 from github/repo-sync
repo sync
2022-01-11 10:50:54 -06:00
James M. Greene
ff682f2cd9 Merge branch 'main' into repo-sync 2022-01-11 10:46:21 -06:00
Laura Coursen
09f0f86b08 Merge branch 'main' into patch-2 2022-01-11 10:44:09 -06:00
Laura Coursen
488b429390 Merge pull request #13926 from andrekolodochka/patch-5
Change `can` to `must` for SCIM in EMUs
2022-01-11 10:20:22 -06:00
Laura Coursen
2d1aca20da Merge branch 'main' into patch-5 2022-01-11 10:12:36 -06:00
Ramya Parimi
ec6d783bb5 Update README.md (#24203)
very -> every
2022-01-11 10:46:03 -05:00
github-openapi-bot
25987055aa Add decorated OpenAPI schema files 2022-01-11 15:39:33 +00:00
github-openapi-bot
9924ddfbea Update OpenAPI Descriptions 2022-01-11 07:32:02 -08:00
Ramya Parimi
0483deb47d Revert "Merge branch 'main' of https://github.com/github/docs-internal"
This reverts commit 0aec07e16a, reversing
changes made to 738456c5b7.
2022-01-11 09:26:30 -06:00
Ramya Parimi
0aec07e16a Merge branch 'main' of https://github.com/github/docs-internal 2022-01-11 09:25:32 -06:00
Ramya Parimi
738456c5b7 Revert "Update README.md"
This reverts commit 28f0d8c46e.
2022-01-11 09:20:30 -06:00
Bas van Schaik
4228486ea4 Clarify that Go is not an interpreted language 2022-01-11 15:19:16 +00:00
Sarita Iyer
80e755ed79 Merge pull request #24195 from github/openapi-update-a854b0b5dd20c365f4b2f16fcafe663165c482236c3db2c9aa5947842ed6c9c8
Update OpenAPI  Descriptions
2022-01-11 10:18:25 -05:00
Ramya Parimi
ddca01e357 Merge pull request #13913 from AnilSeervi/about-pull-requests
Update keyboard shortcut to meet new style guidelines
2022-01-11 09:07:54 -06:00
Sarita Iyer
e2908accba Merge branch 'main' into openapi-update-a854b0b5dd20c365f4b2f16fcafe663165c482236c3db2c9aa5947842ed6c9c8 2022-01-11 10:04:45 -05:00
Ramya Parimi
28f0d8c46e Update README.md 2022-01-11 09:04:15 -06:00
docubot
c0a9f81de7 Merge branch 'main' into about-pull-requests 2022-01-11 07:00:15 -08:00
Ramya Parimi
18b2a83e28 Merge pull request #13916 from AnilSeervi/managing-accessibility-settings
Update keyboard tags to meet new style guidelines
2022-01-11 08:59:04 -06:00
docubot
c3f5d2937f Merge branch 'main' into about-pull-requests 2022-01-11 06:53:04 -08:00
Ramya Parimi
46b0a78a95 Merge branch 'main' into managing-accessibility-settings 2022-01-11 08:52:12 -06:00
Ramya Parimi
9c5c364fc4 Merge pull request #13912 from AnilSeervi/delete-branch-win
Update keyboard shortcut to meet new style guidelines
2022-01-11 08:52:03 -06:00
Ramya Parimi
2bdc8868b0 Merge branch 'main' into about-pull-requests 2022-01-11 08:50:23 -06:00