1
0
mirror of synced 2025-12-30 12:02:01 -05:00
Commit Graph

67 Commits

Author SHA1 Message Date
Marcelo Jacobus
cf2603ac01 fix: retry translation batch PR creation if we hit a 502 (#23633)
* Fix error on Pull Request creation

Fix https://github.com/github/docs-engineering/issues/1293. This
solution does not really handle the error, it just prevents the script
from stopping, since sometimes we get a timeout error from the load
balancer even though the request was successfully handled by rails.

* Add a nudge to the localization folks when a batch is created

Ever since the translation batches are created and merged automatically
it is difficult to see when they started or finished correctly. Also,
sometimes, docubot automatically closes some pull requests, and at the
time of this writing I don't know the reason.

This change intends to make batches not go unnoticed. We can revert it
later if this becomes too noisy and the process is stable.

* fix: remove ping to docs-localization team from batch PR body

Discussion: https://github.com/github/docs-internal/pull/23633/files#r771896816

* refactor: move report-reset-files into its own step

* refactor: move git push into its own step

* spike: move PR creation into its own script

* feat: annotate createTranslationBatchPullRequest fn

* enhancement: embed nwo#pr format in logger

* fix: import fs directly

* fix: import @actions/github directly

* docs: update annotations in fn block

* build: update step name to be self-documenting

* Retry on 502

* Rename method to reflect its behaviour

* Update codeowners

* Fix comment

* Update .github/actions-scripts/create-translation-batch-pr.js

Co-authored-by: Peter Bengtsson <peterbe@github.com>

* Update .github/actions-scripts/create-translation-batch-pr.js

Co-authored-by: Peter Bengtsson <peterbe@github.com>

* Update .github/actions-scripts/create-translation-batch-pr.js

Co-authored-by: Peter Bengtsson <peterbe@github.com>

* Appease linter and fix script

* Move options to main

* Rename var

* Refactor options

* Check for response

* First try to find and then to create the PR

* Update .github/actions-scripts/create-translation-batch-pr.js

Co-authored-by: Peter Bengtsson <peterbe@github.com>

* Update .github/actions-scripts/create-translation-batch-pr.js

Co-authored-by: Peter Bengtsson <peterbe@github.com>

* Update .github/actions-scripts/create-translation-batch-pr.js

Co-authored-by: Francis <15894826+francisfuzz@users.noreply.github.com>

* Remove unreachable conditional

* Lint

* fix: remove duplicate annotation

Co-authored-by: docubot <67483024+docubot@users.noreply.github.com>
Co-authored-by: Francis <15894826+francisfuzz@users.noreply.github.com>
Co-authored-by: Peter Bengtsson <peterbe@github.com>
2022-01-11 23:06:18 +00:00
James M. Greene
be4249b57c Remove the concept of "undeployment" as a part of the PR deployment lifecycle (#23731)
* Update remove-stale-staging-resources workflow to completely replace undeploy workflow
* Delete the staging-undeploy-pr workflow file
* Delete all undeployment scripts and logic
* Remove all references to the automated-block-deploy label used for undeployment
* Simplify staging cross-workflow concurrency needs
2022-01-06 16:27:48 +00:00
Sarah Edwards
d5c3731634 handle case where requestedReviewer is null (#24043) 2022-01-04 09:39:11 -08:00
Sarah Edwards
ed92a75e10 Classify hubber PRs as hubber contributions even in the OS repo (#23987)
Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>
2022-01-04 17:10:01 +00:00
Sarah Edwards
767d7d8f51 Get all open PRs instead of last 100 (#23985) 2022-01-04 16:16:58 +00:00
Peter Bengtsson
bf5c7353d2 eslint check the .github/actions-scripts/* files too (#23698)
* eslint check the .github/actions-scripts/* files too

* but ignore node_modules/.bin/*

* fix errors

* last one

* feedbacked
2021-12-15 17:35:34 +00:00
Peter Bengtsson
d3396ff4c0 ReferenceError in .github/actions-scripts/staging-commit-status-success.js (#23697) 2021-12-14 10:56:16 -05:00
Peter Bengtsson
f68eb74d90 Make a dedicated, fast, workflow just for docs-internal only (#23289)
* Make a dedicated, fast, workflow just for docs-internal only

Part of #1297

* make staging-build-pr only for github/docs

* prune later

* make it louder and clearer about disabling workflows

* does it merge?

* typo

* rename ref

* rename

* early access should be good to go

* far from perfect

* start with that

* gzip

* rearrange

* html_url

* correction of actions/checkout sha

* correction of actions/setup-node sha

* quote

* ooops

* actually deploy

* move @octokit/rest to dependencies

* await-sleep hack

* reinstall npm

* typo

* CONTEXT_NAME

* deployments:write permission

* pull-requests:read permission

* actions:read and statuses:write permissions

* private repo mention exception

* it's called github.run_id

* Apply suggestions from code review

Co-authored-by: James M. Greene <JamesMGreene@github.com>

* make CONTEXT_NAME optional (if it works)

* comment out CONTEXT_NAME

* simplifying

* going to run on on.pull_request instead

* remove comment

* only the 2-phase staging deploy on github/docs

* better if statement on label check

* refactor of staging-deploy script

* switch to npm install to get the deDependencies back

* using --only=dev

* updating comments

* event_name

* not on pushes to main

* add staging-commit-status-success

* testing testing

* fix linting error

* Remove other docs-internal references from staging-deploy-pr.yml

* Cleaning up new staging-commit-status-success script and usage

* Remove unnecessary environment refs

* Remove unnecessary fallback

Since the only event trigger is pull_request now instead of also push

* Remove unnecessary env vars from workflow

* docs-internal or docs but not both

* Don't provide unnecessary environment refs

* remove now moot exception

* setting it to pull_request_target

Co-authored-by: James M. Greene <JamesMGreene@github.com>
2021-12-14 08:57:54 -05:00
Peter Bengtsson
7b5711e095 cache archived enterproxy proxy responses much longer (#23456)
* cache archived enterproxy proxy responses much longer

* Update middleware/archived-enterprise-versions.js

Co-authored-by: Rachael Sewell <rachmari@github.com>

Co-authored-by: Rachael Sewell <rachmari@github.com>
2021-12-08 19:55:12 +00:00
Peter Bengtsson
4b329c0127 filter out CI failing PRs (#23487) 2021-12-08 18:37:22 +00:00
Vanessa
0901e7d12d Updates GHES template per 5367 (#23258) 2021-12-02 06:46:12 +10:00
Peter Bengtsson
1c4d326116 Make the staging files, for deployments, as lean as possible (#23049)
* Experiment with making the tarball smaller

Part of #1248

* try this

* stop debugging

* delete translations too

* delete heavy search indexes too

* push and popd

* try this hack

* delete but leave directory

* debug more

* faster delete of translations

* less loud

* async await

* async await

* no tree

* simplify

* experimenting more

* unfinished

* only the large files

* change order

* brotli with level 6

* cope better with decorated rest json files

* tidying

* keep images

* cleaning

* cleaning up

* refactored function

* try this

* better comment

* remove console logging

* more important changes

* improved fs.accessSync check
2021-12-01 19:01:46 +00:00
Robert Sese
6914be3e13 Make script executable (#23235) 2021-11-30 19:50:40 +00:00
Grace Park
0ee54e6284 make executable (#23232) 2021-11-30 19:22:20 +00:00
Grace Park
029dfd32a2 Migrate Prod build deploy to actions-script (#23228)
* revert to regular runner and migrate js to actions-scripts

* add prod deploy migration

* update .js

* add run_id
2021-11-30 19:02:31 +00:00
Grace Park
b77b195a6c Migrate Content Changes Table Workflow github-script code (#23198)
* moving content changes table to actions-script

* rename js file

* using context for neater code
2021-11-30 18:12:17 +00:00
Robert Sese
23ca5459dd Move from github-script to standalone script for staging undeploy (#23190)
* Move from github-script to standalone script for staging undeploy

* Add necessary env variables
2021-11-30 01:26:26 +00:00
Rachael Sewell
d6e56f369f github -> octokit (#23188) 2021-11-29 14:55:24 -08:00
Rachael Sewell
fce7e3cbb9 add run id env var (#23187) 2021-11-29 14:44:34 -08:00
Peter Bengtsson
224194b6d3 Migrate from actionsgithub script to own scripts staging deploy (#23184)
* migrate from actions/github-script to own scripts (staging deploy)

* make it executable

* remove need to --no-save install 'esm'

* don't use self-hosted runner so we get latest OS (2.285.0)

* remove pointless try/catch
2021-11-29 22:19:41 +00:00
Matt Pollard
c0cacb8004 Use "Contributor" (#23146) 2021-11-26 14:00:01 +01:00
Matt Pollard
bda92e7077 Update name of "Author" field in script that adds pull requests to review project (#23145) 2021-11-26 13:46:20 +01:00
Kevin Heis
5b1ac53379 A few things that Prettier seemed to miss (#23005) 2021-11-19 18:32:20 +00:00
Rachael Sewell
580c38b56a use repo variable and checkout repo in workflow (#22994) 2021-11-19 17:54:45 +00:00
Rachael Sewell
ca614134cb Simple merge queue (#22992) 2021-11-18 20:41:08 -08:00
Rachael Sewell
16cabecb78 fix syntax error in workflow (#22984) 2021-11-18 14:43:36 -08:00
Rachael Sewell
0cbf48b6aa replace context with env value (#22978) 2021-11-18 14:22:02 -08:00
Rachael Sewell
5b8cb34e4b remove old automerge method (#22941) 2021-11-18 09:47:46 -08:00
Lucas Costi
bf9963f9da Update engineering GHES deperecation steps (#22391) 2021-10-25 19:36:04 +00:00
Kevin Heis
967276b326 Update deprecation-issue.md (#22326) 2021-10-20 21:53:33 +00:00
Sarah Edwards
52b035f637 Strip all non-alphanumeric characters from mutation ID (#22214) 2021-10-15 22:31:02 +00:00
Rachael Sewell
970c16e1c5 Bump priority and add batch label so we can plan for deprecations (#22139) 2021-10-12 19:57:54 +00:00
Sarah Edwards
4c95de7b4b works if contributor has no issues or PRs in docs repo (#21937)
Co-authored-by: James M. Greene <JamesMGreene@github.com>
2021-10-06 22:09:04 +00:00
Sarah Edwards
4eb672aca4 fix sizes (#21859) 2021-10-01 20:05:15 +00:00
Sarah Edwards
f2347b7192 Adjust due date and xs size for function to add items to review board (#21846) 2021-10-01 08:55:23 -07:00
Ramya Parimi
e12d988c76 Automate triaging to content review board on adding waiting for review label (#21825)
* os-ready-for-review

* include grapqhl issue

* populate size, feature, first-time contributor (#21810)

* turnaround -> 3 & 2

* Update .github/workflows/os-ready-for-review.yml

Co-authored-by: Sarah Edwards <skedwards88@github.com>

* Update .github/workflows/os-ready-for-review.yml

Co-authored-by: Sarah Edwards <skedwards88@github.com>

* Update .github/workflows/os-ready-for-review.yml

Co-authored-by: Sarah Edwards <skedwards88@github.com>

* Update .github/workflows/os-ready-for-review.yml

Co-authored-by: Sarah Edwards <skedwards88@github.com>

* Update .github/workflows/os-ready-for-review.yml

Co-authored-by: Sarah Edwards <skedwards88@github.com>

* prettier

Co-authored-by: skedwards88 <skedwards88@github.com>
2021-10-01 06:26:02 -05:00
Lucas Costi
a250849924 Update GHES release issue template (#21552)
Co-authored-by: Felicity Chapman <felicitymay@github.com>
2021-09-21 01:54:21 +00:00
Rachael Sewell
a9c2c8eeae fix deprecation label spelling (#21474) 2021-09-13 18:12:03 +00:00
Rachael Sewell
94e3c092d3 English search sync (#21446) 2021-09-13 17:30:08 +00:00
Melanie Yarbrough
65ec6a5f5b Add docs-content issue maintenance step (#21382)
Co-authored-by: Sarah Edwards <skedwards88@github.com>
Co-authored-by: Rachael Sewell <rachmari@github.com>
Co-authored-by: Lucas Costi <lucascosti@users.noreply.github.com>
2021-09-10 13:21:57 -04:00
Sarah Edwards
e15ddfd1ed remove = from mutation ids to avoid graphql parse error (#21394) 2021-09-10 17:11:31 +00:00
Rachael Sewell
556457d843 updated openapi dev check to trigger on script updates (#21139) 2021-08-25 17:14:04 -07:00
Rachael Sewell
df16267a8f remove cached-index-names file and dry run sync used for Algolia (#21133) 2021-08-25 22:04:26 +00:00
Sarah Edwards
ab4ef61f9d Update scripts for populating docs-content review board (#20970) 2021-08-23 18:06:06 +00:00
Rachael Sewell
9a96a2699f Deprecation workflow updates (#20962) 2021-08-18 23:05:04 +00:00
Lucas Costi
ba3ce5cbfb Update the enterprise release issue template (#20828) 2021-08-12 23:33:11 +00:00
Sarah Edwards
841b05b504 Add PRs that are labeled with ready-for-doc-review to review board (#20770) 2021-08-12 18:45:20 +00:00
Rachael Sewell
72f0606377 split query into separate repos (#20816) 2021-08-11 16:35:07 -04:00
Rachael Sewell
47a8f1614a update repos for deprecation and release issues (#20464) 2021-08-11 16:03:08 -04:00
Kevin Heis
1ed18e1448 Clear out some non-fn references to Algolia (#20592)
* Clear out some non-fn references to Algolia

* Update .github/workflows/dry-run-sync-search-indices.yml

Co-authored-by: James M. Greene <JamesMGreene@github.com>

* Update contributing/search.md

Co-authored-by: James M. Greene <JamesMGreene@github.com>

Co-authored-by: James M. Greene <JamesMGreene@github.com>
2021-07-29 20:20:55 +00:00