jprdonnelly/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2026-05-06 21:00:10 -04:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #14563 from jordan-woyak/gbplayer-trigger-bits

Browse Source 
HW/GBPlayer: Fix swapped L/R triggers.
This commit is contained in:
JMC47
2026-04-05 19:28:16 -04:00
committed by GitHub
parent 45358509a5 798fff86fe
commit 28edd2fbb1
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
Source/Core/Core/HW/HSP/HSP_DeviceGBPlayer.cpp
View File

@@ -533,8 +533,9 @@ void CHSPDevice_GBPlayer::Write(u32 address, std::span<const u8, TRANSFER_SIZE>
}
case GBPRegister::Keypad:
{
const u16 value = Common::swap16(data.data() + 0x1e);
m_gbp->SetKeys(value & 0x3FF);
const u8 value_hi = data[0x1e]; // L/R triggers (need to be flipped).
const u8 value_lo = data[0x1f]; // All other buttons.
m_gbp->SetKeys(u16(((value_hi & 0x01u) << 9) | ((value_hi & 0x02u) << 7) | value_lo));
break;
}
default: