jprdonnelly/freeCodeCamp
1
0
Fork 0
mirror of https://github.com/freeCodeCamp/freeCodeCamp.git synced 2026-04-30 16:01:14 -04:00
Code Issues Projects Releases Wiki Activity

Revert "fix(UI): put legacy label on the old js curriculum title (#52980)" (#53266)

Browse Source
This commit is contained in:
Sem Bauke
2024-01-18 18:40:22 +01:00
committed by GitHub
parent 38cb0b3281
commit 6d9a5c334d
12 changed files with 20 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
client/config/cert-and-project-map.ts
View File

@@ -576,7 +576,7 @@ const allStandardCerts = [
},
{
id: '561abd10cb81ac38a17513bc',
title: 'Legacy JavaScript Algorithms and Data Structures',
title: 'JavaScript Algorithms and Data Structures',
certSlug: Certification.JsAlgoDataStruct,
projects: [
{

2
client/i18n/locales/english/intro.json
View File

@@ -217,7 +217,7 @@
}
},
"javascript-algorithms-and-data-structures": {
"title": "Legacy JavaScript Algorithms and Data Structures",
"title": "JavaScript Algorithms and Data Structures",
"intro": [
"While HTML and CSS control the content and styling of a page, JavaScript is used to make it interactive. In the JavaScript Algorithm and Data Structures Certification, you'll learn the fundamentals of JavaScript including variables, arrays, objects, loops, and functions.",
"Once you have the fundamentals down, you'll apply that knowledge by creating algorithms to manipulate strings, factorialize numbers, and even calculate the orbit of the International Space Station.",

4
client/i18n/locales/english/translations.json
View File

@@ -912,8 +912,8 @@
"title": {
"Responsive Web Design": "Responsive Web Design",
"responsive-web-design": "Responsive Web Design Certification",
"JavaScript Algorithms and Data Structures": "Legacy JavaScript Algorithms and Data Structures",
"javascript-algorithms-and-data-structures": "Legacy JavaScript Algorithms and Data Structures Certification",
"JavaScript Algorithms and Data Structures": "JavaScript Algorithms and Data Structures",
"javascript-algorithms-and-data-structures": "JavaScript Algorithms and Data Structures Certification",
"javascript-algorithms-and-data-structures-v8": "JavaScript Algorithms and Data Structures Certification",
"Front End Development Libraries": "Front End Development Libraries",
"front-end-development-libraries": "Front End Development Libraries Certification",

2
client/src/client-only-routes/show-project-links.tsx
View File

@@ -106,7 +106,7 @@ const ShowProjectLinks = (props: ShowProjectLinksProps): JSX.Element => {
if (certName === 'Legacy Full Stack') {
const certs = [
{ title: 'Responsive Web Design' },
{ title: 'Legacy JavaScript Algorithms and Data Structures' },
{ title: 'JavaScript Algorithms and Data Structures' },
{ title: 'Front End Development Libraries' },
{ title: 'Data Visualization' },
{ title: 'Back End Development and APIs' },

2
client/src/components/settings/certification.tsx
View File

@@ -115,7 +115,7 @@ const isCertMapSelector = createSelector(
isJsAlgoDataStructCertV8
}) => ({
'Responsive Web Design': isRespWebDesignCert,
'Legacy JavaScript Algorithms and Data Structures': isJsAlgoDataStructCert,
'JavaScript Algorithms and Data Structures': isJsAlgoDataStructCert,
'Front End Development Libraries': isFrontEndLibsCert,
'Data Visualization': is2018DataVisCert,
'Back End Development and APIs': isApisMicroservicesCert,

2
client/src/pages/learn/javascript-algorithms-and-data-structures/index.md
View File

@@ -1,5 +1,5 @@
---
title: Legacy JavaScript Algorithms and Data Structures
title: JavaScript Algorithms and Data Structures
superBlock: javascript-algorithms-and-data-structures
certification: javascript-algorithms-and-data-structures
---

17
client/src/redux/selectors.js
View File

@@ -137,6 +137,7 @@ export const certificatesByNameSelector = username => state => {
isRespWebDesignCert ||
is2018DataVisCert ||
isFrontEndLibsCert ||
isJsAlgoDataStructCert ||
isApisMicroservicesCert ||
isQaCertV7 ||
isInfosecCertV7 ||
@@ -149,11 +150,7 @@ export const certificatesByNameSelector = username => state => {
isFoundationalCSharpCertV8 ||
isJsAlgoDataStructCertV8,
hasLegacyCert:
isFrontEndCert ||
isJsAlgoDataStructCert ||
isBackEndCert ||
isDataVisCert ||
isInfosecQaCert,
isFrontEndCert || isBackEndCert || isDataVisCert || isInfosecQaCert,
isFullStackCert,
currentCerts: [
{
@@ -166,6 +163,11 @@ export const certificatesByNameSelector = username => state => {
title: 'JavaScript Algorithms and Data Structures (Beta) Certification',
certSlug: Certification.JsAlgoDataStructNew
},
{
show: isJsAlgoDataStructCert,
title: 'JavaScript Algorithms and Data Structures Certification',
certSlug: Certification.JsAlgoDataStruct
},
{
show: isFrontEndLibsCert,
title: 'Front End Development Libraries Certification',
@@ -228,11 +230,6 @@ export const certificatesByNameSelector = username => state => {
title: 'Front End Certification',
certSlug: Certification.LegacyFrontEnd
},
{
show: isJsAlgoDataStructCert,
title: 'Legacy JavaScript Algorithms and Data Structures Certification',
certSlug: Certification.JsAlgoDataStruct
},
{
show: isBackEndCert,
title: 'Back End Certification',

4
cypress/e2e/default/user/certifications.ts
View File

@@ -14,7 +14,7 @@ describe('Public profile certifications', () => {
// The following line is only required if you want to test it in development
//cy.contains('Preview custom 404 page').click();
cy.get('[data-cy=claimed-certification]').should('have.length', 19);
cy.get('[data-cy=claimed-certification]').should('have.length', 18);
});
it('Should show claimed certifications if the username includes uppercase characters', () => {
@@ -32,7 +32,7 @@ describe('Public profile certifications', () => {
// The following line is only required if you want to test it in development
//cy.contains('Preview custom 404 page').click();
cy.get('[data-cy=claimed-certification]').should('have.length', 19);
cy.get('[data-cy=claimed-certification]').should('have.length', 18);
});
});

7
e2e/map.spec.ts
View File

@@ -44,7 +44,6 @@ test.describe('Map Component', () => {
).toBeVisible();
const curriculumBtns = page.getByTestId('curriculum-map-button');
await expect(curriculumBtns).toHaveCount(superBlocksWithLinks.length);
for (let i = 0; i < superBlocksWithLinks.length; i++) {
const superblockLink = page.getByRole('link', {
// This is a hacky bypass because `Responsive Web Design` hits both links.
@@ -52,15 +51,13 @@ test.describe('Map Component', () => {
superBlockTitleOverride[intro[superBlocksWithLinks[i]].title] ??
intro[superBlocksWithLinks[i]].title
});
await expect(superblockLink).toBeVisible();
await expect(superblockLink).toHaveAttribute(
'href',
expect(await superblockLink.getAttribute('href')).toBe(
`/learn/${
superBlockSlugOverride[superBlocksWithLinks[i]] ??
superBlocksWithLinks[i]
}/`
);
await superblockLink.click();
}
});
});

6
e2e/profile.spec.ts
View File

@@ -9,7 +9,7 @@ const certs = [
},
{
name: 'JavaScript Algorithms and Data Structures',
url: '/certification/certifieduser/javascript-algorithms-and-data-structures-v8'
url: '/certification/certifieduser/javascript-algorithms-and-data-structures'
},
{
name: 'Front End Development Libraries',
@@ -59,10 +59,6 @@ const certs = [
const legacyCerts = [
{ name: 'Front End', url: '/certification/certifieduser/legacy-front-end' },
{
name: 'Legacy JavaScript Algorithms and Data Structures',
url: '/certification/certifieduser/javascript-algorithms-and-data-structures'
},
{ name: 'Back End', url: '/certification/certifieduser/legacy-back-end' },
{
name: 'Data Visualization',

3
shared/config/certification-settings.ts
View File

@@ -238,8 +238,7 @@ export const certTypeTitleMap = {
[certTypes.fullStack]: 'Legacy Full Stack',
[certTypes.respWebDesign]: 'Responsive Web Design',
[certTypes.frontEndDevLibs]: 'Front End Development Libraries',
[certTypes.jsAlgoDataStruct]:
'Legacy JavaScript Algorithms and Data Structures',
[certTypes.jsAlgoDataStruct]: 'JavaScript Algorithms and Data Structures',
[certTypes.dataVis2018]: 'Data Visualization',
[certTypes.apisMicroservices]: 'Back End Development and APIs',
[certTypes.qaV7]: 'Quality Assurance',

1
tools/scripts/seed/certified-user-data.js
View File

@@ -25,7 +25,6 @@ module.exports = {
is2018DataVisCert: true,
isFrontEndLibsCert: true,
isJsAlgoDataStructCert: true,
isJsAlgoDataStructCertV8: true,
isApisMicroservicesCert: true,
isInfosecQaCert: true,
isQaCertV7: true,