fix(client): review pages (#57086)

client/src/templates/Challenges/generic/show.tsx

@@ -254,7 +254,7 @@ const ShowGeneric = ({
                 />
               )}
 
-              {!!questions && (
+              {questions.length > 0 && (
                 <MultipleChoiceQuestions
                   questions={questions}
                   selectedOptions={selectedMcqOptions}

curriculum/get-challenges.js

@@ -324,6 +324,7 @@ function generateChallengeCreator(lang, englishPath, i18nPath) {
 
     if (!challenge.description) challenge.description = '';
     if (!challenge.instructions) challenge.instructions = '';
+    if (!challenge.questions) challenge.questions = [];
 
     // const superOrder = getSuperOrder(meta.superBlock);
     // NOTE: Use this version when a super block is in beta.

curriculum/schema/challenge-schema.js

@@ -243,7 +243,7 @@ const schema = Joi.object()
         challengeTypes.theOdinProject
       ],
       then: Joi.array().items(questionJoi).min(1).required(),
-      otherwise: Joi.forbidden()
+      otherwise: Joi.array().length(0)
     }),
     quizzes: Joi.when('challengeType', {
       is: challengeTypes.quiz,