jprdonnelly/freeCodeCamp
1
0
Fork 0
mirror of https://github.com/freeCodeCamp/freeCodeCamp.git synced 2026-01-21 06:02:37 -05:00
Code Issues Projects Releases Wiki Activity

refactor(client): remove unnecessary useEffect (#57397)

Browse Source
This commit is contained in:
Oliver Eyton-Williams
2024-12-04 19:30:54 +01:00
committed by GitHub
parent 24abd4d9fc
commit e11152d60b
4 changed files with 3 additions and 52 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
client/src/templates/Challenges/codeally/show.tsx
View File

@@ -177,7 +177,9 @@ function ShowCodeAlly(props: ShowCodeAllyProps) {
});
challengeMounted(challengeMeta.id);
container.current?.focus();
}, [props]); // TODO: split props, so that it doesn't rerender on every prop change
// This effect should be run once on mount
// eslint-disable-next-line react-hooks/exhaustive-deps
}, []);
const openGitpod = (userToken?: string) => {
const {

17
client/src/templates/Challenges/fill-in-the-blank/show.tsx
View File

@@ -124,23 +124,6 @@ const ShowFillInTheBlank = ({
// eslint-disable-next-line react-hooks/exhaustive-deps
}, []);
useEffect(() => {
updateChallengeMeta({
...challengeMeta,
title,
challengeType,
helpCategory
});
challengeMounted(challengeMeta.id);
}, [
title,
challengeMeta,
challengeType,
helpCategory,
challengeMounted,
updateChallengeMeta
]);
const handleSubmit = () => {
const blankAnswers = fillInTheBlank.blanks.map(b => b.answer);

17
client/src/templates/Challenges/generic/show.tsx
View File

@@ -117,23 +117,6 @@ const ShowGeneric = ({
// eslint-disable-next-line react-hooks/exhaustive-deps
}, []);
useEffect(() => {
updateChallengeMeta({
...challengeMeta,
title,
challengeType,
helpCategory
});
challengeMounted(challengeMeta.id);
}, [
title,
challengeMeta,
challengeType,
helpCategory,
challengeMounted,
updateChallengeMeta
]);
// video
const [videoIsLoaded, setVideoIsLoaded] = useState(false);

17
client/src/templates/Challenges/quiz/show.tsx
View File

@@ -202,23 +202,6 @@ const ShowQuiz = ({
// eslint-disable-next-line react-hooks/exhaustive-deps
}, []);
useEffect(() => {
updateChallengeMeta({
...challengeMeta,
title,
challengeType,
helpCategory
});
challengeMounted(challengeMeta.id);
}, [
title,
challengeMeta,
challengeType,
helpCategory,
challengeMounted,
updateChallengeMeta
]);
const handleFinishQuiz = () => {
setShowUnanswered(true);