jprdonnelly/impala
1
0
Fork 0
mirror of https://github.com/apache/impala.git synced 2025-12-25 02:03:09 -05:00
Code Issues Projects Releases Wiki Activity

IMPALA-13298: Correct test_miss_complete_cb Assertion

Browse Source 
Commit ad868b9 modified the RPC error messages to include the
query id. Part of this change was to remove the string
"Query aborted" from the test's beeswax client when it raises an
error.

The TestRPCTimeout.test_miss_complete_cb was missed and was still
asserting on the string "Query aborted". This patch fixes that test
to use the new error_msg_expected() function.

Testing was accomplished by running the
TestRPCTimeout.test_miss_complete_cb test locally.

Change-Id: Ifb2fa3864b52b0927c6488b22135913b90bce3bd
Reviewed-on: http://gerrit.cloudera.org:8080/21678
Reviewed-by: Riza Suminto <riza.suminto@cloudera.com>
Reviewed-by: Xuebin Su <xsu@cloudera.com>
Reviewed-by: Michael Smith <michael.smith@cloudera.com>
Tested-by: Michael Smith <michael.smith@cloudera.com>
This commit is contained in:
jasonmfehr
2024-08-15 14:04:44 -07:00
committed by Michael Smith
parent db0f0dadf1
commit 0a45cb5ae6
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
tests/custom_cluster/test_rpc_timeout.py
View File

@@ -22,6 +22,7 @@ from tests.beeswax.impala_beeswax import ImpalaBeeswaxException
from tests.common.custom_cluster_test_suite import CustomClusterTestSuite
from tests.common.impala_cluster import ImpalaCluster
from tests.common.skip import SkipIfBuildType, SkipIfFS
from tests.common.test_result_verifier import error_msg_expected
from tests.verifiers.metric_verifier import MetricVerifier
# The BE krpc port of the impalad to simulate rpc errors in tests.
@@ -228,7 +229,8 @@ class TestRPCTimeout(CustomClusterTestSuite):
debug_action = 'IMPALA_MISS_EXEC_COMPLETE_CB:FAIL@1.0'
ex = self.execute_query_expect_failure(self.client, query,
query_options={'retry_failed_queries': 'false', 'debug_action': debug_action})
assert "Query aborted" in str(ex)
assert error_msg_expected(str(ex), "Remote error: Runtime error: Debug Action: "
"IMPALA_SERVICE_POOL:FAIL")
class TestCatalogRPCTimeout(CustomClusterTestSuite):
""""Tests RPC timeout and retry handling for catalogd operations."""