jprdonnelly/impala
1
0
Fork 0
mirror of https://github.com/apache/impala.git synced 2025-12-19 18:12:08 -05:00
Code Issues Projects Releases Wiki Activity

IMPALA-14468: Don't generate errors during InitWorkloadManagement() when everything goes fine

Browse Source 
When Workload management is used first, CatalogD reports error "Table
not found: sys.impala_query_log". (also for sys.impala_query_live)

It is because during InitWorkloadManagement() we issue a ResetMetadata()
request against sys.impala_query_log to retrieve its schema version. If
the request fails with TableNotFound, we create the table. In other
words, the current initialization of workload management generates error
messages even when everything is going fine, and this can confuse users.

Instead of calling ResetMetadata() we can test the existence of the
workload management tables (sys.impala_query_log and
sys.impala_query_live) first.

Testing
 * tested manually that the error logs disappear

Change-Id: Ic7f7c92bda57d9fdc2185bf4ef8fd4f09aea0879
Reviewed-on: http://gerrit.cloudera.org:8080/23470
Reviewed-by: Michael Smith <michael.smith@cloudera.com>
Reviewed-by: Riza Suminto <riza.suminto@cloudera.com>
Tested-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com>
This commit is contained in:
Zoltan Borok-Nagy
2025-09-26 16:40:44 +02:00
committed by Impala Public Jenkins
parent ebbc67cf40
commit 4e2a81161a
1 changed files with 15 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
be/src/catalog/workload-management-init.cc
View File

@@ -360,10 +360,17 @@ static Status _upgradeTable(CatalogServiceIf* svc, const string& ip_addr,
} // function _upgradeTable
/// Retrieves the schema version of the specified table by reading its table properties.
static Status _getTableSchemaVersion(CatalogServiceIf* svc, const string& ip_addr,
const string& db, const string& tbl, Version* table_version) {
static Status _getTableSchemaVersion(Catalog* catalog, CatalogServiceIf* svc,
const string& ip_addr, const string& db, const string& tbl, Version* table_version) {
DCHECK_NE(nullptr, table_version);
TGetTablesResult get_table_results;
RETURN_IF_ERROR(catalog->GetTableNames(db, &tbl, &get_table_results));
if (get_table_results.tables.empty()) {
*table_version = NO_TABLE_EXISTS;
return Status::OK();
}
// Reset the table metadata to get the full metadata so its catalog object is fully
// populated enabling its properties to be read.
TResetMetadataRequest reset_req;
@@ -378,14 +385,7 @@ static Status _getTableSchemaVersion(CatalogServiceIf* svc, const string& ip_add
svc->ResetMetadata(reset_resp, reset_req);
if (reset_resp.result.status.status_code != TErrorCode::type::OK) {
Status reset_stat = Status(reset_resp.result.status);
if (reset_stat.code() == TErrorCode::type::GENERAL
&& starts_with(reset_stat.msg().msg(), "TableNotFoundException")) {
*table_version = NO_TABLE_EXISTS;
return Status::OK();
} else {
return reset_stat;
}
return Status(reset_resp.result.status);
}
// Read the table's catalog object to retrieve its table properties.
@@ -458,14 +458,14 @@ static Status _getTableSchemaVersion(CatalogServiceIf* svc, const string& ip_add
/// Manages the schema for a workload management table. If the table does not exist, it is
/// created. If it does exist, but is not on the schema version specified via the command
/// line flag, it is altered to bring it up to the new version.
static Status _tableSchemaManagement(CatalogServiceIf* svc, const string& ip_addr,
const string& table_name, const Version& target_schema_version,
static Status _tableSchemaManagement(Catalog* catalog, CatalogServiceIf* svc,
const string& ip_addr, const string& table_name, const Version& target_schema_version,
const bool is_system_table) {
Version parsed_actual_schema_version;
// Create and/or update the table if needed.
RETURN_IF_ERROR(_getTableSchemaVersion(
svc, ip_addr, WM_DB, table_name, &parsed_actual_schema_version));
catalog, svc, ip_addr, WM_DB, table_name, &parsed_actual_schema_version));
const string full_table_name = _fullTableName(WM_DB, table_name);
@@ -562,12 +562,12 @@ Status CatalogServer::InitWorkloadManagement() {
// Create and/or update the query log table if needed.
// Fully qualified table name based on startup flags.
RETURN_IF_ERROR(_tableSchemaManagement(thrift_iface_.get(), ip_addr,
RETURN_IF_ERROR(_tableSchemaManagement(catalog(), thrift_iface_.get(), ip_addr,
QueryLogTableName(false), target_schema_version, false));
// Create and/or update the query live table if needed.
// Fully qualified table name based on startup flags.;
RETURN_IF_ERROR(_tableSchemaManagement(thrift_iface_.get(), ip_addr,
RETURN_IF_ERROR(_tableSchemaManagement(catalog(), thrift_iface_.get(), ip_addr,
QueryLiveTableName(false), target_schema_version, true));
LOG(INFO) << "Completed workload management initialization";