jprdonnelly/impala
1
0
Fork 0
mirror of https://github.com/apache/impala.git synced 2025-12-19 18:12:08 -05:00
Code Issues Projects Releases Wiki Activity

IMPALA-14552: test_show_create_table should be more strict with TBLPROPERTIES contents

Browse Source 
Currently we use this regex to parse the contents of TBLPROPERTIES:

  kv_regex = "'([^\']+)'\\s*=\\s*'([^\']+)'"
  kv_results = dict(re.findall(kv_regex, map_match.group(1)))

This allows strings like:
 'X'='Y'='Z'
 'X'='Z'$'A'='B'

This means it's easy to write strings in .test files that are not valid
SQL. This patch adds a few extra checks to validate the TBLPROPERTIES
contents.

Change-Id: I94110f50720c01dc7807ee56c794d235f4990282
Reviewed-on: http://gerrit.cloudera.org:8080/23671
Tested-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com>
Reviewed-by: Riza Suminto <riza.suminto@cloudera.com>
This commit is contained in:
Zoltan Borok-Nagy
2025-11-13 17:34:59 +01:00
committed by Riza Suminto
parent 087b715a2b
commit 6810368c10
1 changed files with 10 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
tests/metadata/test_show_create_table.py
View File

@@ -41,8 +41,16 @@ def get_properties_map(sql, properties_map_name, exclusions=None):
map_match = re.search(properties_map_regex(properties_map_name), sql)
if map_match is None:
return dict()
kv_regex = "'([^\']+)'\\s*=\\s*'([^\']+)'"
kv_results = dict(re.findall(kv_regex, map_match.group(1)))
tbl_props_contents = map_match.group(1).strip()
kv_regex = r"'([^']*)'\s*=\s*'([^']*)'\s*(?:,|$)"
kv_results = dict(re.findall(kv_regex, tbl_props_contents))
# Verify [TBL|SERDE]PROPERTIES contents
stripped_sql = re.sub(r'\s+', '', tbl_props_contents)
reconstructed = ",".join("'{}'='{}'".format(k, v) for k, v in kv_results.items())
stripped_reconstructed = re.sub(r'\s+', '', reconstructed.strip())
assert stripped_sql == stripped_reconstructed, \
"[TBL|SERDE]PROPERTIES contents are not valid SQL: " + tbl_props_contents
if exclusions is not None:
for filtered_key in exclusions: