jprdonnelly/impala
1
0
Fork 0
mirror of https://github.com/apache/impala.git synced 2025-12-19 09:58:28 -05:00
Code Issues Projects Releases Wiki Activity

IMPALA-14546: Fix jdbc driver urls in test_postgres_jdbc_tables

Browse Source 
TestPostgresJdbcTables.test_postgres_jdbc_tables uses hardcoded paths
for JDBC driver URLs:
"/test-warehouse/data-sources/jdbc-drivers/postgresql-jdbc.jar".
This doesn't work correctly when running on Ozone where we need the
prefix of "ofs://localhost:9862/impala".

This patch fixes the issue by constructing the driver URL with
FILESYSTEM_PREFIX which is "ofs://localhost:9862/impala" on Ozone.
See more in bin/impala-config.sh about how it's set for different
filesystems.

Tests:
 - Ran the test on Ozone.

Change-Id: Ie0c4368b3262d4dcb9e1c05475506411be2e2ef5
Reviewed-on: http://gerrit.cloudera.org:8080/23787
Tested-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com>
Reviewed-by: Riza Suminto <riza.suminto@cloudera.com>
This commit is contained in:
stiga-huang
2025-12-15 19:26:24 +08:00
committed by Riza Suminto
parent 9d112dae23
commit aa4f19219c
1 changed files with 9 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
tests/custom_cluster/test_ext_data_sources.py
View File

@@ -25,6 +25,7 @@ from tests.common.custom_cluster_test_suite import CustomClusterTestSuite
from tests.common.environ import build_flavor_timeout
from tests.common.skip import SkipIfApacheHive
from tests.common.test_dimensions import create_exec_option_dimension
from tests.util.filesystem_utils import FILESYSTEM_PREFIX
from time import sleep
@@ -187,6 +188,8 @@ class TestPostgresJdbcTables(CustomClusterTestSuite):
@pytest.mark.execute_serially
def test_postgres_jdbc_tables(self, vector, unique_database):
driver_url = FILESYSTEM_PREFIX +\
"/test-warehouse/data-sources/jdbc-drivers/postgresql-jdbc.jar"
sql = """
DROP TABLE IF EXISTS {0}.country_postgres;
CREATE EXTERNAL TABLE {0}.country_postgres (
@@ -208,7 +211,7 @@ class TestPostgresJdbcTables(CustomClusterTestSuite):
"jdbc.url"="jdbc:postgresql://localhost:5432/functional",
"jdbc.auth"="AuthMech=0",
"jdbc.driver"="org.postgresql.Driver",
"driver.url"="/test-warehouse/data-sources/jdbc-drivers/postgresql-jdbc.jar",
"driver.url"="{1}",
"dbcp.username"="hiveuser",
"dbcp.password"="password",
"table"="country");
@@ -235,7 +238,7 @@ class TestPostgresJdbcTables(CustomClusterTestSuite):
"jdbc.url"="jdbc:postgresql://localhost:5432/functional",
"jdbc.auth"="AuthMech=0",
"jdbc.driver"="org.postgresql.Driver",
"driver.url"="/test-warehouse/data-sources/jdbc-drivers/postgresql-jdbc.jar",
"driver.url"="{1}",
"dbcp.username"="hiveuser",
"dbcp.password"="password",
"table"="quoted_col"
@@ -261,7 +264,7 @@ class TestPostgresJdbcTables(CustomClusterTestSuite):
"jdbc.url"="jdbc:postgresql://localhost:5432/functional",
"jdbc.auth"="AuthMech=0",
"jdbc.driver"="org.postgresql.Driver",
"driver.url"="/test-warehouse/data-sources/jdbc-drivers/postgresql-jdbc.jar",
"driver.url"="{1}",
"dbcp.username"="hiveuser",
"dbcp.password"="password",
"table"="country");
@@ -286,7 +289,7 @@ class TestPostgresJdbcTables(CustomClusterTestSuite):
"jdbc.url"="jdbc:postgresql://localhost:5432/functional",
"jdbc.auth"="AuthMech=0",
"jdbc.driver"="org.postgresql.Driver",
"driver.url"="/test-warehouse/data-sources/jdbc-drivers/postgresql-jdbc.jar",
"driver.url"="{1}",
"dbcp.username"="hiveuser",
"dbcp.password"="password",
"query"="select id,name,bool_col,tinyint_col,smallint_col,
@@ -313,13 +316,13 @@ class TestPostgresJdbcTables(CustomClusterTestSuite):
"jdbc.url"="jdbc:postgresql://localhost:5432/functional",
"jdbc.auth"="AuthMech=0",
"jdbc.driver"="org.postgresql.Driver",
"driver.url"="/test-warehouse/data-sources/jdbc-drivers/postgresql-jdbc.jar",
"driver.url"="{1}",
"dbcp.username"="hiveuser",
"dbcp.password"="password",
"query"="select id,name,bool_col,tinyint_col,smallint_col,
int_col,bigint_col,float_col,double_col,date_col,string_col,
timestamp_col from country");
""".format(unique_database)
""".format(unique_database, driver_url)
'''
try: