jprdonnelly/impala
1
0
Fork 0
mirror of https://github.com/apache/impala.git synced 2025-12-19 18:12:08 -05:00
Code Issues Projects Releases Wiki Activity

IMPALA-10899: buildall.sh -release_and_debug -codecoverage doesn't work as expected

Browse Source 
Until this patch buildall.sh -release_and_debug -codecoverage didn't
do a coverage build at all. It only did a release build, then a debug
build.

With this patch the above command creates a release+coverage build,
then a debug+coverage build. After each build it saves the .gcno
files to a directory in $IMPALA_HOME (gcov_release and gcov_debug).

These .gcno files are needed to generate code coverage reports later.

Testing:
 * manually tested by invoking buildall.sh -release_and_debug \
   -codecoverage
   and
   buildall.sh -release -codecoverage

Change-Id: I935501218697bf1660cc99a878cf554ef9f00f4c
Reviewed-on: http://gerrit.cloudera.org:8080/17982
Reviewed-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com>
Tested-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com>
This commit is contained in:
Zoltan Borok-Nagy
2021-10-27 18:04:11 +02:00
committed by Impala Public Jenkins
parent 9d2ef85647
commit cceeb08244
1 changed files with 33 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

35
buildall.sh
View File

@@ -457,8 +457,31 @@ build_all_components() {
fi
fi
${MAKE_CMD} -j${IMPALA_BUILD_THREADS:-4} ${IMPALA_MAKE_FLAGS} ${MAKE_TARGETS}
save_coverage_data ${build_type}
}
save_coverage_data() {
local build_type=$1
local gcov_prefix=''
case $build_type in
CODE_COVERAGE_RELEASE)
gcov_prefix='gcov_release'
;;
CODE_COVERAGE_DEBUG)
gcov_prefix='gcov_debug'
;;
*)
# Other build types don't generate coverage data
return
;;
esac
# Copy all '.gcno' files to ${gcov_prefix}
mkdir -p ${IMPALA_HOME}/${gcov_prefix}
pushd ${IMPALA_HOME}
find ./be -name '*.gcno' -exec \
cp --parents \{\} ./${gcov_prefix} \;
popd
}
# Called with the CMAKE_BUILD_TYPE as the first argument, e.g.
# generate_cmake_files DEBUG
@@ -609,9 +632,17 @@ if [[ "$BUILD_RELEASE_AND_DEBUG" -eq 1 ]]; then
# Build the standard release and debug builds. We can't do this for arbitrary build
# types because many build types reuse the same be/build/debug and be/build/release
# trees.
build_all_components RELEASE 1
CMAKE_BUILD_TYPE=RELEASE
if [[ ${CODE_COVERAGE} -eq 1 ]]; then
CMAKE_BUILD_TYPE=CODE_COVERAGE_RELEASE
fi
build_all_components ${CMAKE_BUILD_TYPE} 1
# Avoid rebuilding targets that are independent of the build type.
build_all_components DEBUG 0
CMAKE_BUILD_TYPE=DEBUG
if [[ ${CODE_COVERAGE} -eq 1 ]]; then
CMAKE_BUILD_TYPE=CODE_COVERAGE_DEBUG
fi
build_all_components ${CMAKE_BUILD_TYPE} 0
else
build_all_components $CMAKE_BUILD_TYPE 1
fi