jprdonnelly/impala
1
0
Fork 0
mirror of https://github.com/apache/impala.git synced 2025-12-25 02:03:09 -05:00
Code Issues Projects Releases Wiki Activity

Update the Avro scanner bad version header error message to include the file.

Browse Source 
This makes cases like IMPALA-2402 much easier to diagnose, since this
message will mostly occur if Impala tries to read a file that's not an
Avro data file.

Change-Id: I6504e668905ecc6964b77a6fe0cfc9c7511fd5c0
Reviewed-on: http://gerrit.cloudera.org:8080/1202
Reviewed-by: Skye Wanderman-Milne <skye@cloudera.com>
Tested-by: Internal Jenkins
This commit is contained in:
Skye Wanderman-Milne
2015-10-07 15:00:32 -07:00
committed by Harrison Sheinblatt
parent c0c4f0f36f
commit e4d12931dd
2 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
be/src/exec/hdfs-avro-scanner.cc
View File

@@ -79,10 +79,8 @@ Status HdfsAvroScanner::ReadFileHeader() {
RETURN_IF_FALSE(stream_->ReadBytes(
sizeof(AVRO_VERSION_HEADER), &header, &parse_status_));
if (memcmp(header, AVRO_VERSION_HEADER, sizeof(AVRO_VERSION_HEADER))) {
stringstream ss;
ss << "Invalid AVRO_VERSION_HEADER: '"
<< ReadWriteUtil::HexDump(header, sizeof(AVRO_VERSION_HEADER)) << "'";
return Status(ss.str());
return Status(TErrorCode::AVRO_BAD_VERSION_HEADER,
stream_->filename(), ReadWriteUtil::HexDump(header, sizeof(AVRO_VERSION_HEADER)));
}
// Decode relevant metadata (encoded as Avro map)

3
common/thrift/generate_error_codes.py
View File

@@ -197,6 +197,9 @@ error_codes = (
("SCANNER_INVALID_READ", 63, "Invalid read of $0 bytes. This may indicate data file "
"corruption. (file $1, byte offset: $2)"),
("AVRO_BAD_VERSION_HEADER", 64, "File '$0' has an invalid version header: $1\\n"
"Make sure the file is an Avro data file."),
)
import sys