Michael Smith 1f473f365a IMPALA-12390 (part 4): Enable unnecessary-value-param ...

Enables the clang-tidy performance-unnecessary-value-param check and
fixes any issues found with run_clang_tidy.sh.

Updates based on how values are used:
- constructors and functions that take ownership of a value accept by
  value and move into place to efficiently handle literal values
- others take a const& of the value

GetUsernameFromBasicAuthHeader was updated to make a copy closer to
where it's needed, rather than relying on the caller setting it up.

Updates CodegenNullPhiNode to use its 'name' parameter. Only impacts two
calls in filter-context.cc.

Change-Id: I8aa5d98596d82f615a0a728e0235e7dd9d8b5003
Reviewed-on: http://gerrit.cloudera.org:8080/20494
Reviewed-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com>
Tested-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com>

2024-10-31 23:42:04 +00:00

1.8 KiB

Raw Permalink Blame History

View Raw