mirror of
https://github.com/apache/impala.git
synced 2025-12-19 18:12:08 -05:00
182aa5066e
hs2_parquet_constraint and hs2_text_constraint is meant to extend test vector dimension to also test non-default test protocol (other than beeswax), but limit it to only run against 'parquet/none' or 'text/none' format accordingly. This patch modifies these constraints to default_protocol_or_parquet_constraint and default_protocol_or_text_constraint respectively such that the full file format coverage happen for default_test_protocol configuration and limited for the other protocols. Drop hs2_parquet_constraint entirely from test_utf8_strings.py because that test is already constrained to single 'parquet/none' file format. Num modified rows validation in date-fileformat-support.test and date-partitioning.test are changed to check the NumModifiedRows counter from profile. Fix TestQueriesJsonTables to always run with beeswax protocol because its assertions relies on beeswax-specific return values. Run impala-isort and fix few flake8 issues and in modified test files. Testing: Run and pass the affected test files using exhaustive exploration and env var DEFAULT_TEST_PROTOCOL=hs2. Confirmed that full file format coverage happen for hs2 protocol. Note that DEFAULT_TEST_PROTOCOL=beeswax is still the default. Change-Id: I8be0a628842e29a8fcc036180654cd159f6a23c8 Reviewed-on: http://gerrit.cloudera.org:8080/22775 Reviewed-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com> Tested-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com>
88 lines
3.8 KiB
Python
88 lines
3.8 KiB
Python
# Licensed to the Apache Software Foundation (ASF) under one
|
|
# or more contributor license agreements. See the NOTICE file
|
|
# distributed with this work for additional information
|
|
# regarding copyright ownership. The ASF licenses this file
|
|
# to you under the Apache License, Version 2.0 (the
|
|
# "License"); you may not use this file except in compliance
|
|
# with the License. You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing,
|
|
# software distributed under the License is distributed on an
|
|
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
|
|
# KIND, either express or implied. See the License for the
|
|
# specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
from __future__ import absolute_import, division, print_function
|
|
from copy import deepcopy
|
|
|
|
from tests.common.impala_test_suite import ImpalaTestSuite
|
|
from tests.common.test_dimensions import (
|
|
create_client_protocol_dimension,
|
|
create_exec_option_dimension,
|
|
default_protocol_or_parquet_constraint,
|
|
default_protocol_or_text_constraint,
|
|
)
|
|
|
|
|
|
class TestStringQueries(ImpalaTestSuite):
|
|
|
|
@classmethod
|
|
def add_test_dimensions(cls):
|
|
super(TestStringQueries, cls).add_test_dimensions()
|
|
cls.ImpalaTestMatrix.add_dimension(
|
|
create_exec_option_dimension(disable_codegen_options=[False, True]))
|
|
cls.ImpalaTestMatrix.add_constraint(lambda v:
|
|
v.get_value('table_format').file_format in ['text', 'json']
|
|
and v.get_value('table_format').compression_codec in ['none'])
|
|
# Run these queries through both beeswax and HS2 to get coverage of CHAR/VARCHAR
|
|
# returned via both protocols.
|
|
cls.ImpalaTestMatrix.add_dimension(create_client_protocol_dimension())
|
|
cls.ImpalaTestMatrix.add_constraint(default_protocol_or_text_constraint)
|
|
|
|
def test_chars(self, vector):
|
|
self.run_test_case('QueryTest/chars', vector)
|
|
|
|
def test_chars_tmp_tables(self, vector, unique_database):
|
|
# Tests that create temporary tables and require a unique database.
|
|
self.run_test_case('QueryTest/chars-tmp-tables', vector, unique_database)
|
|
|
|
# Regression tests for IMPALA-10753.
|
|
def test_chars_values_stmt(self, vector, unique_database):
|
|
vector = deepcopy(vector)
|
|
vector.get_value('exec_option')['values_stmt_avoid_lossy_char_padding'] = True
|
|
self.run_test_case('QueryTest/chars-values-stmt-no-lossy-char-padding',
|
|
vector, unique_database)
|
|
|
|
vector.get_value('exec_option')['values_stmt_avoid_lossy_char_padding'] = False
|
|
self.run_test_case('QueryTest/chars-values-stmt-lossy-char-padding',
|
|
vector, unique_database)
|
|
|
|
|
|
class TestCharFormats(ImpalaTestSuite):
|
|
|
|
@classmethod
|
|
def add_test_dimensions(cls):
|
|
super(TestCharFormats, cls).add_test_dimensions()
|
|
cls.ImpalaTestMatrix.add_dimension(
|
|
create_exec_option_dimension(disable_codegen_options=[False, True]))
|
|
cls.ImpalaTestMatrix.add_constraint(lambda v:
|
|
(v.get_value('table_format').file_format in ['avro']
|
|
and v.get_value('table_format').compression_codec in ['snap'])
|
|
or v.get_value('table_format').file_format in ['parquet']
|
|
or v.get_value('table_format').file_format in ['orc']
|
|
or (v.get_value('table_format').file_format in ['text', 'json']
|
|
and v.get_value('table_format').compression_codec in ['none']))
|
|
# Run these queries through both beeswax and HS2 to get coverage of CHAR/VARCHAR
|
|
# returned via both protocols.
|
|
cls.ImpalaTestMatrix.add_dimension(create_client_protocol_dimension())
|
|
cls.ImpalaTestMatrix.add_constraint(default_protocol_or_parquet_constraint)
|
|
|
|
def test_char_format(self, vector):
|
|
self.run_test_case('QueryTest/chars-formats', vector)
|
|
|
|
def test_string_literal(self, vector):
|
|
self.run_test_case('QueryTest/string-literals', vector)
|