mirror of
https://github.com/apache/impala.git
synced 2025-12-19 18:12:08 -05:00
5e39afc2d9
This patch aims to extract existing verifications on DEBUG_ACTION query option format onto pre-planner stage SetQueryOption(), in order to prevent failures on execution stage. Also, it localizes verification code for two existing types of debug actions. There are two types of debug actions, global e.g. 'RECVR_ADD_BATCH:FAIL' and ExecNode debug actions, e.g. '0:GETNEXT:FAIL'. Two types are implemented independently in source code, both having verification code intertwined with execution. In addition, global debug actions subdivide into C++ and Java, the two being more or less synchronized though. In case of global debug actions, most of the code inside existing DebugActionImpl() consists of verification, therefore it makes sense to make a wrapper around it for separating out the execution code. Things are worse for ExecNode debug actions, where verification code consists of two parts, one in DebugOptions() constructor and another one in ExecNode::ExecDebugActionImpl(). Additionally, some verification in constructor produces warnings, while ExecDebugActionImpl() verification either fails on DCHECK() or (in a single case) returns an error. For this case, a reasonable solution seems to be simply calling the constructor for a temporary object and extracting verification code from ExecNode::ExecDebugActionImpl(). This has the drawback of having the same warning being produced two times. Finally, having extracted verification code for both types, logic in impala::SetQueryOption() combines the two verification mechanisms. Note: In the long run, it is better to write a single verification routine for both Global and ExecNode debug actions, ideally as part of a general unification of the two existing debug_action mechanisms. With this in mind, the current patch intends to preserve current behavior, while avoiding complex refactoring. Change-Id: I53816aba2c79b556688d3b916883fee7476fdbb5 Reviewed-on: http://gerrit.cloudera.org:8080/22734 Reviewed-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com> Tested-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com>
98 lines
4.0 KiB
Python
98 lines
4.0 KiB
Python
# Licensed to the Apache Software Foundation (ASF) under one
|
|
# or more contributor license agreements. See the NOTICE file
|
|
# distributed with this work for additional information
|
|
# regarding copyright ownership. The ASF licenses this file
|
|
# to you under the Apache License, Version 2.0 (the
|
|
# "License"); you may not use this file except in compliance
|
|
# with the License. You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing,
|
|
# software distributed under the License is distributed on an
|
|
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
|
|
# KIND, either express or implied. See the License for the
|
|
# specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
from __future__ import absolute_import, division, print_function
|
|
|
|
from tests.common.impala_test_suite import ImpalaTestSuite
|
|
from tests.common.test_vector import ImpalaTestDimension
|
|
from tests.common.test_dimensions import create_parquet_dimension
|
|
|
|
|
|
class TestDebugAction(ImpalaTestSuite):
|
|
"""Test different verification scenarios for DEBUG_ACTION query option."""
|
|
|
|
_debug_actions = {
|
|
# Debug action and its corresponding expected error.
|
|
# Correct debug actions:
|
|
'RECVR_ADD_BATCH:FAIL@0.8':
|
|
'Debug Action: RECVR_ADD_BATCH:FAIL@0.8',
|
|
'0:GETNEXT:FAIL':
|
|
'Debug Action: FAIL',
|
|
|
|
# Invalid global debug actions:
|
|
'RECVR_ADD_BATCH:SLEEP':
|
|
'Invalid debug_action RECVR_ADD_BATCH:SLEEP (expected SLEEP@<ms>)',
|
|
'RECVR_ADD_BATCH:JITTER@8@8':
|
|
'Invalid debug_action RECVR_ADD_BATCH:JITTER@8@8 (invalid probability)',
|
|
'RECVR_ADD_BATCH:FAIL@8':
|
|
'Invalid debug_action RECVR_ADD_BATCH:FAIL@8 (invalid probability)',
|
|
'RECVR_ADD_BATCH:EXCEPTION@Unknown':
|
|
'Invalid debug_action RECVR_ADD_BATCH:EXCEPTION@Unknown (Invalid exception type)',
|
|
|
|
# Invalid ExecNode debug actions:
|
|
'0:GETNEXT:DELAY@aa':
|
|
'Invalid sleep duration: \'aa\'. Only non-negative numbers are allowed.',
|
|
|
|
# Both global and ExecNode debug actions are valid
|
|
'RECVR_ADD_BATCH:FAIL@0.8|0:GETNEXT:FAIL':
|
|
'Debug Action: FAIL',
|
|
|
|
# Both global and ExecNode debug actions are valid
|
|
'0:GETNEXT:FAIL|RECVR_ADD_BATCH:FAIL@0.8':
|
|
'Debug Action: FAIL',
|
|
|
|
# Global debug action is invalid
|
|
'RECVR_ADD_BATCH:FAIL@8|0:GETNEXT:FAIL':
|
|
'Invalid debug_action RECVR_ADD_BATCH:FAIL@8 (invalid probability)',
|
|
|
|
# Global debug action is invalid
|
|
'0:GETNEXT:FAIL|RECVR_ADD_BATCH:FAIL@8':
|
|
'Invalid debug_action RECVR_ADD_BATCH:FAIL@8 (invalid probability)',
|
|
|
|
# ExecNode debug action is invalid
|
|
'RECVR_ADD_BATCH:FAIL@0.8|0:GETNEXT:DELAY@aa':
|
|
'Invalid sleep duration: \'aa\'. Only non-negative numbers are allowed.',
|
|
|
|
# ExecNode debug action is invalid
|
|
'0:GETNEXT:DELAY@aa|RECVR_ADD_BATCH:FAIL@0.8':
|
|
'Invalid sleep duration: \'aa\'. Only non-negative numbers are allowed.',
|
|
|
|
# Both global and ExecNode debug actions are invalid, global prevails
|
|
'RECVR_ADD_BATCH:FAIL@8|0:GETNEXT:DELAY@aa':
|
|
'Invalid debug_action RECVR_ADD_BATCH:FAIL@8 (invalid probability)',
|
|
|
|
# Both ExecNode and global debug actions are invalid, ExecNode prevails
|
|
'0:GETNEXT:DELAY@aa|RECVR_ADD_BATCH:FAIL@8':
|
|
'Invalid sleep duration: \'aa\'. Only non-negative numbers are allowed.',
|
|
}
|
|
|
|
_query = "select * from functional.alltypes"
|
|
|
|
@classmethod
|
|
def add_test_dimensions(cls):
|
|
super(TestDebugAction, cls).add_test_dimensions()
|
|
# Pass only the keys (debug actions) to add_dimension()
|
|
cls.ImpalaTestMatrix.add_dimension(ImpalaTestDimension(
|
|
'debug_action', *cls._debug_actions.keys()))
|
|
cls.ImpalaTestMatrix.add_dimension(create_parquet_dimension(cls.get_workload()))
|
|
|
|
def test_failpoints(self, vector):
|
|
vector.get_value('exec_option')['debug_action'] = vector.get_value('debug_action')
|
|
result = self.execute_query_expect_failure(
|
|
self.client, self._query, vector.get_value('exec_option'))
|
|
assert self._debug_actions[vector.get_value('debug_action')] in str(result)
|