mirror of
https://github.com/apache/impala.git
synced 2025-12-19 18:12:08 -05:00
f98b697c7b
This change adds get_workload() to ImpalaTestSuite and removes it from all test suites that already returned 'functional-query'. get_workload() is also removed from CustomClusterTestSuite which used to return 'tpch'. All other changes besides impala_test_suite.py and custom_cluster_test_suite.py are just mass removals of get_workload() functions. The behavior is only changed in custom cluster tests that didn't override get_workload(). By returning 'functional-query' instead of 'tpch', exploration_strategy() will no longer return 'core' in 'exhaustive' test runs. See IMPALA-3947 on why workload affected exploration_strategy. An example for affected test is TestCatalogHMSFailures which was skipped both in core and exhaustive runs before this change. get_workload() functions that return a different workload than 'functional-query' are not changed - it is possible that some of these also don't handle exploration_strategy() as expected, but individually checking these tests is out of scope in this patch. Change-Id: I9ec6c41ffb3a30e1ea2de773626d1485c69fe115 Reviewed-on: http://gerrit.cloudera.org:8080/22726 Reviewed-by: Riza Suminto <riza.suminto@cloudera.com> Reviewed-by: Daniel Becker <daniel.becker@cloudera.com> Tested-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com>
128 lines
5.5 KiB
Python
128 lines
5.5 KiB
Python
# Licensed to the Apache Software Foundation (ASF) under one
|
|
# or more contributor license agreements. See the NOTICE file
|
|
# distributed with this work for additional information
|
|
# regarding copyright ownership. The ASF licenses this file
|
|
# to you under the Apache License, Version 2.0 (the
|
|
# "License"); you may not use this file except in compliance
|
|
# with the License. You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing,
|
|
# software distributed under the License is distributed on an
|
|
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
|
|
# KIND, either express or implied. See the License for the
|
|
# specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
|
|
from __future__ import absolute_import, division, print_function
|
|
import pytest
|
|
|
|
from tests.common.impala_connection import IMPALA_CONNECTION_EXCEPTION
|
|
from tests.common.impala_test_suite import ImpalaTestSuite
|
|
from tests.common.skip import SkipIfLocal
|
|
from tests.common.test_vector import ImpalaTestDimension
|
|
from subprocess import call
|
|
from tests.util.filesystem_utils import FILESYSTEM_PREFIX
|
|
|
|
# Modifications to test
|
|
MODIFICATION_TYPES=["delete_files", "delete_directory", "move_file", "append"]
|
|
|
|
|
|
@SkipIfLocal.hdfs_client
|
|
class TestHdfsFileMods(ImpalaTestSuite):
|
|
"""
|
|
This test suite tests that modifications to HDFS files don't crash Impala.
|
|
In particular, this interacts with existing functionality such as the
|
|
file handle cache and IO retries.
|
|
"""
|
|
|
|
@classmethod
|
|
def file_format_constraint(cls, v):
|
|
return v.get_value('table_format').file_format in ["text"]
|
|
|
|
@classmethod
|
|
def add_test_dimensions(cls):
|
|
super(TestHdfsFileMods, cls).add_test_dimensions()
|
|
cls.ImpalaTestMatrix.add_dimension(ImpalaTestDimension('modification_type',\
|
|
*MODIFICATION_TYPES))
|
|
cls.ImpalaTestMatrix.add_constraint(cls.file_format_constraint)
|
|
|
|
def setup_ext_table(self, unique_database, new_table_location):
|
|
# Use HDFS commands to clone the table's files at the hdfs level
|
|
old_table_location = "{0}/test-warehouse/tinytable".format(FILESYSTEM_PREFIX)
|
|
call(["hdfs", "dfs", "-mkdir", new_table_location])
|
|
self.filesystem_client.copy(old_table_location + "/*", new_table_location,
|
|
overwrite=True)
|
|
|
|
# Create an external table with the new files (tinytable has two string columns)
|
|
create_table = "create external table {0}.t1 (a string, b string) "\
|
|
+ "row format delimited fields terminated by \',\' location \'{1}\'"
|
|
self.client.execute(create_table.format(unique_database, new_table_location))
|
|
|
|
@pytest.mark.execute_serially
|
|
def test_file_modifications(self, vector, unique_database):
|
|
"""Tests file modifications on an external table."""
|
|
|
|
new_table_location = "{0}/test-warehouse/{1}".format(FILESYSTEM_PREFIX,\
|
|
unique_database)
|
|
self.setup_ext_table(unique_database, new_table_location)
|
|
|
|
# Query the table. If file handle caching is enabled, this will fill the cache.
|
|
count_query = "select count(*) from {0}.t1".format(unique_database)
|
|
original_result = self.execute_query_expect_success(self.client, count_query)
|
|
assert(original_result.data[0] == '3')
|
|
|
|
# Do the modification based on the test settings
|
|
modification_type = vector.get_value('modification_type')
|
|
if (modification_type == 'delete_files'):
|
|
# Delete the data file (not the directory)
|
|
call(["hdfs", "dfs", "-rm", "-skipTrash", new_table_location + "/*"])
|
|
elif (modification_type == 'delete_directory'):
|
|
# Delete the whole directory (including data file)
|
|
call(["hdfs", "dfs", "-rm", "-r", "-skipTrash", new_table_location])
|
|
elif (modification_type == 'move_file'):
|
|
# Move the file underneath the directory
|
|
call(["hdfs", "dfs", "-mv", new_table_location + "/data.csv", \
|
|
new_table_location + "/data.csv.moved"])
|
|
elif (modification_type == 'append'):
|
|
# Append a copy of the hdfs file to itself (duplicating all entries)
|
|
local_tmp_location = "/tmp/{0}.data.csv".format(unique_database)
|
|
call(["hdfs", "dfs", "-copyToLocal", new_table_location + "/data.csv", \
|
|
local_tmp_location])
|
|
call(["hdfs", "dfs", "-appendToFile", local_tmp_location, \
|
|
new_table_location + "/data.csv"])
|
|
call(["rm", local_tmp_location])
|
|
else:
|
|
assert False
|
|
|
|
# The query might fail, but nothing should crash.
|
|
try:
|
|
self.execute_query(count_query)
|
|
except IMPALA_CONNECTION_EXCEPTION:
|
|
pass
|
|
|
|
# Invalidate metadata
|
|
invalidate_metadata_sql = "invalidate metadata {0}.t1".format(unique_database)
|
|
self.execute_query_expect_success(self.client, invalidate_metadata_sql)
|
|
|
|
# Verify that nothing crashes and the query should succeed
|
|
new_result = self.execute_query_expect_success(self.client, count_query)
|
|
if (modification_type == 'move_file'):
|
|
assert(new_result.data[0] == '3')
|
|
elif (modification_type == 'delete_files' or \
|
|
modification_type == 'delete_directory'):
|
|
assert(new_result.data[0] == '0')
|
|
elif (modification_type == 'append'):
|
|
# Allow either the old count or the new count to tolerate delayed consistency.
|
|
assert(new_result.data[0] == '6' or new_result.data[0] == '3')
|
|
|
|
# Drop table
|
|
drop_table_sql = "drop table {0}.t1".format(unique_database)
|
|
self.execute_query_expect_success(self.client, drop_table_sql)
|
|
|
|
# Cleanup directory (which may already be gone)
|
|
call(["hdfs", "dfs", "-rm", "-r", "-skipTrash", new_table_location])
|
|
|