mirror of
https://github.com/apache/impala.git
synced 2025-12-22 03:18:15 -05:00
c26e3db4bd
Upgrades the impala-shell's bundled version of sqlparse to 0.3.1. There were some API changes in 0.2.0+ that required a re-write of the StripLeadingCommentFilter in impala_shell.py. A slight perf optimization was also added to avoid using the filter altogether if no leading comment is readily discernible. As 0.1.19 was the last version of sqlparse to support python 2.6, this patch also breaks Impala's compatibility with python 2.6. No new tests were added, but all existing tests passed without modification. Change-Id: I77a1fd5ae311634a18ee04b8c389d8a3f3a6e001 Reviewed-on: http://gerrit.cloudera.org:8080/15642 Reviewed-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com> Tested-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com>
152 lines
4.3 KiB
Python
152 lines
4.3 KiB
Python
# -*- coding: utf-8 -*-
|
|
|
|
# Tests splitting functions.
|
|
|
|
import types
|
|
|
|
import pytest
|
|
|
|
import sqlparse
|
|
from sqlparse.compat import StringIO, text_type
|
|
|
|
|
|
def test_split_semicolon():
|
|
sql1 = 'select * from foo;'
|
|
sql2 = "select * from foo where bar = 'foo;bar';"
|
|
stmts = sqlparse.parse(''.join([sql1, sql2]))
|
|
assert len(stmts) == 2
|
|
assert str(stmts[0]) == sql1
|
|
assert str(stmts[1]) == sql2
|
|
|
|
|
|
def test_split_backslash():
|
|
stmts = sqlparse.parse(r"select '\\'; select '\''; select '\\\'';")
|
|
assert len(stmts) == 3
|
|
|
|
|
|
@pytest.mark.parametrize('fn', ['function.sql',
|
|
'function_psql.sql',
|
|
'function_psql2.sql',
|
|
'function_psql3.sql',
|
|
'function_psql4.sql'])
|
|
def test_split_create_function(load_file, fn):
|
|
sql = load_file(fn)
|
|
stmts = sqlparse.parse(sql)
|
|
assert len(stmts) == 1
|
|
assert text_type(stmts[0]) == sql
|
|
|
|
|
|
def test_split_dashcomments(load_file):
|
|
sql = load_file('dashcomment.sql')
|
|
stmts = sqlparse.parse(sql)
|
|
assert len(stmts) == 3
|
|
assert ''.join(str(q) for q in stmts) == sql
|
|
|
|
|
|
@pytest.mark.parametrize('s', ['select foo; -- comment\n',
|
|
'select foo; -- comment\r',
|
|
'select foo; -- comment\r\n',
|
|
'select foo; -- comment'])
|
|
def test_split_dashcomments_eol(s):
|
|
stmts = sqlparse.parse(s)
|
|
assert len(stmts) == 1
|
|
|
|
|
|
def test_split_begintag(load_file):
|
|
sql = load_file('begintag.sql')
|
|
stmts = sqlparse.parse(sql)
|
|
assert len(stmts) == 3
|
|
assert ''.join(str(q) for q in stmts) == sql
|
|
|
|
|
|
def test_split_begintag_2(load_file):
|
|
sql = load_file('begintag_2.sql')
|
|
stmts = sqlparse.parse(sql)
|
|
assert len(stmts) == 1
|
|
assert ''.join(str(q) for q in stmts) == sql
|
|
|
|
|
|
def test_split_dropif():
|
|
sql = 'DROP TABLE IF EXISTS FOO;\n\nSELECT * FROM BAR;'
|
|
stmts = sqlparse.parse(sql)
|
|
assert len(stmts) == 2
|
|
assert ''.join(str(q) for q in stmts) == sql
|
|
|
|
|
|
def test_split_comment_with_umlaut():
|
|
sql = (u'select * from foo;\n'
|
|
u'-- Testing an umlaut: ä\n'
|
|
u'select * from bar;')
|
|
stmts = sqlparse.parse(sql)
|
|
assert len(stmts) == 2
|
|
assert ''.join(text_type(q) for q in stmts) == sql
|
|
|
|
|
|
def test_split_comment_end_of_line():
|
|
sql = ('select * from foo; -- foo\n'
|
|
'select * from bar;')
|
|
stmts = sqlparse.parse(sql)
|
|
assert len(stmts) == 2
|
|
assert ''.join(str(q) for q in stmts) == sql
|
|
# make sure the comment belongs to first query
|
|
assert str(stmts[0]) == 'select * from foo; -- foo\n'
|
|
|
|
|
|
def test_split_casewhen():
|
|
sql = ("SELECT case when val = 1 then 2 else null end as foo;\n"
|
|
"comment on table actor is 'The actor table.';")
|
|
stmts = sqlparse.split(sql)
|
|
assert len(stmts) == 2
|
|
|
|
|
|
def test_split_cursor_declare():
|
|
sql = ('DECLARE CURSOR "foo" AS SELECT 1;\n'
|
|
'SELECT 2;')
|
|
stmts = sqlparse.split(sql)
|
|
assert len(stmts) == 2
|
|
|
|
|
|
def test_split_if_function(): # see issue 33
|
|
# don't let IF as a function confuse the splitter
|
|
sql = ('CREATE TEMPORARY TABLE tmp '
|
|
'SELECT IF(a=1, a, b) AS o FROM one; '
|
|
'SELECT t FROM two')
|
|
stmts = sqlparse.split(sql)
|
|
assert len(stmts) == 2
|
|
|
|
|
|
def test_split_stream():
|
|
stream = StringIO("SELECT 1; SELECT 2;")
|
|
stmts = sqlparse.parsestream(stream)
|
|
assert isinstance(stmts, types.GeneratorType)
|
|
assert len(list(stmts)) == 2
|
|
|
|
|
|
def test_split_encoding_parsestream():
|
|
stream = StringIO("SELECT 1; SELECT 2;")
|
|
stmts = list(sqlparse.parsestream(stream))
|
|
assert isinstance(stmts[0].tokens[0].value, text_type)
|
|
|
|
|
|
def test_split_unicode_parsestream():
|
|
stream = StringIO(u'SELECT ö')
|
|
stmts = list(sqlparse.parsestream(stream))
|
|
assert str(stmts[0]) == 'SELECT ö'
|
|
|
|
|
|
def test_split_simple():
|
|
stmts = sqlparse.split('select * from foo; select * from bar;')
|
|
assert len(stmts) == 2
|
|
assert stmts[0] == 'select * from foo;'
|
|
assert stmts[1] == 'select * from bar;'
|
|
|
|
|
|
def test_split_quotes_with_new_line():
|
|
stmts = sqlparse.split('select "foo\nbar"')
|
|
assert len(stmts) == 1
|
|
assert stmts[0] == 'select "foo\nbar"'
|
|
|
|
stmts = sqlparse.split("select 'foo\n\bar'")
|
|
assert len(stmts) == 1
|
|
assert stmts[0] == "select 'foo\n\bar'"
|