mirror of
https://github.com/apache/impala.git
synced 2025-12-19 18:12:08 -05:00
Currently we use this regex to parse the contents of TBLPROPERTIES: kv_regex = "'([^\']+)'\\s*=\\s*'([^\']+)'" kv_results = dict(re.findall(kv_regex, map_match.group(1))) This allows strings like: 'X'='Y'='Z' 'X'='Z'$'A'='B' This means it's easy to write strings in .test files that are not valid SQL. This patch adds a few extra checks to validate the TBLPROPERTIES contents. Change-Id: I94110f50720c01dc7807ee56c794d235f4990282 Reviewed-on: http://gerrit.cloudera.org:8080/23671 Tested-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com> Reviewed-by: Riza Suminto <riza.suminto@cloudera.com>