mirror of
https://github.com/apache/impala.git
synced 2025-12-20 10:29:58 -05:00
ffa7829b70
For files that have a Cloudera copyright (and no other copyright notice), make changes to follow the ASF source file header policy here: http://www.apache.org/legal/src-headers.html#headers Specifically: 1) Remove the Cloudera copyright. 2) Modify NOTICE.txt according to http://www.apache.org/legal/src-headers.html#notice to follow that format and add a line for Cloudera. 3) Replace or add the existing ASF license text with the one given on the website. Much of this change was automatically generated via: git grep -li 'Copyright.*Cloudera' > modified_files.txt cat modified_files.txt | xargs perl -n -i -e 'print unless m#Copyright.*Cloudera#i;' cat modified_files_txt | xargs fix_apache_license.py [1] Some manual fixups were performed following those steps, especially when license text was completely missing from the file. [1] https://gist.github.com/anonymous/ff71292094362fc5c594 with minor modification to ORIG_LICENSE to match Impala's license text. Change-Id: I2e0bd8420945b953e1b806041bea4d72a3943d86 Reviewed-on: http://gerrit.cloudera.org:8080/3779 Reviewed-by: Dan Hecht <dhecht@cloudera.com> Tested-by: Internal Jenkins
83 lines
3.2 KiB
Python
83 lines
3.2 KiB
Python
# Licensed to the Apache Software Foundation (ASF) under one
|
|
# or more contributor license agreements. See the NOTICE file
|
|
# distributed with this work for additional information
|
|
# regarding copyright ownership. The ASF licenses this file
|
|
# to you under the Apache License, Version 2.0 (the
|
|
# "License"); you may not use this file except in compliance
|
|
# with the License. You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing,
|
|
# software distributed under the License is distributed on an
|
|
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
|
|
# KIND, either express or implied. See the License for the
|
|
# specific language governing permissions and limitations
|
|
# under the License.
|
|
#
|
|
import os
|
|
import pytest
|
|
import stat
|
|
import tempfile
|
|
|
|
from tests.common.custom_cluster_test_suite import CustomClusterTestSuite
|
|
from tests.common.skip import SkipIf
|
|
from tests.util.filesystem_utils import WAREHOUSE
|
|
|
|
tmp = tempfile.NamedTemporaryFile(delete=False)
|
|
BAD_KEY_FILE = tmp.name
|
|
|
|
@SkipIf.not_s3
|
|
class TestS3AAccess(CustomClusterTestSuite):
|
|
|
|
cmd_filename = ""
|
|
@classmethod
|
|
def setup_class(cls):
|
|
super(TestS3AAccess, cls).setup_class()
|
|
try:
|
|
tmp.write('echo badkey')
|
|
finally:
|
|
tmp.close()
|
|
# Make this file executable
|
|
tmp_file_stat = os.stat(BAD_KEY_FILE)
|
|
os.chmod(BAD_KEY_FILE, tmp_file_stat.st_mode | stat.S_IEXEC)
|
|
|
|
@classmethod
|
|
def teardown_class(cls):
|
|
os.remove(BAD_KEY_FILE)
|
|
|
|
def _get_impala_client(self):
|
|
impalad = self.cluster.get_any_impalad()
|
|
return impalad.service.create_beeswax_client()
|
|
|
|
@pytest.mark.execute_serially
|
|
@CustomClusterTestSuite.with_args(
|
|
"-s3a_access_key_cmd=\"%s\"\
|
|
-s3a_secret_key_cmd=\"%s\"" % (BAD_KEY_FILE, BAD_KEY_FILE))
|
|
def test_ddl_keys_ignored(self, unique_database):
|
|
'''DDL statements will ignore the S3 keys passed to Impala because the code path
|
|
that it exercises goes through the Hive Metastore which should have the correct keys
|
|
from the core-site configuration.'''
|
|
client = self._get_impala_client()
|
|
# This is repeated in the test below (because it's necessary there), but we still
|
|
# want to make sure that it is tested separately as it's a good test practice.
|
|
self.execute_query_expect_success(client,
|
|
"create external table if not exists {0}.tinytable_s3 like functional.tinytable \
|
|
location '{1}/tinytable'".format(unique_database, WAREHOUSE))
|
|
|
|
@pytest.mark.execute_serially
|
|
@CustomClusterTestSuite.with_args(
|
|
"-s3a_access_key_cmd=\"%s\"\
|
|
-s3a_secret_key_cmd=\"%s\"" % (BAD_KEY_FILE, BAD_KEY_FILE))
|
|
def test_keys_do_not_work(self, unique_database):
|
|
'''Test that using incorrect S3 access and secret keys will not allow Impala to
|
|
query S3.
|
|
TODO: We don't have the test infrastructure in place yet to check if the keys do work
|
|
in a custom cluster test. (See IMPALA-3422)'''
|
|
client = self._get_impala_client()
|
|
self.execute_query_expect_success(client,
|
|
"create external table if not exists {0}.tinytable_s3 like functional.tinytable \
|
|
location '{1}/tinytable'".format(unique_database, WAREHOUSE))
|
|
self.execute_query_expect_failure(client, "select * from {0}.tinytable_s3"
|
|
.format(unique_database))
|