Henry Robinson 8809567e82 IMPALA-2290: Fix btrim() thread-safety. ...

By not using THREAD_LOCAL for its state, btrim() invocations in
multi-threaded contexts (i.e. pushed to the scanner) would have threads
trampling over each other's bitset used to check for trimmed characters.

Testing:

See new test in expr.test:

select count(*) from functional.alltpyes where btrim(string_col, string_col) != ""

.. should give 0 results, but would give > 0 with this bug.

Change-Id: I595e25b1d4fb7c76b846fce837b4ec140f47d43c
Reviewed-on: http://gerrit.cloudera.org:8080/748
Reviewed-by: Henry Robinson <henry@cloudera.com>
Tested-by: Henry Robinson <henry@cloudera.com>

2015-09-09 04:15:30 +00:00

55 KiB

Raw Blame History

View Raw