jprdonnelly/nebula.js
1
0
Fork 0
mirror of https://github.com/qlik-oss/nebula.js.git synced 2025-12-19 17:58:43 -05:00
Code Issues Projects Releases Wiki Activity

fix: always padd title - to match change in sense-client

Browse Source
This commit is contained in:
Tobias Linsefors
2025-12-01 09:19:41 +01:00
parent f7bc948c24
commit 20c4a99fa0
2 changed files with 8 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
apis/nucleus/src/utils/__tests__/cell-padding.test.js
View File

@@ -172,7 +172,7 @@ describe('cell padding', () => {
subtitle: 'X', subtitle: 'X',
}); });
expect(bodyPadding).toBeUndefined(); expect(bodyPadding).toBeUndefined();
expect(titleStyles.main.padding).toBe('10px 0 0'); expect(titleStyles.main.padding).toBe('10px 10px 0');
expect(titleStyles.subTitle.padding).toBe('0'); expect(titleStyles.subTitle.padding).toBe('0 10px');
}); });
}); });

24
apis/nucleus/src/utils/cell-padding.js
View File

@@ -14,24 +14,12 @@ const NO_PADDING_IN_CARDS = [
'sn-tabbed-container', 'sn-tabbed-container',
]; ];
const getPaddTitle = (visualization) => NO_BORDER_IN_CARDS.indexOf(visualization) === -1; const getTitlePadding = () => '10px 10px 0';
const getSubtitlePadding = (showTitle) => {
const getTitlePadding = (visualization) => {
const paddTitle = getPaddTitle(visualization);
if (paddTitle) {
return '10px 10px 0';
}
return '10px 0 0';
};
const getSubtitlePadding = (visualization, showTitle) => {
const paddTitle = getPaddTitle(visualization);
if (showTitle) { if (showTitle) {
if (paddTitle) { return '0 10px';
return '0 10px';
}
return '0';
} }
return getTitlePadding(visualization); return getTitlePadding();
}; };
const getPadding = ({ layout, isError, isCardTheme, titleStyles, translator }) => { const getPadding = ({ layout, isError, isCardTheme, titleStyles, translator }) => {
@@ -46,11 +34,11 @@ const getPadding = ({ layout, isError, isCardTheme, titleStyles, translator }) =
if (showTitle) { if (showTitle) {
// eslint-disable-next-line no-param-reassign // eslint-disable-next-line no-param-reassign
titleStyles.main.padding = getTitlePadding(visualization); titleStyles.main.padding = getTitlePadding();
} }
if (showSubtitle) { if (showSubtitle) {
// eslint-disable-next-line no-param-reassign // eslint-disable-next-line no-param-reassign
titleStyles.subTitle.padding = getSubtitlePadding(visualization, showTitle); titleStyles.subTitle.padding = getSubtitlePadding(showTitle);
} }
if (showFootnote) { if (showFootnote) {
if (NO_BORDER_IN_CARDS.indexOf(visualization) === -1) { if (NO_BORDER_IN_CARDS.indexOf(visualization) === -1) {