jprdonnelly/nebula.js
1
0
Fork 0
mirror of https://github.com/qlik-oss/nebula.js.git synced 2025-12-19 09:48:18 -05:00
Code Issues Projects Releases Wiki Activity

refactor: put sorting and collapsed under another flag

Browse Source
This commit is contained in:
Jingjing
2025-12-17 13:55:47 +01:00
parent d5508ea96b
commit b573e78fb2
1 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
apis/nucleus/src/components/selections/SelectedFields.jsx
View File

@@ -67,6 +67,7 @@ export default function SelectedFields({ api, app, halo }) {
const [maxItems, setMaxItems] = useState(0);
const flags = halo.public.galaxy?.flags;
const isPinFieldEnabled = flags?.isEnabled('TLV_1394_PIN_FIELD_TO_TOOLBAR');
const isRefactoringEnabled = flags?.isEnabled('TTLV_1394_REFACTORING_SELECTIONS');
const [pinnedItems, setPinnedItems] = useState([]);
const [masterDimList, setMasterDimList] = useState([]);
const [fieldList, setFieldList] = useState([]);
@@ -113,7 +114,7 @@ export default function SelectedFields({ api, app, halo }) {
if (!app || !currentSelectionsModel || !layout || !maxItems) {
return;
}
let items = isPinFieldEnabled ? getItems(layout).sort(sortSelections) : getItems(layout);
let items = isRefactoringEnabled ? getItems(layout).sort(sortSelections) : getItems(layout);
if (isPinFieldEnabled) {
items = sortAllFields(fieldList, pinnedItems, items, masterDimList);
}
@@ -131,7 +132,7 @@ export default function SelectedFields({ api, app, halo }) {
}
let newMoreItems = [];
if (maxItems < newItems.length) {
if (isPinFieldEnabled) {
if (isRefactoringEnabled) {
newMoreItems = newItems.splice(0, newItems.length - maxItems);
} else {
newMoreItems = newItems.splice(maxItems - newItems.length);
@@ -156,7 +157,7 @@ export default function SelectedFields({ api, app, halo }) {
return (
<Grid ref={containerRef} container gap={0} wrap="nowrap" style={{ height: '100%' }}>
{isPinFieldEnabled && state.more.length > 0 && (
{isRefactoringEnabled && state.more.length > 0 && (
<Grid
item
style={{
@@ -189,7 +190,7 @@ export default function SelectedFields({ api, app, halo }) {
)}
</Grid>
))}
{!isPinFieldEnabled && state.more.length > 0 && (
{!isRefactoringEnabled && state.more.length > 0 && (
<Grid
item
style={{