jprdonnelly/nebula.js
1
0
Fork 0
mirror of https://github.com/qlik-oss/nebula.js.git synced 2025-12-25 01:04:14 -05:00
Code Issues Projects Releases Wiki Activity

chore: add error for incorrect load function (#591)

Browse Source
This commit is contained in:
Tobias Åström
2021-03-31 14:00:15 +02:00
committed by GitHub
parent 87a172bd88
commit bb6f647111
2 changed files with 13 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
apis/nucleus/src/sn/__tests__/load.spec.js
View File

@@ -13,6 +13,16 @@ describe('load', () => {
clearFromCache('pie');
});
it('should throw when load is not a function', async () => {
const loader = { then: {} }; // fake promise
try {
await load('pie', '1.0.0', halo, loader);
expect(0).to.equal(1);
} catch (e) {
expect(e.message).to.equal(`load of visualization 'pie v1.0.0' is not a fuction, wrap load promise in function`);
}
});
it('should throw when resolving to a falsy value', async () => {
const loader = () => false;
try {

3
apis/nucleus/src/sn/load.js
View File

@@ -12,6 +12,9 @@ export async function load(name, version, { config }, loader) {
const key = `${name}__${version}`;
if (!LOADED[key]) {
const sKey = `${name}${(version && ` v${version}`) || ''}`;
if (loader && typeof loader !== 'function') {
throw new Error(`load of visualization '${sKey}' is not a fuction, wrap load promise in function`);
}
const p = (loader || config.load)({
name,
version,