jprdonnelly/nebula.js
1
0
Fork 0
mirror of https://github.com/qlik-oss/nebula.js.git synced 2026-05-26 22:00:24 -04:00
Code Issues Projects Releases Wiki Activity

fix: wrap in square brackets if needed (#1171)

Browse Source
This commit is contained in:
Tobias Linsefors
2023-03-21 15:03:45 +01:00
committed by GitHub
parent 48736a8684
commit f49e4e2ec3
2 changed files with 13 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
apis/nucleus/src/components/listbox/utils/__tests__/frequencyMaxUtil.test.jsx Normal file
View File

@@ -0,0 +1,9 @@
import { getFrequencyMaxExpression } from '../frequencyMaxUtil';
describe('frequencyMaxUtil - getFrequencyMaxExpression', () => {
test('should create correct expression and wrap and escape field if needed', async () => {
const result = getFrequencyMaxExpression('dimension with ] in it');
expect(result).toEqual('Max(AGGR(Count([dimension with ]] in it]), [dimension with ]] in it]))');
});
});

5
apis/nucleus/src/components/listbox/utils/frequencyMaxUtil.js
View File

@@ -2,7 +2,10 @@ const escapeField = (field) => {
if (!field) {
return field;
}
return `${field.replace(/\]/g, ']]')}`;
if (/^[A-Za-z][A-Za-z0-9_]*$/.test(field)) {
return field;
}
return `[${field.replace(/\]/g, ']]')}]`;
};
export const needToFetchFrequencyMax = (layout) => layout?.frequencyMax === 'fetch';