jprdonnelly/redash
1
0
Fork 0
mirror of https://github.com/getredash/redash.git synced 2026-05-13 16:01:20 -04:00
Code Issues Projects Releases Wiki Activity

Fix warning test query (#6335)

Browse Source 
* replace assertDictContainsSubset -> asserLessEqual

* refactor definition set
This commit is contained in:
Konstantin Smirnov
2023-08-01 15:57:22 +05:00
committed by GitHub
parent 1726aef0fc
commit 196bfece30
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
tests/handlers/test_queries.py
View File

@@ -231,7 +231,7 @@ class TestQueryListResourceGet(BaseTestCase):
rv = self.make_request("get", "/api/queries")
assert len(rv.json["results"]) == 3
assert set([result["id"] for result in rv.json["results"]]) == set([q1.id, q2.id, q3.id])
assert set([result["id"] for result in rv.json["results"]]) == {q1.id, q2.id, q3.id}
def test_filters_with_tags(self):
q1 = self.factory.create_query(tags=["test"])
@@ -240,7 +240,7 @@ class TestQueryListResourceGet(BaseTestCase):
rv = self.make_request("get", "/api/queries?tags=test")
assert len(rv.json["results"]) == 1
assert set([result["id"] for result in rv.json["results"]]) == set([q1.id])
assert set([result["id"] for result in rv.json["results"]]) == {q1.id}
def test_search_term(self):
q1 = self.factory.create_query(name="Sales")
@@ -249,7 +249,7 @@ class TestQueryListResourceGet(BaseTestCase):
rv = self.make_request("get", "/api/queries?q=sales")
assert len(rv.json["results"]) == 2
assert set([result["id"] for result in rv.json["results"]]) == set([q1.id, q2.id])
assert set([result["id"] for result in rv.json["results"]]) == {q1.id, q2.id}
class TestQueryListResourcePost(BaseTestCase):
@@ -264,7 +264,7 @@ class TestQueryListResourcePost(BaseTestCase):
rv = self.make_request("post", "/api/queries", data=query_data)
self.assertEqual(rv.status_code, 200)
self.assertDictContainsSubset(query_data, rv.json)
self.assertLessEqual(query_data.items(), rv.json.items())
self.assertEqual(rv.json["user"]["id"], self.factory.user.id)
self.assertIsNotNone(rv.json["api_key"])
self.assertIsNotNone(rv.json["query_hash"])
@@ -335,7 +335,7 @@ class TestQueryArchiveResourceGet(BaseTestCase):
rv = self.make_request("get", "/api/queries/archive")
assert len(rv.json["results"]) == 2
assert set([result["id"] for result in rv.json["results"]]) == set([q1.id, q2.id])
assert set([result["id"] for result in rv.json["results"]]) == {q1.id, q2.id}
def test_search_term(self):
q1 = self.factory.create_query(name="Sales", is_archived=True)
@@ -344,7 +344,7 @@ class TestQueryArchiveResourceGet(BaseTestCase):
rv = self.make_request("get", "/api/queries/archive?q=sales")
assert len(rv.json["results"]) == 2
assert set([result["id"] for result in rv.json["results"]]) == set([q1.id, q2.id])
assert set([result["id"] for result in rv.json["results"]]) == {q1.id, q2.id}
class QueryRefreshTest(BaseTestCase):