jprdonnelly/redash
1
0
Fork 0
mirror of https://github.com/getredash/redash.git synced 2025-12-25 01:03:20 -05:00
Code Issues Projects Releases Wiki Activity

Merge pull request #1819 from getredash/patches

Browse Source 
Fix: form component was inserting empty values
This commit is contained in:
Arik Fraimovich
2017-06-13 09:41:24 +03:00
committed by GitHub
parent d30f4f155a ef2eaf1fa9
commit 229c33939c
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
client/app/components/dynamic-form.js
View File

@@ -1,4 +1,4 @@
import { each, contains, find } from 'underscore';
import { isUndefined, each, contains, find } from 'underscore';
import endsWith from 'underscore.string/endsWith';
import template from './dynamic-form.html';
@@ -115,8 +115,9 @@ function DynamicForm($http, toastr, $q) {
if (Object.keys($scope.target.options).length === 0) {
const properties = type.configuration_schema.properties;
Object.keys(properties).forEach((property) => {
$scope.target.options[property] =
properties[property].default || '';
if (!isUndefined(properties[property].default)) {
$scope.target.options[property] = properties[property].default;
}
});
}
}