Fixes issue where network failures during plugin install was returning 0 exit code. Closes #3367

cmd/plugin.go

@@ -237,6 +237,8 @@ func runPluginInstallCmd(cmd *cobra.Command, args []string) {
 		installReports = append(installReports, report)
 		if !report.Skipped {
 			installCount++
+		} else {
+			exitCode = constants.ExitCodePluginInstallFailure
 		}
 	}
 

pkg/constants/exit_codes.go

@@ -7,6 +7,7 @@ const (
 	ExitCodePluginLoadingError          = 11  // plugin - loading error
 	ExitCodePluginListFailure           = 12  // plugin - listing failed
 	ExitCodePluginNotFound              = 13  // plugin - not found
+	ExitCodePluginInstallFailure        = 14  // plugin - install failed
 	ExitCodeSnapshotCreationFailed      = 21  // snapshot - creation failed
 	ExitCodeSnapshotUploadFailed        = 22  // snapshot - upload failed
 	ExitCodeServiceSetupFailure         = 31  // service - setup failed

tests/acceptance/test_files/service_and_plugin.bats

@@ -88,13 +88,10 @@ load "$LIB_BATS_SUPPORT/load.bash"
   rm -rf $target_install_directory
 }
 
-@test "start service, install plugin and query" {
+@test "start service and query" {
   # start service
   steampipe service start
 
-  # install plugin
-  steampipe plugin install chaos
-
   # query the plugin
   run steampipe query "select time_col from chaos_cache_check limit 1"
   # check if the query passes