jprdonnelly/steampipe
1
0
Fork 0
mirror of https://github.com/turbot/steampipe.git synced 2025-12-19 09:58:53 -05:00
Code Issues Packages Projects Releases Wiki Activity

Update plugin installation logic to skip configuration during plugin updates (#4630)

Browse Source
This commit is contained in:
Priyanka Chatterjee
2025-08-18 13:09:32 +05:30
committed by GitHub
parent d5de83fa1c
commit 8af0f0af88
1 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
cmd/plugin.go
View File

@@ -161,7 +161,6 @@ Examples:
AddBoolFlag(pconstants.ArgAll, false, "Update all plugins to its latest available version").
AddBoolFlag(pconstants.ArgProgress, true, "Display installation progress").
AddBoolFlag(pconstants.ArgHelp, false, "Help for plugin update", cmdconfig.FlagOptions.WithShortHand("h"))
return cmd
}
@@ -594,8 +593,14 @@ func installPlugin(ctx context.Context, resolvedPlugin pplugin.ResolvedPluginVer
bar.Incr()
}
}()
skipConfig := viper.GetBool(pconstants.ArgSkipConfig)
// we should never install the config file for plugin updates; config files should only be installed during plugin install
if isUpdate {
skipConfig = true
}
image, err := plugin.Install(ctx, resolvedPlugin, progress, constants.BaseImageRef, ociinstaller.SteampipeMediaTypeProvider{}, putils.WithSkipConfig(viper.GetBool(pconstants.ArgSkipConfig)))
image, err := plugin.Install(ctx, resolvedPlugin, progress, constants.BaseImageRef, ociinstaller.SteampipeMediaTypeProvider{}, putils.WithSkipConfig(skipConfig))
if err != nil {
msg := ""
// used to build data for the plugin install report to be used for display purposes