jprdonnelly/steampipe
1
0
Fork 0
mirror of https://github.com/turbot/steampipe.git synced 2026-02-22 14:00:14 -05:00
Code Issues Packages Projects Releases Wiki Activity

Dashboard UI hrefs should be disabled in snapshot mode. Closes #2311.

Browse Source
This commit is contained in:
Mike Burgess
2022-08-09 10:15:59 +01:00
parent e4d1b72754
commit d86c76fdd1
2 changed files with 15 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
ui/dashboard/src/components/dashboards/Card/index.tsx
View File

@@ -167,6 +167,7 @@ const Label = ({ value }) => {
const Card = (props: CardProps) => {
const {
components: { ExternalLink },
dataMode,
} = useDashboard();
const state = useCardState(props);
const [renderError, setRenderError] = useState<string | null>(null);
@@ -184,14 +185,17 @@ const Card = (props: CardProps) => {
}, [setZoomIconClassName, textClasses]);
useEffect(() => {
if ((state.loading || !state.href) && (renderError || renderedHref)) {
if (
dataMode === "snapshot" ||
((state.loading || !state.href) && (renderError || renderedHref))
) {
setRenderError(null);
setRenderedHref(null);
}
}, [state.loading, state.href, renderError, renderedHref]);
}, [dataMode, state.loading, state.href, renderError, renderedHref]);
useDeepCompareEffect(() => {
if (state.loading || !state.href) {
if (dataMode === "snapshot" || state.loading || !state.href) {
return;
}
// const { label, loading, value, ...rest } = state;
@@ -226,7 +230,7 @@ const Card = (props: CardProps) => {
}
};
doRender();
}, [state, props.data]);
}, [dataMode, state, props.data]);
const card = (
<div
@@ -299,7 +303,7 @@ const Card = (props: CardProps) => {
</div>
);
if (renderedHref) {
if (dataMode === "live" && renderedHref) {
return (
<ExternalLink className="" to={renderedHref}>
{card}

10
ui/dashboard/src/components/dashboards/Table/index.tsx
View File

@@ -366,6 +366,7 @@ const TableView = ({
hasTopBorder = false,
}) => {
const {
dataMode,
themeContext: { theme },
} = useDashboard();
const [rowTemplateData, setRowTemplateData] = useState<RowRenderResult[]>([]);
@@ -395,13 +396,13 @@ const TableView = ({
setRowTemplateData(renderedResults);
};
if (columns.length === 0 || rows.length === 0) {
if (dataMode === "snapshot" || columns.length === 0 || rows.length === 0) {
setRowTemplateData([]);
return;
}
doRender();
}, [columns, rows]);
}, [dataMode, columns, rows]);
return (
<>
@@ -519,6 +520,7 @@ const TableViewWrapper = (props: TableProps) => {
};
const LineView = (props: TableProps) => {
const { dataMode } = useDashboard();
const [columns, setColumns] = useState<TableColumnInfo[]>([]);
const [rows, setRows] = useState<LeafNodeDataRow[]>([]);
const [rowTemplateData, setRowTemplateData] = useState<RowRenderResult[]>([]);
@@ -574,13 +576,13 @@ const LineView = (props: TableProps) => {
setRowTemplateData(renderedResults);
};
if (columns.length === 0 || rows.length === 0) {
if (dataMode === "snapshot" || columns.length === 0 || rows.length === 0) {
setRowTemplateData([]);
return;
}
doRender();
}, [columns, rows]);
}, [dataMode, columns, rows]);
if (columns.length === 0 || rows.length === 0) {
return null;