jprdonnelly/steampipe
1
0
Fork 0
mirror of https://github.com/turbot/steampipe.git synced 2025-12-19 18:12:43 -05:00
Code Issues Packages Projects Releases Wiki Activity
3,483 Commits 244 Branches 488 Tags
fix-4820-postgres-exit
Commit Graph

3483 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Nathan Wallace
b0de69f26e Fix compilation errors in test 
Fixed type errors:
- Changed return type from *os.ProcessState to *exec.Cmd
- Added exec import
- Implemented basic process creation and cleanup helpers
- Removed unused time import

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
 2025-11-12 01:04:35 +08:00
Nathan Wallace
4963d566aa Fix #4820: Ensure all three postgres exit steps are attempted 
Fixed bug where SendSignal errors could prevent subsequent shutdown
attempts from being executed. The function now:

1. Attempts all three signal levels (SIGTERM, SIGINT, SIGQUIT) even if
   earlier SendSignal calls fail
2. Logs warnings when signals cannot be sent instead of returning early
3. Collects signal errors and includes them in the final timeout error
4. Adds clearer step-by-step comments documenting each shutdown phase
5. Improves error messages to indicate all three attempts were made

This ensures the complete three-step shutdown sequence always executes,
giving the process maximum opportunity to exit gracefully before
reporting failure.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
 2025-11-11 23:33:47 +08:00
Nathan Wallace
1f4f26bf09 Add test for #4820: Three-step postgres exit may not complete 
Added test suite for doThreeStepPostgresExit function including:
- TestDoThreeStepPostgresExit_Success: Tests happy path with SIGTERM
- TestDoThreeStepPostgresExit_NeedsSIGINT: Tests fallback to SIGINT
- TestDoThreeStepPostgresExit_NeedsSIGQUIT: Tests fallback to SIGQUIT
- TestDoThreeStepPostgresExit_Timeout: Tests bug where all signals fail (skipped)

The timeout test is skipped and demonstrates the bug where a completely
hung postgres process that ignores all signals will cause a resource leak.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
 2025-11-11 23:30:50 +08:00
dependabot[bot]
4e84c29348 [dep][actions](deps): Bump golangci/golangci-lint-action (#4766) 2025-11-11 19:26:16 +08:00
Nathan Wallace
5c11d66574 Fix #4699: Add bounds check to isValidDatabaseName (#4733) 2025-11-11 19:25:44 +08:00
Nathan Wallace
5e1d316759 Fix #4710: Return empty slice instead of nil in getTableAndConnectionSuggestions (#4734) 2025-11-11 19:25:03 +08:00
Nathan Wallace
8baad08f41 Fix #4718: Use atomic write to prevent partial files (#4740) 2025-11-11 19:06:13 +08:00
Nathan Wallace
688e711419 Add AI development documentation and guidelines (#4777) 2025-11-11 19:03:27 +08:00
Nathan Wallace
a7cb5caa02 Fix #4715: Add mutex protection to export.Manager (#4738) 2025-11-11 18:54:52 +08:00
Nathan Wallace
7996d3c878 Fix #4712: Make Result.Close() idempotent (#4741) 2025-11-11 18:53:18 +08:00
Nathan Wallace
99fd81ccf6 Fix memory leak in DatabaseSession management (issue #3737) (#4742) 2025-11-11 18:35:16 +08:00
Nathan Wallace
6ebc0e5040 Fix #4744: Race condition on spinner.Suffix field (#4772) 2025-11-11 18:01:56 +08:00
Nathan Wallace
da0c9ddc0e Fix #4750: Nil pointer panic in RegisterExporters (#4769) 2025-11-11 17:58:06 +08:00
Nathan Wallace
28fb1d5237 Fix #4767: GetDbClient error handling (#4770) 2025-11-11 17:54:56 +08:00
Nathan Wallace
1472e96e74 Fix #4748: SQL injection vulnerability in GetSetConnectionStateSql (#4773) 2025-11-11 17:39:46 +08:00
Nathan Wallace
ca32de335c Fix #4757: Race condition in exemplarSchemaMap (#4774) 2025-11-11 17:31:58 +08:00
Nathan Wallace
aa696c9da3 Fix #4756: Race condition in Viper global state (#4775) 2025-11-11 17:29:59 +08:00
Nathan Wallace
13a24f840f Fix #4768: Goroutine leak in snapshot (#4776) 2025-11-11 17:26:33 +08:00
Nathan Wallace
4281ad3f10 Add comprehensive tests for pkg/{task,snapshot,cmdconfig,statushooks,introspection,initialisation,ociinstaller} (#4765) 2025-11-11 17:02:49 +08:00
Puskar Basu
d943ddd23a Merge branch 'v2.3.x' into develop (#4694) 2025-11-03 14:51:09 +05:30
Puskar Basu
b41fbe31d9 v2.3.2 v2.3.2 2025-11-03 14:21:51 +05:30
Puskar Basu
603ae82e6e Fix glibc errors in linux builds (#4692) 2025-11-03 13:49:19 +05:30
Puskar Basu
248a1f4936 Merge branch 'v2.3.x' into develop 2025-10-31 17:19:23 +05:30
Puskar Basu
119d7dd315 v2.3.1 v2.3.1 2025-10-31 16:36:45 +05:30
Puskar Basu
6367945009 Fix issue where macOS binaries failed to run due to absolute openssl paths and too-new min OS (#4687) 2025-10-31 16:20:33 +05:30
Puskar Basu
c69748b6be Merge branch 'v2.3.x' into develop 2025-10-30 15:43:20 +05:30
Puskar Basu
bc1003bebf v2.3.0 v2.3.0 2025-10-30 15:01:16 +05:30
Puskar Basu
9aac94322c Improve table truncation message for datasets exceeding 10k rows, show the same message in batch queries as well (#4675) 2025-10-30 13:47:07 +05:30
dependabot[bot]
d7289b85fd [dep][go](deps): Bump github.com/jackc/pgx/v5 from 5.7.3 to 5.7.6 (#4660) 2025-10-30 11:55:15 +05:30
dependabot[bot]
4fad14407b [dep][go](deps): Bump github.com/hashicorp/go-plugin from 1.6.3 to 1.7.0 (#4662) 2025-10-30 11:54:53 +05:30
dependabot[bot]
df135bf1f9 [dep][go](deps): Bump github.com/spf13/cobra from 1.9.1 to 1.10.1 (#4659) 2025-10-30 11:42:43 +05:30
dependabot[bot]
4b51cd8efc [dep][actions](deps): Bump actions/setup-go from 5.5.0 to 6.0.0 (#4663) 2025-10-30 11:41:43 +05:30
dependabot[bot]
b04eaa8e43 [dep][actions](deps): Bump actions/cache from 4.2.4 to 4.3.0 (#4664) 2025-10-30 11:41:22 +05:30
dependabot[bot]
f397a47a24 [dep][actions](deps): Bump actions/checkout from 4.2.2 to 5.0.0 (#4666) 2025-10-30 11:41:02 +05:30
dependabot[bot]
1e3253a9c8 [dep][actions](deps): Bump docker/login-action from 3.5.0 to 3.6.0 (#4667) 2025-10-30 11:40:39 +05:30
dependabot[bot]
d7c380ffc1 [dep][actions](deps): Bump actions/stale from 9.1.0 to 10.1.0 (#4669) 2025-10-30 11:40:18 +05:30
dependabot[bot]
856cbce572 [dep][go](deps): Bump github.com/jedib0t/go-pretty/v6 (#4672) 2025-10-30 11:39:57 +05:30
Puskar Basu
2fa696b2db Update embedded postgresql version to 14.19 (#4671) 2025-10-29 22:00:25 +05:30
kaidaguerre
294421c707 Merge pull request #4655 from turbot/v2.2.x 
Merge branch 'v2.2.x' into develop
 2025-09-24 13:39:17 +01:00
Puskar Basu
71017322e2 update changelog v2.2.0 2025-09-24 16:31:36 +05:30
Puskar Basu
2262010347 v2.2.0 v2.2.0 2025-09-24 15:25:35 +05:30
Puskar Basu
1670b1b264 FDW v2.1.3 2025-09-24 13:01:48 +05:30
Puskar Basu
36d28b9dd3 Update pipe-fittings and steampipe-plugin-sdk 2025-09-24 13:01:19 +05:30
dependabot[bot]
4975b87ddc [dep][go](deps): Bump github.com/Masterminds/semver/v3 (#4601) v2.2.0-rc.0 2025-09-24 11:55:00 +05:30
dependabot[bot]
eac9e6be90 [dep][go](deps): Bump github.com/hashicorp/hcl/v2 from 2.23.0 to 2.24.0 (#4606) 2025-09-24 11:54:34 +05:30
dependabot[bot]
0239b5faeb [dep][actions](deps): Bump docker/login-action from 3.4.0 to 3.5.0 (#4627) 2025-09-24 11:53:26 +05:30
dependabot[bot]
5da1d5cf16 [dep][actions](deps): Bump actions/download-artifact from 4.3.0 to 5.0.0 (#4631) 2025-09-24 11:51:10 +05:30
dependabot[bot]
715af8af30 [dep][actions](deps): Bump actions/cache from 4.2.3 to 4.2.4 (#4634) 2025-09-24 11:50:47 +05:30
dependabot[bot]
4fa19b7010 [dep][actions](deps): Bump goreleaser/goreleaser-action (#4637) 2025-09-24 11:49:37 +05:30
dependabot[bot]
2fb191102b [dep][go](deps): Bump github.com/hashicorp/go-getter from 1.7.8 to 1.7.9 (#4641) 2025-09-24 11:49:11 +05:30