Nathan Wallace a4d90c3ac9 Fix logic error in IdentifyMissingComments closes #4814 (#4872) ...

* Add test for #4814: Logic error in IdentifyMissingComments

Demonstrates the bug where the function uses OR (||) instead of AND (&&)
on line 426, causing connections being deleted to be incorrectly added
to MissingComments.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

* Fix #4814: Change OR to AND in IdentifyMissingComments logic

Corrects the logic error on line 426 where OR (||) was incorrectly used
instead of AND (&&). The condition should be "if NOT updating AND NOT
deleting" to properly exclude connections being updated or deleted from
the MissingComments list.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

---------

Co-authored-by: Claude <noreply@anthropic.com>

2025-11-15 08:10:53 -05:00

..

testdata

Accept both sp and pp files as mod data extension . Closes#4089

2024-01-26 14:46:30 +00:00

connection_plugin.go

chore: update module to v2 and bump Go version to 1.24 (#4597)

2025-07-07 16:03:56 +05:30

connection_schemas.go

chore: update module to v2 and bump Go version to 1.24 (#4597)

2025-07-07 16:03:56 +05:30

connection_state_map_test.go

Add comprehensive passing tests from bug hunting initiative (#4864)

2025-11-13 09:26:46 +08:00

connection_state_map.go

chore: update module to v2 and bump Go version to 1.24 (#4597)

2025-07-07 16:03:56 +05:30

connection_state.go

chore: update module to v2 and bump Go version to 1.24 (#4597)

2025-07-07 16:03:56 +05:30

connection_test.go

Add comprehensive passing tests from bug hunting initiative (#4864)

2025-11-13 09:26:46 +08:00

connection_updates_opts.go

Add support to retrieve plugin rate limiter definitions and use to populate steampipe_rate_limiter table. Closes #3805 (#3803)

2023-09-06 13:28:22 +01:00

connection_updates_test.go

Fix logic error in IdentifyMissingComments closes #4814 (#4872)

2025-11-15 08:10:53 -05:00

connection_updates_validate.go

Upgrade to pipe-fittings v2, go-kit v1 (#4485)

2025-03-06 16:34:18 +05:30

connection_updates.go

Fix logic error in IdentifyMissingComments closes #4814 (#4872)

2025-11-15 08:10:53 -05:00

dependency_path.go

Support resolution of variables for transitive dependencies using parent mod 'args' property

2023-06-09 16:22:09 +01:00

load_config_test.go

Fix 'unused' linting errors

2025-06-17 12:20:12 +05:30

load_config.go

chore: update module to v2 and bump Go version to 1.24 (#4597)

2025-07-07 16:03:56 +05:30

load_connection_state_option.go

Execute RefreshConnections asyncronously and optimise for high connection count. Add connection_state table.

2023-05-10 09:05:08 +01:00

load_connection_state.go

chore: update module to v2 and bump Go version to 1.24 (#4597)

2025-07-07 16:03:56 +05:30

postgres_notification.go

Upgrade to pipe-fittings v2, go-kit v1 (#4485)

2025-03-06 16:34:18 +05:30

refresh_connections_result.go

Upgrade to pipe-fittings v2, go-kit v1 (#4485)

2025-03-06 16:34:18 +05:30

shared_test.go

Upgrade to pipe-fittings v2, go-kit v1 (#4485)

2025-03-06 16:34:18 +05:30

steampipeconfig.go

chore: update module to v2 and bump Go version to 1.24 (#4597)

2025-07-07 16:03:56 +05:30

validate.go

chore: update module to v2 and bump Go version to 1.24 (#4597)

2025-07-07 16:03:56 +05:30

validation_failure_test.go

Add comprehensive passing tests from bug hunting initiative (#4864)

2025-11-13 09:26:46 +08:00

validation_failure.go

Refactor/fix connection and plugin validation during refreshConnections - ensure failed connections are set to 'error' in connection state. Closes #3432

2023-05-17 14:43:27 +01:00