fix(TPS-3950): update release note

* Fix multivalue body mail part processing

PATCH_RELEASE_NOTE.md

@@ -0,0 +1,68 @@
+---
+version: 7.0.1
+module: https://talend.poolparty.biz/coretaxonomy/42
+product:
+- https://talend.poolparty.biz/coretaxonomy/23
+---
+
+# TPS-3950
+
+| Info             | Value |
+| ---------------- | ---------------- |
+| Patch Name       | Patch\_20200427\_TPS-3950\_v1-7.0.1 |
+| Release Date     | 2020-04-27 |
+| Target Version   | 20180411\_1414-V7.0.1 |
+| Product affected | Talend Studio |
+
+## Introduction
+
+This is a self-contained patch.
+
+**NOTE**: For information on how to obtain this patch, reach out to your Support contact at Talend.
+
+## Fixed issues
+
+This patch contains the following fixes:
+
+- TPS-3950 [7.0.1.] tfileinputmail will not process inline image (TDI-42549) (TDI-42634)
+
+## Prerequisites
+
+Consider the following requirements for your system:
+
+- Talend Studio 7.0.1 must be installed.
+
+
+## Installation
+
+### Installing the patch using Software update
+
+1) Logon TAC and switch to Configuration->Software Update, then enter the correct values and save referring to the documentation: https://help.talend.com/reader/f7Em9WV_cPm2RRywucSN0Q/j9x5iXV~vyxMlUafnDejaQ
+
+2) Switch to Software update page, where the new patch will be listed. The patch can be downloaded from here into the nexus repository.
+
+3) On Studio Side: Logon Studio with remote mode, on the logon page the Update button is displayed: click this button to install the patch.
+
+### Installing the patch using Talend Studio
+
+1) Create a folder named "patches" under your studio installer directory and copy the patch .zip file to this folder.
+
+2) Restart your studio: a window pops up, then click OK to install the patch, or restart the commandline and the patch will be installed automatically.
+
+### Installing the patch using Commandline
+
+Execute the following commands:
+
+1. Talend-Studio-win-x86_64.exe -nosplash -application org.talend.commandline.CommandLine -consoleLog -data commandline-workspace startServer -p 8002 --talendDebug
+2. initRemote {tac_url} -ul {TAC login username} -up {TAC login password}
+3. checkAndUpdate -tu {TAC login username} -tup {TAC login password}
+
+## Uninstallation
+Backup the Affected files list below. Uninstall the patch by restore the backup files.
+
+## Affected files for this patch
+
+The following files are installed by this patch:
+
+- {Talend\_Studio\_path}/plugins/org.talend.designer.components.localprovider\_7.0.1.20180411\_1414/components/tFileInputMail/tFileInputMail\_begin.javajet
+- {Talend\_Studio\_path}/plugins/org.talend.designer.components.localprovider\_7.0.1.20180411\_1414/components/tFileInputMail/tFileInputMail\_MIME.javajet

main/plugins/org.talend.designer.components.localprovider/components/tFileInputMail/tFileInputMail_MIME.javajet

@@ -66,25 +66,28 @@
 			}
 		}
 		DecodeString_<%=cid%> decode_<%=cid%> = new DecodeString_<%=cid%>();
+
 		try{
 			fileInput<%=cid%> = new java.io.FileInputStream(<%=filename %>);
 			javax.mail.Session session_<%=cid %> = javax.mail.Session.getInstance(System.getProperties(), null);
-		    javax.mail.internet.MimeMessage msg_<%=cid %> = new javax.mail.internet.MimeMessage(session_<%=cid %>, fileInput<%=cid%>);
+			javax.mail.internet.MimeMessage msg_<%=cid %> = new javax.mail.internet.MimeMessage(session_<%=cid %>, fileInput<%=cid%>);
 			java.util.List<String> list_<%=cid %> = new java.util.ArrayList<String>();
-		
-			for (int i_<%=cid %> =0;i_<%=cid %> < mailParts_<%=cid %>.length;i_<%=cid %>++) {				
-			String part_<%=cid %> = mailParts_<%=cid %>[i_<%=cid %>];
-	       	String sep_<%=cid%>= mailSeparator_<%=cid %>[i_<%=cid %>];
-		        if(part_<%=cid %>.equalsIgnoreCase("body")) {        
+
+			for (int i_<%=cid %> = 0; i_<%=cid %> < mailParts_<%=cid %>.length; i_<%=cid %>++) {
+				String part_<%=cid %> = mailParts_<%=cid %>[i_<%=cid %>];
+				String sep_<%=cid%>= mailSeparator_<%=cid %>[i_<%=cid %>];
+				if(part_<%=cid %>.equalsIgnoreCase("body")) {
+					boolean multiValueBody_<%=cid%> = ("true").equals(mailChecked_<%=cid %>[i_<%=cid%>]);
 					if(msg_<%=cid %>.isMimeType("multipart/*")) {
 						javax.mail.Multipart mp<%=cid%> = (javax.mail.Multipart) msg_<%=cid %>.getContent();
-	             		for (int i = 0; i < mp<%=cid%>.getCount(); i++) {
-	                 		javax.mail.BodyPart mpart<%=cid%> = mp<%=cid%>.getBodyPart(i);
-	                 		String disposition<%=cid%> = mpart<%=cid%>.getDisposition();
-	                 		if (!((disposition<%=cid%> != null) && ((disposition<%=cid%>
-	                            .equals(javax.mail.Part.ATTACHMENT)) || (disposition<%=cid%>.equals(javax.mail.Part.INLINE))))) {   
-	                    		// the following extract the body part(text/plain + text/html)
-	                    		try{
+						StringBuilder body_<%=cid %> = new StringBuilder();
+						for (int i = 0; i < mp<%=cid%>.getCount(); i++) {
+							javax.mail.BodyPart mpart<%=cid%> = mp<%=cid%>.getBodyPart(i);
+							String disposition<%=cid%> = mpart<%=cid%>.getDisposition();
+							if (!((disposition<%=cid%> != null) && ((disposition<%=cid%>
+								.equals(javax.mail.Part.ATTACHMENT)) || (disposition<%=cid%>.equals(javax.mail.Part.INLINE))))) {
+								// the following extract the body part(text/plain + text/html)
+								try{
 									Object content_<%=cid %> = mpart<%=cid %>.getContent();
 									if (content_<%=cid %> instanceof javax.mail.internet.MimeMultipart) {
 										javax.mail.internet.MimeMultipart mimeMultipart_<%=cid %> = (javax.mail.internet.MimeMultipart) content_<%=cid %>;
@@ -99,130 +102,152 @@
 												for(int j_<%=cid %>_body = 0; j_<%=cid %>_body < mimeMultipart_<%=cid %>_body.getCount(); j_<%=cid %>_body++){
 													javax.mail.BodyPart bodyPart_<%=cid %>_body = mimeMultipart_<%=cid %>_body.getBodyPart(j_<%=cid %>_body);
 													if (bodyPart_<%=cid %>_body.isMimeType("text/*")) {
-														list_<%=cid %>.add(bodyPart_<%=cid %>_body.getContent().toString());
+														if(multiValueBody_<%=cid%>) {
+															body_<%=cid %>.append(bodyPart_<%=cid %>_body.getContent().toString()).append(sep_<%=cid%>);
+														} else {
+															list_<%=cid %>.add(bodyPart_<%=cid %>_body.getContent().toString());
+														}
 													} else {
 														System.out.println("Ignore the part " + bodyPart_<%=cid %>_body.getContentType());
 													}
 												}
 											}else{
 												if (bodyPart_<%=cid %>.isMimeType("text/*")) {
-													list_<%=cid %>.add(bodyPart_<%=cid %>.getContent().toString());
+													if(multiValueBody_<%=cid%>) {
+														body_<%=cid %>.append(bodyPart_<%=cid %>.getContent().toString()).append(sep_<%=cid%>);
+													} else {
+														list_<%=cid %>.add(bodyPart_<%=cid %>.getContent().toString());
+													}
 												} else {
 													System.out.println("Ignore the part " + bodyPart_<%=cid %>.getContentType());
 												}
 											}
 										}
 									} else {    
-										list_<%=cid %>.add(mpart<%=cid%>.getContent().toString());
+										if(multiValueBody_<%=cid%>) {
+											body_<%=cid %>.append(mpart<%=cid%>.getContent().toString()).append(sep_<%=cid%>);
+										} else {
+											list_<%=cid %>.add(mpart<%=cid%>.getContent().toString());
+										}
 									}    
 								}catch (java.io.UnsupportedEncodingException e){
 									java.io.ByteArrayOutputStream bao_<%=cid%> = new java.io.ByteArrayOutputStream();
 									mpart<%=cid %>.writeTo(bao_<%=cid%>);
-									list_<%=cid %>.add(bao_<%=cid%>.toString());
+									if(multiValueBody_<%=cid%>) {
+										body_<%=cid %>.append(bao_<%=cid%>.toString()).append(sep_<%=cid%>);
+									} else {
+										list_<%=cid %>.add(bao_<%=cid%>.toString());
+									}
 									<%if(isLog4jEnabled){%>
 										log.warn("<%=cid%> - " + bao_<%=cid%>.toString());
 									<%}%>
 								}
 								<%
-				 				//both attachment and message context in the email,bug TDI-19065
+								//both attachment and message context in the email,bug TDI-19065
 								%>
 							}else if(disposition<%=cid%> != null && disposition<%=cid%>.equals(javax.mail.Part.INLINE)){
-								list_<%=cid %>.add(mpart<%=cid%>.getContent().toString());
-					 		}
+								if(multiValueBody_<%=cid%>) {
+									body_<%=cid %>.append(mpart<%=cid%>.getContent().toString()).append(sep_<%=cid%>);
+								} else {
+									list_<%=cid %>.add(mpart<%=cid%>.getContent().toString());
+								}
+							}
+						}
+						if(multiValueBody_<%=cid%>) {
+							list_<%=cid %>.add(body_<%=cid %>.toString());
 						}
 					} else {
 						java.io.InputStream in_<%=cid %> = msg_<%=cid %>.getInputStream();
-	     		    	byte[] buffer_<%=cid %> = new byte[1024];
-		     		    int length_<%=cid %> = 0;
-		     		    java.io.ByteArrayOutputStream baos_<%=cid %> =  new java.io.ByteArrayOutputStream();
-		     		    while ((length_<%=cid %> = in_<%=cid %>.read(buffer_<%=cid %>, 0, 1024)) != -1) {
-		     		        baos_<%=cid %>.write(buffer_<%=cid %>, 0, length_<%=cid %>);
-		     		    }
-		     		    String contentType_<%=cid%> = msg_<%=cid%>.getContentType();
-		     		    String charsetName_<%=cid%> = "";
-		     		    if(contentType_<%=cid%>!=null && contentType_<%=cid%>.trim().length()>0){
-		     		    	javax.mail.internet.ContentType cy_<%=cid%>  = new javax.mail.internet.ContentType(contentType_<%=cid%>);
-		     		    	charsetName_<%=cid%> = cy_<%=cid%>.getParameter("charset");
-		     		    }
-		     		    if(charsetName_<%=cid%>!=null && charsetName_<%=cid%>.length()>0){
-		     		    	list_<%=cid %>.add(baos_<%=cid %>.toString(charsetName_<%=cid%>));
-		     		    }else{
-		     		    	list_<%=cid %>.add(baos_<%=cid %>.toString());
-		     		    }
-		     		    in_<%=cid %>.close();
-		     		    baos_<%=cid %>.close();
+						byte[] buffer_<%=cid %> = new byte[1024];
+						int length_<%=cid %> = 0;
+						java.io.ByteArrayOutputStream baos_<%=cid %> =  new java.io.ByteArrayOutputStream();
+						while ((length_<%=cid %> = in_<%=cid %>.read(buffer_<%=cid %>, 0, 1024)) != -1) {
+							baos_<%=cid %>.write(buffer_<%=cid %>, 0, length_<%=cid %>);
+						}
+						String contentType_<%=cid%> = msg_<%=cid%>.getContentType();
+						String charsetName_<%=cid%> = "";
+						if(contentType_<%=cid%>!=null && contentType_<%=cid%>.trim().length()>0){
+							javax.mail.internet.ContentType cy_<%=cid%>  = new javax.mail.internet.ContentType(contentType_<%=cid%>);
+							charsetName_<%=cid%> = cy_<%=cid%>.getParameter("charset");
+						}
+						if(charsetName_<%=cid%>!=null && charsetName_<%=cid%>.length()>0){
+							list_<%=cid %>.add(baos_<%=cid %>.toString(charsetName_<%=cid%>));
+						}else{
+							list_<%=cid %>.add(baos_<%=cid %>.toString());
+						}
+						in_<%=cid %>.close();
+						baos_<%=cid %>.close();
 					}
-	        	}else if(part_<%=cid %>.equalsIgnoreCase("header")){
-		            java.util.Enumeration em = msg_<%=cid %>.getAllHeaderLines();
-		            int em_count=0;
-		            
-		            String tempStr_<%=cid %>="";
-		            
+				}else if(part_<%=cid %>.equalsIgnoreCase("header")){
+					java.util.Enumeration em = msg_<%=cid %>.getAllHeaderLines();
+					int em_count=0;
+
+					String tempStr_<%=cid %>="";
+
 					while (em.hasMoreElements()) {
 						tempStr_<%=cid %> = tempStr_<%=cid %> + (String) em.nextElement() + sep_<%=cid%> ;
 					}
 					list_<%=cid%>.add(decode_<%=cid%>.decode(tempStr_<%=cid%>));
-	        	}else{
-		        	if(("true").equals(mailChecked_<%=cid %>[i_<%=cid%>])){   
+				} else {
+					if(("true").equals(mailChecked_<%=cid %>[i_<%=cid%>])){
 						String[] sa_<%=cid%> = msg_<%=cid %>.getHeader(part_<%=cid%>);
 						String tempStr_<%=cid%>="";
 						for(int i=0;i<sa_<%=cid%>.length;i++){
 							tempStr_<%=cid%>=tempStr_<%=cid%>+sa_<%=cid%>[i] + sep_<%=cid%>;
 						}
 						list_<%=cid%>.add(decode_<%=cid%>.decode(tempStr_<%=cid%>));
-		        	}else{ 
-			           String content_<%=cid %> = msg_<%=cid %>.getHeader(part_<%=cid %>, null);
-			           list_<%=cid %>.add(decode_<%=cid%>.decode(content_<%=cid %>));
-		           	}    
-		        }   
-		 	}   
-	
-
-	
-			//attachment Deal
-			if(msg_<%=cid %>.isMimeType("multipart/*")){
-	 	    	javax.mail.Multipart mp<%=cid%> = (javax.mail.Multipart) msg_<%=cid %>.getContent();
-	 	    	String attachfileName<%=cid%> = "";
-	 	    	String path<%=cid%> = "";
-	 	    	java.io.BufferedOutputStream out<%=cid%> = null;
-	 	    	java.io.BufferedInputStream in<%=cid%> = null;
-	            for (int i = 0; i < mp<%=cid%>.getCount(); i++) {
-	                javax.mail.BodyPart mpart<%=cid%> = mp<%=cid%>.getBodyPart(i);
-	                String disposition<%=cid%> = mpart<%=cid%>.getDisposition();
-					<%
-			    	// fixed bug TDI-8586,to deal with attachments download
-					%>                
-	                if (mpart<%=cid%>.getFileName()!=null
-	                    && ((disposition<%=cid%> != null && (disposition<%=cid%>.equals(javax.mail.Part.ATTACHMENT) || disposition<%=cid%>.equals(javax.mail.Part.INLINE)))
-						||  disposition<%=cid%>==null)) {	<%// TDI-29179 %>
-	        	        attachfileName<%=cid%> = mpart<%=cid%>.getFileName();
-	                    attachfileName<%=cid%> = javax.mail.internet.MimeUtility.decodeText(attachfileName<%=cid%>);
-	                   
-	                    
-						if(!(<%=directory%>).endsWith("/")){
-	           				path<%=cid%> = <%=directory%> + "/";
-	        			}else{
-							path<%=cid%> =<%=directory%>;
-						}
-	                    path<%=cid%> = path<%=cid%> + attachfileName<%=cid%>;
-	                    <% if(isLog4jEnabled){ %>
-		                    	log.info("<%= cid %> - Extracted attachment: '"+attachfileName<%=cid%>+"'.");
-	                    <% } %>
-	                    java.io.File attachFile  = new java.io.File(path<%=cid%>);
-	                    out<%=cid%> = new java.io.BufferedOutputStream(new java.io.FileOutputStream(attachFile));
-	                    in<%=cid%> = new java.io.BufferedInputStream(mpart<%=cid%>.getInputStream());
-	                    int buffer<%=cid%> = 0;
-	                    while ((buffer<%=cid%> = in<%=cid%>.read()) != -1) {
-	                           out<%=cid%>.write(buffer<%=cid%>);
-	                           out<%=cid%>.flush();
-						}   
-	                    out<%=cid%>.close();
-	                    in<%=cid%>.close();    
-	                }
-	            }
+					}else{
+					   String content_<%=cid %> = msg_<%=cid %>.getHeader(part_<%=cid %>, null);
+					   list_<%=cid %>.add(decode_<%=cid%>.decode(content_<%=cid %>));
+					}
+				}
 			}
- 	         
- 	          
+
+            //attachment Deal
+            class MessagePartProcessor {
+                void saveAttachment(javax.mail.Part mpart) throws IOException, javax.mail.MessagingException {
+                    if (mpart.getFileName() != null && (
+                            mpart.getDisposition() == null ||
+                            (mpart.getDisposition().equals(javax.mail.Part.ATTACHMENT) || mpart.getDisposition().equals(javax.mail.Part.INLINE))
+                    )) {
+                        String attachFileName = javax.mail.internet.MimeUtility.decodeText(mpart.getFileName());
+
+                        String path = <%=directory%>;
+                        if(!path.endsWith("/")){
+                            path = path + "/";
+                        }
+                        path = path + attachFileName;
+                        <% if(isLog4jEnabled){ %>
+                                log.info("<%= cid %> - Extracted attachment: '" + attachFileName + "'.");
+                        <% } %>
+
+                        java.io.File attachFile = new java.io.File(path);
+                        java.io.BufferedOutputStream out = new java.io.BufferedOutputStream(new java.io.FileOutputStream(attachFile));
+                        java.io.BufferedInputStream in = new java.io.BufferedInputStream(mpart.getInputStream());
+                        int buffer = 0;
+                        while ((buffer = in.read()) != -1) {
+                            out.write(buffer);
+                            out.flush();
+                        }
+                        out.close();
+                        in.close();
+                    }
+                }
+
+                // recursively process body parts
+                void processPart(javax.mail.Part part) throws javax.mail.MessagingException, IOException {
+                    if (part.isMimeType("multipart/*")) {
+                        javax.mail.Multipart multipartContent = (javax.mail.Multipart) part.getContent();
+                        for (int i = 0; i < multipartContent.getCount(); i++) {
+                            javax.mail.Part mpart = multipartContent.getBodyPart(i);
+                            saveAttachment(mpart);
+                            processPart(mpart);
+                        }
+                    }
+                }
+            }
+            new MessagePartProcessor().processPart(msg_<%=cid %>);
+
 			// for output
 			<%
 			List< ? extends IConnection> conns = node.getOutgoingSortedConnections();
@@ -282,10 +307,10 @@
 						for (int i=1;i<conns.size();i++) {
 							IConnection conn2 = conns.get(i);
 							if ((conn2.getName().compareTo(firstConnName)!=0)&&(conn2.getLineStyle().hasConnectionCategory(IConnectionCategory.DATA))) {
-				    			for (IMetadataColumn column: metadata.getListColumns()) {%>
-	      							<%=conn2.getName() %>.<%=column.getLabel() %> = <%=firstConnName %>.<%=column.getLabel() %>;
-				 				<%
-					 			}
+								for (IMetadataColumn column: metadata.getListColumns()) {%>
+									<%=conn2.getName() %>.<%=column.getLabel() %> = <%=firstConnName %>.<%=column.getLabel() %>;
+								<%
+								}
 							}
 						}
 					}

main/plugins/org.talend.designer.components.localprovider/components/tFileInputMail/tFileInputMail_begin.javajet

@@ -37,6 +37,17 @@ if ((metadatas!=null)&&(metadatas.size()>0)) {
 		}else{
 			globalMap.put("<%=cid %>_EXPORTED_FILE_PATH",<%=directory%>);
 		}
+
+		// create output directory if not exists
+		String path = <%=directory%>;
+		if(!path.endsWith("/")){
+			path = path + "/";
+		}
+		java.io.File outputDir = new java.io.File(path);
+		if (!outputDir.exists()) {
+			outputDir.mkdirs();
+		}
+
 		boolean hasData_<%=cid%> = false;
 		<%
 		if("MIME".equals(mailType)) {