jprdonnelly/web-check
1
0
Fork 0
mirror of https://github.com/Lissy93/web-check.git synced 2026-05-13 16:01:23 -04:00
Code Issues Packages Projects Releases Wiki Activity

ref: Clearer error messaging for upstream 403 and chromium bin

Browse Source
This commit is contained in:
Alicia Sykes
2026-05-07 21:46:04 +01:00
parent ac13b20e61
commit 1ba14ef0c0
4 changed files with 22 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
api/_common/upstream.js
View File

@@ -2,8 +2,7 @@
export const upstreamError = (error, context = 'Lookup') => {
const status = error.response?.status;
if (status === 404 || status === 410) return { skipped: `No ${context} data for this host` };
if (status === 401 || status === 403)
return { error: `${context} authentication failed (check API key)` };
if (status === 401 || status === 403) return { error: `${context} blocked (HTTP ${status})` };
if (status === 429) return { error: `${context} rate-limited by upstream` };
if (status && status >= 500) return { error: `${context} upstream is unavailable` };
if (error.code === 'ECONNABORTED') return { error: `${context} timed out` };

3
api/screenshot.js
View File

@@ -84,6 +84,9 @@ const screenshotHandler = async (targetUrl) => {
try {
return { image: await puppeteerScreenshot(targetUrl) };
} catch (error) {
if (/ENOENT|Browser was not found|Could not find Chromium/i.test(error.message)) {
return { skipped: error.message };
}
log.error(`puppeteer screenshot failed: ${error.message}`);
throw error;
}

3
api/tech-stack.js
View File

@@ -34,6 +34,9 @@ const techStackHandler = async (url) => {
}
return results;
} catch (error) {
if (/ENOENT|Browser was not found|Could not find Chromium/i.test(error.message)) {
return { skipped: error.message };
}
throw new Error(error.message);
} finally {
await wappalyzer.destroy();

19
src/web-check-live/utils/parse-json.ts
View File

@@ -1,16 +1,27 @@
const FRIENDLY = 'API request failed. This may be a server error, timeout, or platform limitation.';
const STATUS_MESSAGES: Record<number, string> = {
408: 'Request timed out',
429: 'Rate limited, try again later',
500: 'Internal server error',
502: 'Bad gateway, upstream server failed',
503: 'Service temporarily unavailable',
504: 'Gateway timed out',
};
const FALLBACK = 'API request failed. This may be a server error, timeout, or platform limitation.';
// Decode a fetch Response as JSON, returning a structured error on failure
export const parseJson = async (res: Response): Promise<any> => {
try {
const json = await res.json();
if (!res.ok && !json?.error) {
return { error: json?.errorMessage || json?.message || `${FRIENDLY} (HTTP ${res.status})` };
const detail = json?.errorMessage || json?.message;
const statusMsg = STATUS_MESSAGES[res.status] || `${FALLBACK} (HTTP ${res.status})`;
return { error: detail ? `${statusMsg} - ${detail}` : statusMsg };
}
return json;
} catch {
const status = res.status ? ` (HTTP ${res.status})` : '';
return { error: `API responded with ${status}. ${FRIENDLY}` };
const statusMsg = STATUS_MESSAGES[res.status] || FALLBACK;
return { error: `${statusMsg} (HTTP ${res.status})` };
}
};