set --no-experimental-strip-types node option (#57226)
This commit is contained in:
3
.github/workflows/headless-tests.yml
vendored
3
.github/workflows/headless-tests.yml
vendored
@@ -57,6 +57,9 @@ jobs:
|
||||
- name: Run Playwright tests
|
||||
env:
|
||||
PLAYWRIGHT_WORKERS: ${{ fromJSON('[1, 4]')[github.repository == 'github/docs-internal'] }}
|
||||
# workaround for https://github.com/nodejs/node/issues/59364 as of 22.18.0
|
||||
NODE_OPTIONS: '--no-experimental-strip-types'
|
||||
|
||||
# Run playwright rendering tests and a11y tests (axe scans) as distinct checks
|
||||
# so that we can run them without blocking merges until we can be confident
|
||||
# results for a11y tests are meaningul and scenarios we're testing are correct.
|
||||
|
||||
2
.github/workflows/local-dev.yml
vendored
2
.github/workflows/local-dev.yml
vendored
@@ -50,6 +50,8 @@ jobs:
|
||||
# by default failures are marked as "flaky" instead of "failed".
|
||||
PLAYWRIGHT_RETRIES: 0
|
||||
TEST_EARLY_ACCESS: ${{ github.repository == 'github/docs-internal' }}
|
||||
# workaround for https://github.com/nodejs/node/issues/59364 as of 22.18.0
|
||||
NODE_OPTIONS: '--no-experimental-strip-types'
|
||||
run: npm run playwright-test -- playwright-local-dev
|
||||
|
||||
- name: Start server in the background
|
||||
|
||||
@@ -18,7 +18,7 @@ FROM ghcr.io/github/gh-base-image/gh-base-noble:20250805-204228-g50c20871f AS ba
|
||||
# Must run as root
|
||||
RUN apt-get -qq update && apt-get -qq install --no-install-recommends curl git \
|
||||
&& curl -sL https://deb.nodesource.com/setup_22.x | bash - \
|
||||
&& apt-get install -y nodejs=22.17.0-1nodesource1 \
|
||||
&& apt-get install -y nodejs \
|
||||
&& node --version
|
||||
|
||||
# Create the node user and home directory
|
||||
|
||||
2
package-lock.json
generated
2
package-lock.json
generated
@@ -175,7 +175,7 @@
|
||||
"website-scraper": "^5.3.1"
|
||||
},
|
||||
"engines": {
|
||||
"node": "^20 || >=22.0.0 <22.18.0"
|
||||
"node": "^20 || ^22"
|
||||
},
|
||||
"optionalDependencies": {
|
||||
"esm": "^3.2.25"
|
||||
|
||||
@@ -328,7 +328,7 @@
|
||||
"esm": "^3.2.25"
|
||||
},
|
||||
"engines": {
|
||||
"node": "^20 || >=22.0.0 <22.18.0"
|
||||
"node": "^20 || ^22"
|
||||
},
|
||||
"cacheDirectories": [
|
||||
"node_modules",
|
||||
|
||||
Reference in New Issue
Block a user